From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 4IexInCaWWRrvAAASxT56A (envelope-from ) for ; Tue, 09 May 2023 02:57:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 0LSjInCaWWTbkQAA9RJhRA (envelope-from ) for ; Tue, 09 May 2023 02:57:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 551972E4E1 for ; Tue, 9 May 2023 02:57:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwBf6-0004Oc-0a; Mon, 08 May 2023 20:57:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwBf4-0004OU-EP for guix-patches@gnu.org; Mon, 08 May 2023 20:57:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwBf4-00023K-5g for guix-patches@gnu.org; Mon, 08 May 2023 20:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwBf4-000613-0V for guix-patches@gnu.org; Mon, 08 May 2023 20:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63383] [PATCH 0/4] Various PAM improvements Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 May 2023 00:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63383 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63383@debbugs.gnu.org Cc: Felix Lechner X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168359381323101 (code B ref -1); Tue, 09 May 2023 00:57:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 May 2023 00:56:53 +0000 Received: from localhost ([127.0.0.1]:41955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwBeu-00060X-Pb for submit@debbugs.gnu.org; Mon, 08 May 2023 20:56:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:45836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwBet-00060P-3z for submit@debbugs.gnu.org; Mon, 08 May 2023 20:56:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwBes-0004Nz-HW for guix-patches@gnu.org; Mon, 08 May 2023 20:56:50 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pwBeq-00021r-LA for guix-patches@gnu.org; Mon, 08 May 2023 20:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=4BYLdWGgp/tRKHx Gzzso1mmj+VXHItn8BjoCv8hsoGw=; h=date:subject:cc:to:from; d=lease-up.com; b=MVqOi7OjnBc/yTLSSO/7rukbcCG0GLvU89s7tdWDAMA3gP8ihWxc rmUuS4EgQXkgTJrjEJDtIuuzVvcsZDo56X3n3i4ig3BH8qUapDrdDx5S04GdFZLrOEwQ7S +YjVtCo1xWKIhazukTj7TWuwCJOb4UsTA3tpkwaJzwmyP6Pkc= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 290c2e98 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Tue, 9 May 2023 00:56:42 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 54cf8e71; Tue, 9 May 2023 00:56:41 +0000 (UTC) Date: Mon, 8 May 2023 17:56:31 -0700 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@us-core.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Felix Lechner X-ACL-Warn: , Felix Lechner via Guix-patches From: Felix Lechner via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683593840; a=rsa-sha256; cv=none; b=hf+DBSUlPPfNnIIQWOG43FG4+2ZBQzoABGW1WRshX9NvI+rA6dcRiNwJ4NcYcvTdA5/WLK XGb3DJu+oI/blYcrKm5/mDkJzwEb0Qd4VoyrBv7HbFwe+XtWxoD7G3LbIOXrMmr7SOiBRZ X8DFNep9JagjBtVXMYAR62jvJPHlo+O0u8mO0c8Qm9VWeTHhOcB3+ryQF5/PbHgfbg3ONC Pv1QXUliulM62iNxBvvMwJhWP67Dqzsqm7UEOqDO3avKgaIfb0+abCCW20UIyl4k3bX4iv 09k8MAD3JU0qO/FCnHD92Sn0G7je269vYO62RsvILqTjw7WGk8OA2nM4PCAYqw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=MVqOi7Oj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683593840; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=cWVEq8E62Re+EoTOafjJRB5BJUh5CtDK4zDi8e72mr0=; b=TtGhELojMCrb6uRMOMrVPCL3lpqgrHFV7o/HfAAHDmFg+a+OYJ82KY5pV2DAEYAOXkHfXO 7oLZ8mdzOLjR/Xknlmgf6iXkZZA7W3/pnHGoCy9JadzDr64DpiExJ1rflba0flLq7vVFi0 r+6MpLqX/j+lHXU+JZmNBD2H/cW3Yws4ZwTO2GrAwX8U62wA+x7IxGa52pxwxhExRPxSn6 1PfX6FoO57J6lgMyRYyTT5IqCt3LRxSXqE8/NC2WW3hx+tfk8ClbQ/XE93l+N2RhasgKD6 952MGiA96gb9qDneRDc5hSEvdjXhMuLKCybDbrvkbans8OLQY1hYZTrzbTYVwg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lease-up.com header.s=2017 header.b=MVqOi7Oj; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.89 X-Spam-Score: -1.89 X-Migadu-Queue-Id: 551972E4E1 X-TUID: yHZEFx8aovr+ This commit series makes several improvements to the way Linux-PAM is used in Guix. Most notably, it employs absolute paths into the store where possible. The series also improves significantly on the system test for pam_limits. These commits have been tested and already being deployed in production. Additional details are in the commit messages. Felix Lechner (4): In PAM test, confirm ulimits actually imposed instead of comparing config files. Drop limits.conf from /etc/security; use directly in pam-limits-service-type. Refer to the built-in Linux-PAM modules by their absolute paths. Use more file-append. gnu/services/authentication.scm | 2 +- gnu/services/base.scm | 65 +++++++++++++++--------------- gnu/services/kerberos.scm | 2 +- gnu/services/lightdm.scm | 60 ++++++++++++++++++++-------- gnu/services/pam-mount.scm | 2 +- gnu/services/sddm.scm | 33 ++++++++-------- gnu/services/xorg.scm | 5 ++- gnu/system/pam.scm | 20 +++++----- gnu/tests/pam.scm | 70 ++++++++++++++++++--------------- 9 files changed, 146 insertions(+), 113 deletions(-) base-commit: d1aba42ad4e1909faa21d484975c5954c778e002 -- 2.39.2