From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gG6wC3JORGFTlwAAgWs5BA (envelope-from ) for ; Fri, 17 Sep 2021 10:14:42 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oPJCB3JORGGWTwAAbx9fmQ (envelope-from ) for ; Fri, 17 Sep 2021 08:14:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5BF34DE8D for ; Fri, 17 Sep 2021 10:14:41 +0200 (CEST) Received: from localhost ([::1]:34410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mR916-0006r5-Bq for larch@yhetil.org; Fri, 17 Sep 2021 04:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mR8rm-0003bI-Sp for guix-patches@gnu.org; Fri, 17 Sep 2021 04:05:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mR8rm-0007jh-7A for guix-patches@gnu.org; Fri, 17 Sep 2021 04:05:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mR8rm-0001Lb-1I for guix-patches@gnu.org; Fri, 17 Sep 2021 04:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50359] [PATCH v3 0/3] Add 'generic-git' updater Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 17 Sep 2021 08:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50359 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50359@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Sarah Morgensen Received: via spool by 50359-submit@debbugs.gnu.org id=B50359.16318658675088 (code B ref 50359); Fri, 17 Sep 2021 08:05:01 +0000 Received: (at 50359) by debbugs.gnu.org; 17 Sep 2021 08:04:27 +0000 Received: from localhost ([127.0.0.1]:58393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR8rD-0001K0-91 for submit@debbugs.gnu.org; Fri, 17 Sep 2021 04:04:27 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:60966 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mR8rA-0001Jn-Jc for 50359@debbugs.gnu.org; Fri, 17 Sep 2021 04:04:25 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631865856; bh=3/1QAwDfGvCkAb5h7ewSepFyjRMpev4Km5eLg5NeaYs=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=JH9FnL4Q1rH5G6rMjS34DsjfKzAnlv/1dzDHjkn1xZFrhl9KDKGbLj/LBtJibXm0n ivWQnOCYBP86GFbs+HJ63ShVQEOuSrqmsv9cI3UsaFdkYb39XgSliU/itLTGb5/6yX YoHoTlGMH4Cy08TCZPdS2oEjQsT1eRjUuQ3HOELs= In-Reply-To: References: Message-Id: Date: Fri, 17 Sep 2021 10:04:15 +0200 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631866481; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=XMjIwUK5DZiB/jQHWDsfYiQwJ3AiXKzEfxt7BRliQN4=; b=BMUpFw5hscEvTUpvAi9rjMIqKkfNE6KeYsYzMmgxx4PI/AKKXGKlEyCLvGN39x4Va0CkK7 Twm+sUgqrGHg+98Ancnfh3CxDXGo/ct0DdoYfyLjVGH+yNf9UR8QOz3EIcr64NI36FqGEt TyXUqjA8WJOi5jN2tYKlKXuHA5DwVr+e7z5KSXHIpsA5i9a+f/vC8RhaQkxbZBkCeCiesY +XzjTq/Ufgx6sPqilnyvN3/FitOjorHqGYlgCcs0T8O3Fr/hi7y3vKYFF5bPtEPCoasBj2 xL8ExbXtQxmPbI6lKOIFXYSsM4GvQu/Txi0wJwEZSY/NK7MpoUE5yz4OFtqB6w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631866481; a=rsa-sha256; cv=none; b=f+N5WjSli+PTiwHSJ1N83ZqqTnWXkLDyrO/mUtq+0hKMse5Gttq2ktThI/UEKNiYOBX+sR AQNzCp7ssXamLMMcviE7MjBy8Ypfsf/dEFEAfYn7+5t+k4Eu9gfJAKne0b6s6DUuwVpIBz hORoJufFO4x641kUM66KAsgAU4QHCzxXtVXvO78gpE0n/yA3yXlIxybvuxOYzlHzJSb4Ml nZs82mxHaWSBf16G+mr8K2yi7++6kCHsErbqI06S3TDZs2zd6bVzWnP2hnYW41XrIJcSA3 JoQ5BoiSTxG8MZlZHPdeEROhWRXi7zR94ZBD6NvMWR18M7gZqTNtRYAptTlEMQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=JH9FnL4Q; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=JH9FnL4Q; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5BF34DE8D X-Spam-Score: -2.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: JYNqeUynzivh --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Changes since v2: * Address the feedback by Ludovic and Sarah. One problem I noticed was that when =E2=80=98accept-pre-releases?=E2=80=99 = is #t, a tag like =E2=80=9C1-2-3-alpha=E2=80=9D would turn into =E2=80=9C1.2.3.alpha=E2= =80=9D, but I think the correct version string would be =E2=80=9C1.2.3-alpha=E2=80=9D. I solved the problem by making the pre-release part a separate regexp group, and then appending the pre-release part after extracting the version from the tag. That way, the =E2=80=9C-=E2=80=9D in =E2=80=9C-alpha= =E2=80=9D would not be interpreted as a version delimiter. I also added a new test for testing this. One of the tests in tests/channels.scm is failing; I am not sure why. Before the first and second patches were applied, 6 of them were failing for me, so I guess it=E2=80=99s an improvement. However, on IRC, Ludovic s= aid that all of them were passing (prior to apply my patches). It would be great if people could run the tests before and after applying patches, and see if they pass. Xinglu Chen (3): tests: git: Don't read from the users global Git config file. tests: git: Make 'tag' directive non-interactive. import: Add 'generic-git' updater. Makefile.am | 2 + doc/guix.texi | 34 ++++++ guix/git.scm | 41 ++++++++ guix/import/git.scm | 225 +++++++++++++++++++++++++++++++++++++++ guix/tests/git.scm | 6 +- tests/channels.scm | 2 +- tests/git.scm | 28 +++++ tests/import-git.scm | 245 +++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 580 insertions(+), 3 deletions(-) create mode 100644 guix/import/git.scm create mode 100644 tests/import-git.scm base-commit: 33bc3fb2a5f30a6e21f1b8d6d43867d921bd951c =2D-=20 2.33.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFES/8VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5McIP/At0XwVS5YLZMbunOsHxMC1/bEcM iD8qc4gatT7bnM3Aa4GF9lKRWcqlTZWWLeIiOX1Omg+GR0ZTxngaRFMGbhkptMG6 iDc4wzRee+sR2rD37fUeL8Q7F3n58+OGUK8BHWTy93Sp4XrSaP7RoXxoelxVejO4 HwsEIAo6VaIHaV4SHj4G0rvELlglYtl+87rC5DPFECRRfs37r4IjF289xXwMzH87 ghqOk2Kuu3mTvMVn1S270gpiN4NWrQYNn/l8lVHkzY9aMUCczmd534FN6HabRUfH XiB3nWXoXYb6ncOGZa7CYNdQrBvMvZrlBGW76MrcFYaXuS088KDjQHIhb8qvYvA1 JA/aejKHzZixJd/eTR0LioHmImVpors6NPb1IBv6BUywf1nXlGnQa/22JijKCKdb A/EqgZ/JN7pSjD+CtqE28E9BWMenwr8Ouz77RENJdzA/k1mqwuuMuGVKNM9vk/5P qpmpo93jeU6JXXAba4GVy9/np+IkDls12j1JEa7cTHhVOpBqqsnnmdCcByRcv8VK wyvyoliikk2MJrOucI5IJnz1E83QRZP+4qgGtsor3cu59bwdYkmn238lu8KlD8CP 22RnIeZ4Y9V9fZC5bq5K+Jf5pAfCoIf2T426YFYGv6r7Zu9U0y0QVoIHZA+e5/Uz OvoEsf4xHHsE41Mn =lomJ -----END PGP SIGNATURE----- --=-=-=--