From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: [PATCH 0/1] Remove an unused patch? Date: Fri, 19 Feb 2016 23:22:30 -0500 Message-ID: Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWz45-0006fB-3B for guix-devel@gnu.org; Fri, 19 Feb 2016 23:22:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWz41-0007Ds-0E for guix-devel@gnu.org; Fri, 19 Feb 2016 23:22:40 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWz40-0007Do-Qr for guix-devel@gnu.org; Fri, 19 Feb 2016 23:22:36 -0500 Received: from jasmine.lan (c-69-249-5-231.hsd1.pa.comcast.net [69.249.5.231]) by mail.messagingengine.com (Postfix) with ESMTPA id BB70F680134 for ; Fri, 19 Feb 2016 23:22:35 -0500 (EST) List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org The patch file 'cpio-gets-undeclared.patch' was "de-applied" to the cpio sources when we upgraded cpio to 2.12 (92d0fcb6dc5). But, it was never deleted or removed from gnu-system.am. So, should we delete it or re-apply it? I guess the answer depends on whether or not cpio still uses gets(). I searched for use of gets() in the cpio-2.12 source tree like this: $ grep -rI 'gets (' $ grep -rI 'gets(' All the results were uses of fgets(). Is that reasonable method of searching or should I continue with some other technique? Leo Famulari (1): gnu: cpio: Remove unused patch. gnu-system.am | 1 - gnu/packages/patches/cpio-gets-undeclared.patch | 45 ------------------------- 2 files changed, 46 deletions(-) delete mode 100644 gnu/packages/patches/cpio-gets-undeclared.patch -- 2.7.1