From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmZzO-0007Sp-KA for guix-patches@gnu.org; Tue, 29 Aug 2017 02:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmZzK-0002HJ-JF for guix-patches@gnu.org; Tue, 29 Aug 2017 02:27:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51354) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dmZzK-0002H2-As for guix-patches@gnu.org; Tue, 29 Aug 2017 02:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dmZzJ-0002Gg-VO for guix-patches@gnu.org; Tue, 29 Aug 2017 02:27:02 -0400 Subject: [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful. Resent-Message-ID: Message-Id: MIME-Version: 1.0 From: Arun Isaac Date: Tue, 29 Aug 2017 11:55:08 +0530 In-reply-to: <20170822171303.21754-1-mail@cbaines.net> References: <20170822171303.21754-1-mail@cbaines.net> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 28185@debbugs.gnu.org Christopher Baines writes: > Modify the install phase to detect when nothing has been installed, and e= rror > if this happens. This is preferable to continuing, and allowing the next = phase > to fail. > > Also, when nothing can be found to be installed, print out each file that= was > considered, along with the regular expressions that were used to include = and > exclude it. > > * gnu/build/emacs-build-system.scm (install-file?): Add additional error > checking and logging. > --- > guix/build/emacs-build-system.scm | 45 ++++++++++++++++++++++++++++-----= ------ > 1 file changed, 32 insertions(+), 13 deletions(-) I feel that this adds a lot of complexity (lines of code) to the emacs-build-system checking for an error that can be quite easily identified and fixed otherwise. WDYT? Maybe, others can comment on this as well. =