all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Christopher Baines <mail@cbaines.net>
Cc: 28185@debbugs.gnu.org
Subject: [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful.
Date: Tue, 29 Aug 2017 11:55:08 +0530	[thread overview]
Message-ID: <cfe7bc99.ADkAAC0m-p0AAAAAAAAAAAPmDT8AAAACwQwAAAAAAAW9WABZpQjV@mailjet.com> (raw)
In-Reply-To: <20170822171303.21754-1-mail@cbaines.net>


Christopher Baines writes:

> Modify the install phase to detect when nothing has been installed, and error
> if this happens. This is preferable to continuing, and allowing the next phase
> to fail.
>
> Also, when nothing can be found to be installed, print out each file that was
> considered, along with the regular expressions that were used to include and
> exclude it.
>
> * gnu/build/emacs-build-system.scm (install-file?): Add additional error
>   checking and logging.
> ---
>  guix/build/emacs-build-system.scm | 45 ++++++++++++++++++++++++++++-----------
>  1 file changed, 32 insertions(+), 13 deletions(-)

I feel that this adds a lot of complexity (lines of code) to the
emacs-build-system checking for an error that can be quite easily
identified and fixed otherwise.

WDYT? Maybe, others can comment on this as well.

  reply	other threads:[~2017-08-29  6:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 17:13 [bug#28185] [PATCH] build: emacs-build-system: Make the install phase more helpful Christopher Baines
2017-08-29  6:25 ` Arun Isaac [this message]
2017-08-29  6:31   ` Jelle Licht
2017-08-29  7:46     ` Arun Isaac
     [not found] ` <3c5556d2.ADkAAC0m-p4AAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZpQjV@mailjet.com>
2017-08-29  6:58   ` Christopher Baines
2017-08-29 21:46     ` Ludovic Courtès
2017-08-30  6:48       ` Christopher Baines
2017-08-29 21:50 ` Ludovic Courtès
2017-08-30  7:28   ` Christopher Baines
2017-08-30  8:39     ` Ludovic Courtès
2017-08-30  6:48 ` Christopher Baines
2017-08-30  8:07 ` Arun Isaac
     [not found] ` <6f595802.AEMAPOK4d0UAAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZpnJ1@mailjet.com>
2017-08-31 21:41   ` Christopher Baines
2017-09-01  5:02     ` Arun Isaac
     [not found]     ` <d5168f7c.AEAAPQNLdNwAAAAAAAAAAAPmDT4AAAACwQwAAAAAAAW9WABZqOnq@mailjet.com>
2017-09-01 21:08       ` bug#28185: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfe7bc99.ADkAAC0m-p0AAAAAAAAAAAPmDT8AAAACwQwAAAAAAAW9WABZpQjV@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=28185@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.