From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Sini=C5=A1a_Bi=C4=91in?= Subject: Re: [PATCH] gnu: Add cabal-install. Date: Wed, 26 Aug 2015 05:59:51 +0200 Message-ID: References: <87lhczf49h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_db89befe9f5ad73ce6fe610575d89e1a" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZURsU-00076q-Ae for guix-devel@gnu.org; Tue, 25 Aug 2015 23:59:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZURsQ-0001Z8-8O for guix-devel@gnu.org; Tue, 25 Aug 2015 23:59:58 -0400 In-Reply-To: <87lhczf49h.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: ludo@gnu.org Cc: guix-devel@gnu.org --=_db89befe9f5ad73ce6fe610575d89e1a Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-08-25 23:27, ludo@gnu.org wrote: > Please add a copyright line for yourself. Added. >> + (arguments `(#:tests? #f)) >=20 > Could you add a comment above explaining why tests are disabled? (We > generally avoid that unless there=E2=80=99s a good reason, sometimes be= cause > running the tests would be unnecessarily complex.) I've added a simple "FIXME" comment to that line, similar to how the other haskell.scm packages do it. The reason is that the ghc-* libs needed to enable testing haven't been imported yet. I've attempted to fix that, but got tangled up in conflicting dependency versions and gave up for now. >> + (synopsis "The command-line interface for Cabal and Hackage.") >=20 > Remove =E2=80=9CThe=E2=80=9D and the period (and make sure to run =E2=80= =98guix lint=E2=80=99 ;-)). Also fixed. > Could you send an updated patch? Sure, you'll find it attached. Thanks, Sini=C5=A1a --=_db89befe9f5ad73ce6fe610575d89e1a Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-cabal-install.patch Content-Disposition: attachment; filename=0001-gnu-Add-cabal-install.patch; size=2047 RnJvbSBhOGUzOTkwYmUxNGU0MjU5ZTdlOGJlZWVhY2VmNzQ0Y2VlN2U2Y2FlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2luaT1DNT1BMWE9MjBCaT1DND05MWluPz0g PHNpbmlzYUBiaWRpbi5ldT4KRGF0ZTogVHVlLCAxOCBBdWcgMjAxNSAxNjoxOToxMSArMDIwMApT dWJqZWN0OiBbUEFUQ0hdIGdudTogQWRkIGNhYmFsLWluc3RhbGwuCgoqIGdudS9wYWNrYWdlcy9o YXNrZWxsLnNjbSAoY2FiYWwtaW5zdGFsbCk6IE5ldyB2YXJpYWJsZS4KLS0tCiBnbnUvcGFja2Fn ZXMvaGFza2VsbC5zY20gfCAzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBm aWxlIGNoYW5nZWQsIDMyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv aGFza2VsbC5zY20gYi9nbnUvcGFja2FnZXMvaGFza2VsbC5zY20KaW5kZXggMzNlYjFiNS4uZjg2 NmMxZCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2hhc2tlbGwuc2NtCisrKyBiL2dudS9wYWNr YWdlcy9oYXNrZWxsLnNjbQpAQCAtMSw1ICsxLDYgQEAKIDs7OyBHTlUgR3VpeCAtLS0gRnVuY3Rp b25hbCBwYWNrYWdlIG1hbmFnZW1lbnQgZm9yIEdOVQogOzs7IENvcHlyaWdodCDCqSAyMDE1IEZl ZGVyaWNvIEJlZmZhIDxiZWZmYUBmYmVuZ2luZWVyaW5nLmNoPgorOzs7IENvcHlyaWdodCDCqSAy MDE1IFNpbmnFoWEgQmnEkWluIDxzaW5pc2FAYmlkaW4uZXU+CiA7OzsKIDs7OyBUaGlzIGZpbGUg aXMgcGFydCBvZiBHTlUgR3VpeC4KIDs7OwpAQCAtMjM4LDYgKzIzOSwzNyBAQAogaW50ZXJhY3Rp dmUgZW52aXJvbm1lbnQgZm9yIHRoZSBmdW5jdGlvbmFsIGxhbmd1YWdlIEhhc2tlbGwuIikKICAg ICAobGljZW5zZSBic2QtMykpKQogCisoZGVmaW5lLXB1YmxpYyBjYWJhbC1pbnN0YWxsCisgKHBh Y2thZ2UKKyAgKG5hbWUgImNhYmFsLWluc3RhbGwiKQorICAgKHZlcnNpb24gIjEuMTguMS4wIikK KyAgIChzb3VyY2UKKyAgICAob3JpZ2luCisgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAg KHVyaSAoc3RyaW5nLWFwcGVuZAorICAgICAgICAgICAgImh0dHA6Ly9oYWNrYWdlLmhhc2tlbGwu b3JnL3BhY2thZ2UvY2FiYWwtaW5zdGFsbC9jYWJhbC1pbnN0YWxsLSIKKyAgICAgICAgICAgIHZl cnNpb24KKyAgICAgICAgICAgICIudGFyLmd6IikpCisgICAgICAoc2hhMjU2CisgICAgICAgKGJh c2UzMiAiMXIxc2hodm5wZ3hmOTFybWJ2M3dhMXJrZDI0cGxiZ3I2YnB6M2FqODBpcjB6M3piZGF5 biIpKSkpCisgICAoYXJndW1lbnRzIGAoIzp0ZXN0cz8gI2YpKSA7IEZJWE1FOiB0ZXN0aW5nIGxp YnJhcmllcyBhcmUgbWlzc2luZy4KKyAgIChidWlsZC1zeXN0ZW0gaGFza2VsbC1idWlsZC1zeXN0 ZW0pCisgICAocHJvcGFnYXRlZC1pbnB1dHMKKyAgICBgKCgiZ2hjLWh0dHAiICxnaGMtaHR0cCkK KyAgICAgICgiZ2hjLW10bCIgLGdoYy1tdGwpCisgICAgICAoImdoYy1uZXR3b3JrLXVyaSIgLGdo Yy1uZXR3b3JrLXVyaSkKKyAgICAgICgiZ2hjLW5ldHdvcmsiICxnaGMtbmV0d29yaykKKyAgICAg ICgiZ2hjLXJhbmRvbSIgLGdoYy1yYW5kb20pCisgICAgICAoImdoYy1zdG0iICxnaGMtc3RtKQor ICAgICAgKCJnaGMtemxpYiIgLGdoYy16bGliKSkpCisgICAoaG9tZS1wYWdlICJodHRwOi8vd3d3 Lmhhc2tlbGwub3JnL2NhYmFsLyIpCisgICAoc3lub3BzaXMgIkNvbW1hbmQtbGluZSBpbnRlcmZh Y2UgZm9yIENhYmFsIGFuZCBIYWNrYWdlIikKKyAgIChkZXNjcmlwdGlvbgorICAgICJUaGUgY2Fi YWwgY29tbWFuZC1saW5lIHByb2dyYW0gc2ltcGxpZmllcyB0aGUgcHJvY2VzcyBvZiBtYW5hZ2lu ZworSGFza2VsbCBzb2Z0d2FyZSBieSBhdXRvbWF0aW5nIHRoZSBmZXRjaGluZywgY29uZmlndXJh dGlvbiwgY29tcGlsYXRpb24gYW5kCitpbnN0YWxsYXRpb24gb2YgSGFza2VsbCBsaWJyYXJpZXMg YW5kIHByb2dyYW1zLiIpCisgICAobGljZW5zZSBic2QtMykpKQorCiAoZGVmaW5lLXB1YmxpYyBn aGMtbXRsCiAgIChwYWNrYWdlCiAgICAgKG5hbWUgImdoYy1tdGwiKQotLSAKMi41LjAKCg== --=_db89befe9f5ad73ce6fe610575d89e1a--