all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#71362] [PATCH] gnu: rust-nix-0.28: fix package test.
@ 2024-06-04 12:34 picnoir
  2024-06-06 19:53 ` bug#71362: " Christopher Baines
  0 siblings, 1 reply; 2+ messages in thread
From: picnoir @ 2024-06-04 12:34 UTC (permalink / raw)
  To: 71362; +Cc: Picnoir, Efraim Flashner

From: Picnoir <picnoir@alternativebit.fr>

This package was introduced as a dependency for Nsncd. The package
test suite is not run when building Nsncd, we did not realize it was
failing.

* gnu/packages/crates-io.scm (rust-nix-0.28): Fix test phase, enable all crate
for cargo test, disable failing tests.

Change-Id: Ice72d93b3a3f5f02640d2c1f90d745dc4b1a6550
---
 gnu/packages/crates-io.scm | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 5c9bc4c525..80d851a4cc 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -41048,7 +41048,30 @@ (define-public rust-nix-0.28
         (base32 "1r0rylax4ycx3iqakwjvaa178jrrwiiwghcw95ndzy72zk25c8db"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs (("rust-bitflags" ,rust-bitflags-2)
+     `(#:cargo-test-flags
+       '("--all-features"
+         "--"
+         ; The following tests do not seem to terminate
+         "--skip=test_unistd::test_execveat_empty::test_cstr_ref"
+         "--skip=test_unistd::test_execveat_empty::test_cstring"
+         "--skip=test_unistd::test_execveat_relative::test_cstr_ref"
+         "--skip=test_unistd::test_execveat_relative::test_cstring"
+         "--skip=test_unistd::test_fexecve::test_cstr_ref"
+         "--skip=test_unistd::test_fexecve::test_cstring"
+         ; The following tests are failing
+         "--skip=test_unistd::test_execve::test_cstr_ref"
+         "--skip=test_unistd::test_execve::test_cstring"
+         "--skip=test_unistd::test_execveat_absolute::test_cstr_ref"
+         "--skip=test_unistd::test_execveat_absolute::test_cstring"
+         ; The following tests are panicking
+         "--skip=sys::personality::set"
+         "--skip=sys::socket::sendmsg"
+         "--skip=unistd::Group::from_gid"
+         "--skip=unistd::Group::from_name"
+         "--skip=unistd::User::from_name"
+         "--skip=unistd::User::from_uid"
+         )
+       #:cargo-inputs (("rust-bitflags" ,rust-bitflags-2)
                        ("rust-cfg-if" ,rust-cfg-if-1)
                        ("rust-cfg-aliases" ,rust-cfg-aliases-0.1)
                        ("rust-libc" ,rust-libc-0.2.153)

base-commit: 5d3edff1a604414a3c42b89fcbc007e9d573993d
prerequisite-patch-id: 6e77bad801c8584f6478c9c59038597dee857cde
--
2.41.0




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#71362: [PATCH] gnu: rust-nix-0.28: fix package test.
  2024-06-04 12:34 [bug#71362] [PATCH] gnu: rust-nix-0.28: fix package test picnoir
@ 2024-06-06 19:53 ` Christopher Baines
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher Baines @ 2024-06-06 19:53 UTC (permalink / raw)
  To: picnoir; +Cc: 71362-done, Efraim Flashner

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

picnoir@alternativebit.fr writes:

> From: Picnoir <picnoir@alternativebit.fr>
>
> This package was introduced as a dependency for Nsncd. The package
> test suite is not run when building Nsncd, we did not realize it was
> failing.
>
> * gnu/packages/crates-io.scm (rust-nix-0.28): Fix test phase, enable all crate
> for cargo test, disable failing tests.
>
> Change-Id: Ice72d93b3a3f5f02640d2c1f90d745dc4b1a6550
> ---
>  gnu/packages/crates-io.scm | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)

Thanks for the patch, I've pushed this to master as
f430a1938818b8bb8cb575b575bf3f52b4413d0a.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-06 19:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 12:34 [bug#71362] [PATCH] gnu: rust-nix-0.28: fix package test picnoir
2024-06-06 19:53 ` bug#71362: " Christopher Baines

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.