From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8D+8BJktmWFp9wAAgWs5BA (envelope-from ) for ; Sat, 20 Nov 2021 18:17:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aOA5AJktmWFrPwAAbx9fmQ (envelope-from ) for ; Sat, 20 Nov 2021 17:17:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EF5420669 for ; Sat, 20 Nov 2021 18:17:12 +0100 (CET) Received: from localhost ([::1]:55134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moTzD-0002au-QR for larch@yhetil.org; Sat, 20 Nov 2021 12:17:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moTz3-0002Z5-Ux for guix-patches@gnu.org; Sat, 20 Nov 2021 12:17:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moTz3-0005RY-Lu for guix-patches@gnu.org; Sat, 20 Nov 2021 12:17:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moTz3-0005vC-HT for guix-patches@gnu.org; Sat, 20 Nov 2021 12:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v2 18/26] guix: node-build-system: Add optional #:libuv? argument. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 20 Nov 2021 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 51838@debbugs.gnu.org Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163742860521908 (code B ref 51838); Sat, 20 Nov 2021 17:17:01 +0000 Received: (at 51838) by debbugs.gnu.org; 20 Nov 2021 17:16:45 +0000 Received: from localhost ([127.0.0.1]:43620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moTyn-0005h1-22 for submit@debbugs.gnu.org; Sat, 20 Nov 2021 12:16:45 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:46952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moTym-0005c8-66 for 51838@debbugs.gnu.org; Sat, 20 Nov 2021 12:16:44 -0500 Received: by mail-qv1-f42.google.com with SMTP id jo22so9289557qvb.13 for <51838@debbugs.gnu.org>; Sat, 20 Nov 2021 09:16:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=RpuOT16S+C5qDdRGaHM3A+72/IJ6HAtBPvyOfvbOaJA=; b=bwIb+KTSjc+vD8puMCYX4mEtD7yQURNHCgbK5Zt8C7lBNeaN30KBvHzhoSh5+etDif 1wdoCGaE9PJCMhFIuiaDxlStWqeVH1izyge2Ml7AaQ9txrvF5C7zATF/oeGNcOvLo+mS +G51berR2xEvGVjv4y8oBc64h0c10J4CoAFNTTkAEoGRZngLYZ3nLeaQoSQSZPZS4HI1 yJwbz3Kaaa1VG3z4Xmu0KYnjiZHQ6c0+jG61tMF6CCoSD23ACgi4Lz75cicNt3lmV2ro Lk1zhqyg+nNuvKBGhk/b08Iir3wV9sz1jVgA9rR3ta6iwtpP/AjtQkPqrToM5I+ApY+A zBEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=RpuOT16S+C5qDdRGaHM3A+72/IJ6HAtBPvyOfvbOaJA=; b=p75OvAiA+DlPn0n2HyhPUcdmbn3S0iMFG1j25raqYQjfyJIAK+lZtSQhcomvsejYyJ 4NGOr4EtYpfcx2A6wVEju2orAhRrTP7xJMsbFP1oLjfIs4AQdXNWeSh5Lhb8FJ6vDXiT 91SoudFpQ3B0EIOu4ib73hQYIaDmIlfnxfmxxAp4jpIhuF3TmvkYmc5ygUExOBTeFpWi lpqiQfgw0WJ3Q9FMvkmruqTKqiaznpybIahYIvXpYWFC7UpCebtbEePeEPRtu2d0cVA6 toNtAspGZNBG7nHAtyXhOLDFRqEE0XkN5cJEmxo/iAAfxW0aH2Hqq0bbytciwAjq8D+R 8CoA== X-Gm-Message-State: AOAM530o5TiBoGK/4vJkKLbjv78m4V8+7r6VoSRWm7j20FaDAryrO6WE iO7uuhZLKdewb9NWGTMYStXfNg== X-Google-Smtp-Source: ABdhPJxCTZytVa7zxsHJRbS+oTiFJIWnflWHIB6NKHkJGDzKqkG4zJJj3N4p6AkV8LgYazkg7EQxMQ== X-Received: by 2002:a05:6214:2b05:: with SMTP id jx5mr85347033qvb.9.1637428598675; Sat, 20 Nov 2021 09:16:38 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id n13sm1885512qkp.19.2021.11.20.09.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Nov 2021 09:16:38 -0800 (PST) Message-ID: Date: Sat, 20 Nov 2021 12:16:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <5a04aa92-e80d-e11b-235c-b7f5e3a92d00@philipmcgrath.com> <20211120043406.952350-1-philip@philipmcgrath.com> <20211120043406.952350-18-philip@philipmcgrath.com> <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@gmail.com> From: Philip McGrath In-Reply-To: <15a8348b0c5b080d590f68cc14bca99afd5d7834.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637428632; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RpuOT16S+C5qDdRGaHM3A+72/IJ6HAtBPvyOfvbOaJA=; b=AoyzfSWuvZW22f1YUqbJQwQ+fWvvIFZW5ytAwBDQdxdfqhIG3DyHbvPM2XtQvU3q3R1So8 6yi5myD8NRrlJi5XtfxsZdU8GIQW7zjL5gnknBx8O3nGbJivjkyNNnGtec+vhHWdS6pDpf 0jGKtTSfWRy/48XFhSZsyNm3194cApI2ANZ47wFIMK8WH8q+Au9NVSRv0wLo/D0FqEoZlk yXURSP2hcJiI6olxJsAKCCvtUSL7Y4rKoVXRGFkyPyB0Hp4vOrGra0Bgr6pgleG0CZFZl2 Ulc0deMrKhiY73aFBL9sEzFo/y+X2IEtNQ4El8ZmHWLArENqTcuY8IQ+Fn+2vg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637428632; a=rsa-sha256; cv=none; b=DDUOMFHcZGoJELPKfmztkc/zByZrThT4DsPa/dLmYp0hp8ghkPiZbbCXSf3uiqQg+Tm5Z/ LevCKYkHrKeyWygQex20IupJcVIEuU3SFhmhpvz4ydKfYGP70UJzj8yI3beNeWL9qyK2jb jqzn6GA0cBRJ+aqXacUbeWUEoY/S1e4ilGTGKHqm9La2NmYZiaLAIMKZNGTqQCEvw/C9DF HmtjVWPr36/ySfGFZZsoZfTlUW+HOYKQkbkOtKs3NSn/w/ivddZmGFmUSqq+651l9TJ/hJ wokf6/Fv9qYFhdi/Tx27Rckc6/uu3akU2EXa4kDSypGEG3B7tlbUm8tWIC3S/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=bwIb+KTS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.87 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=bwIb+KTS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9EF5420669 X-Spam-Score: -1.87 X-Migadu-Scanner: scn0.migadu.com X-TUID: a+foNtHFmj/x On 11/20/21 02:46, Liliana Marie Prikler wrote: > Am Freitag, den 19.11.2021, 23:33 -0500 schrieb Philip McGrath: >> * guix/build-system/node.scm (lower): Add an optional #:libuv? >> argument to tell the build system to add the version of libuv >> used as an input to the #:node package as an additional implicit >> input, so that packages needing libuv always get the correct version. > Would it change something if we always had libuv as implicit input? I > don't think it'd do much for closure size, but it might impact implicit > package search as proposed by my solution to the #:absent-dependencies > thing. From a Guix perspective, I don't think it would make much difference, since libuv is always needed by node itself. Maybe it would require more grafting than would be needed otherwise? But I think the recommendation for authors of node add-ons is to avoid libuv unless it's really needed, because it has fewer stability guarantees that other Node.js APIs.