From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YGYrO4N05GPYAwEAbAwnHQ (envelope-from ) for ; Thu, 09 Feb 2023 05:20:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iJAVO4N05GNcSAEAauVa8A (envelope-from ) for ; Thu, 09 Feb 2023 05:20:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B85BD16B7E for ; Thu, 9 Feb 2023 05:20:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPyPn-0000Eq-Jp; Wed, 08 Feb 2023 23:20:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPyPi-0000ED-Sy for guix-patches@gnu.org; Wed, 08 Feb 2023 23:20:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPyPi-0003aD-J3 for guix-patches@gnu.org; Wed, 08 Feb 2023 23:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPyPi-0001HX-3I for guix-patches@gnu.org; Wed, 08 Feb 2023 23:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60788] [PATCH] services: Add vnstat-service-type. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Feb 2023 04:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60788 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 60788@debbugs.gnu.org Received: via spool by 60788-submit@debbugs.gnu.org id=B60788.16759163904903 (code B ref 60788); Thu, 09 Feb 2023 04:20:02 +0000 Received: (at 60788) by debbugs.gnu.org; 9 Feb 2023 04:19:50 +0000 Received: from localhost ([127.0.0.1]:57169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPyPV-0001H1-Nu for submit@debbugs.gnu.org; Wed, 08 Feb 2023 23:19:49 -0500 Received: from smtpm7.myservices.hosting ([185.26.105.208]:51750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPyPT-0001Gr-8q for 60788@debbugs.gnu.org; Wed, 08 Feb 2023 23:19:49 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpm7.myservices.hosting (Postfix) with ESMTP id B3B6E20CFC; Thu, 9 Feb 2023 05:19:45 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 6692080096; Thu, 9 Feb 2023 05:19:45 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RiC9zi6VEQND; Thu, 9 Feb 2023 05:19:45 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id D46CC80093; Thu, 9 Feb 2023 05:19:44 +0100 (CET) Message-ID: Date: Thu, 9 Feb 2023 04:19:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US References: <95b646eb6b23dec213cba43b6e4e7ddc4a601d0f.1673640404.git.mirai@makinata.eu> <8b62c1b5643a09163b53af4bf03bb12862770b50.1675779899.git.mirai@makinata.eu> <87357fjyuc.fsf_-_@gmail.com> From: Bruno Victal In-Reply-To: <87357fjyuc.fsf_-_@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675916419; a=rsa-sha256; cv=none; b=LThBEWL4nQQhVuIGWF1FzSsKz2vHmhCujjZdJZJf0A4O6vW5khcej3TX2p2gsGtEVypBcM PO49WbkbNh9pQbi/Qga7RA6nipsxo26WPaDKcKW87TkKfXbAzu42CaysoGjisEXTb9abLt 44zAGltLoMEhpUWSX2kOCvN21OV/ot/J4WVQv8LOXt28a2YHxA5A6GCon/nTUxpOYyHZXa HPwOy9oEfpwE1h29HXyQbljgkyiv1Ki+nSx/BHm4KwoNvyDmQ3AN+HGg7BVNGUS79Uwyr7 G8gY5dlPL4t+k3iWBxfAvBFUC8qbh8j3sMPb0F3wMIGi9TYT+MlzJqyqqd0+Gw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675916419; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=y3QPggjWtp53wJsSZ9gtuMAxFptGGwEsF7gY/oNTxSg=; b=fm8aZe+8VhOeNfaMIxnZLRJ0zgBXdXZxaBrlHZUNfPJ3Pfv0jsK6jQ+PCE6H44nAZlbozM z12GhCOBw6EXef/Vw7D12wZ58hURV0FFcJpfZu+WsEWUgDcsAsW3Z0+I8Bxal4LzApE82d beei4mE1s/oGwiRgKiVHJmgR4YZj2QX/6SJE1/FNVZsyg1Mq9S9FSfb/l63qc4Xw2V/4S+ Kequgo7uvkskHjh96Snolhnk9CA6E3PNsjBxnf569Awm9K1YBZWT831j+5OvMwAsPs47CP ft22foBAxwhdF0k0x9zK0d3dU/+bNmkx5ZvspYJY0Cgkf+QXMCN7UBXi3HJRpA== X-Migadu-Queue-Id: B85BD16B7E X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Spam-Score: -3.10 X-Spam-Score: -3.10 X-TUID: AgDi3Yvn1k5H Hi Maxim, On 2023-02-09 03:34, Maxim Cournoyer wrote: > Two remaining comments from me: > > 1. I'd normalize all the configuration field names to lowercase, so > max-BW and use-UTC? would become max-bw and use-utc?, for example. No, this is intentional so that uglify+case-conversion yields correct configuration directives. > 2. I'd add a simple example vnstat usage example to the manual. The service is "ready to be used" with the default values, so I didn't think it'd add much value adding an example here. Do you think we should add one? Cheers, Bruno