From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Lepiller Subject: Re: Renewing certificates with certbot Date: Wed, 06 Mar 2019 15:33:23 +0100 Message-ID: References: <87fts0i0ga.fsf@gnu.org> <2af1bc4240159d48ec7883b8c2fac590@lepiller.eu> <20190306141902.uja6n66hwjosqujt@uptimegirl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([209.51.188.92]:47305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Xbu-0006dx-K6 for guix-devel@gnu.org; Wed, 06 Mar 2019 09:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1Xbt-00066Y-Mb for guix-devel@gnu.org; Wed, 06 Mar 2019 09:33:30 -0500 Received: from lepiller.eu ([89.234.186.109]:47206) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h1Xbt-00064S-Bp for guix-devel@gnu.org; Wed, 06 Mar 2019 09:33:29 -0500 Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id a455fba8 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Wed, 6 Mar 2019 14:33:23 +0000 (UTC) In-Reply-To: <20190306141902.uja6n66hwjosqujt@uptimegirl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Le 2019-03-06 15:19, ng0@n0.is a écrit : > Julien Lepiller transcribed 1.6K bytes: >> Le 2019-03-06 14:42, Ludovic Courtès a écrit : >> > Hi, >> > >> > Julien Lepiller skribis: >> > >> > > I use certificates from let's encrypt for my website and mail servers, >> > > and found that there was an issue with certificates generated by the >> > > certbot service in Guix: the generated private keys are world-readable >> > > (in a directory that cannot be accessed by anyone but root, so it's OK >> > > I guess). OpenSMTPD is not happy with that though, so I have to chmod >> > > the files every time. I came up with a variant of the deploy-hook >> > > that's presented in the manual, and I'd like to update the example >> > > with it. Here it is: >> > > >> > > ;; Find running nginx and reload its configuration (for certificates) >> > > (define %my-deploy-hook >> > > (program-file >> > > "my-deploy-hook" >> > > #~(let* ((pid (call-with-input-file "/var/run/nginx/pid" read)) >> > > (cert-dir (getenv "RENEWED_LINEAGE")) >> > > (privkey (string-append cert-dir "/privkey.pem"))) >> > > ;; certbot private keys are world-readable by default, and >> > > smtpd complains >> > > ;; about that, refusing to start otherwise >> > > (chmod privkey #o600) >> > > (kill pid SIGHUP)))) >> > > >> > > What do you think? >> > >> > It sounds like a serious issue that private keys are world-readable. Is >> > it a bug on our side or in Certbot? I think we should fix it so that > > It's a certbot default, on all all systems. Actually, reading https://github.com/certbot/certbot/issues/1473 suggests it's not the case anymore. I was probably running an older version of certbot. > >> > they are never world-readable, rather than document how to work around >> > the bug. >> > >> > WDYT? >> > >> > Thanks, >> > Ludo’. >> >> I don't think this is an issue: the file is world-readable, but the >> directory >> it's in is not accessible to anyone but root. OpenSMTPD still >> complains, >> but I think there's no security issue. >> >>