all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: mrh57@posteo.net
To: 72452 <72452@debbugs.gnu.org>
Subject: [bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package
Date: Tue, 10 Sep 2024 12:13:40 +0000	[thread overview]
Message-ID: <cd04d2e36022a9e7ec931728b14dd08f@posteo.net> (raw)
In-Reply-To: <2c614792845a675a1296bcbeb6ef8d8502d51aba.1722717063.git.mrh57@posteo.net>



-------- Original Message --------
Subject: Re: [bug#72452] [PATCH] add guile-swayer package
Date: 2024-09-10 8:08 am
 From: mrh57@posteo.net
To: Nicolas Graves <ngraves@ngraves.fr>

On 2024-09-10 4:14 am, Nicolas Graves wrote:
> On 2024-09-09 16:21, mrh57@posteo.net wrote:
> 
>> Thanks again for the feedback.
>> 
>>> 1) (commit field should rather refer to version such as
>>>  (commit (string-append "v" version))
>> 
>> I made this change, but as =(commit version)= since there is no "v" in
>> the release titles.
> 
> The commit here will correspond to a git tag, not a github release. I
> think it should keep the "v" ;)

Ah yes makes sense, whoops!
Change made.

>> I think =guix lint= and =guix style= should now be happy :)
>> 
> 
> Have you tried rebuilding it since?

Yes it successfully builds with these changes under multiple rounds.




  parent reply	other threads:[~2024-09-10 12:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-03 20:31 [bug#72452] [PATCH] add guile-swayer package mrh
2024-09-07 16:15 ` Nicolas Graves via Guix-patches via
2024-09-07 18:17   ` mrh57
2024-09-07 18:28 ` [bug#72452] [PATCH v2] gnu: add guile-swayer mrh
2024-09-09  4:46 ` [bug#72452] [PATCH] add guile-swayer package Nicolas Graves via Guix-patches via
2024-09-09 16:21   ` mrh57
2024-09-10  8:14     ` Nicolas Graves via Guix-patches via
2024-09-09 16:24 ` [bug#72452] [PATCH v3] gnu: add guile-swayer Alec Barreto
2024-09-10 12:08 ` [bug#72452] [PATCH v4] " Alec Barreto
2024-09-10 12:13 ` mrh57 [this message]
2024-09-11 15:10   ` [bug#72452] Fwd: Re: [bug#72452] [PATCH] add guile-swayer package Nicolas Graves via Guix-patches via
2024-09-11 22:25     ` Alec Barreto
2024-09-10 17:23 ` [bug#72452] QA review for 72452 Nicolas Graves via Guix-patches via
2024-09-11 22:27 ` [bug#72452] [PATCH v5] gnu: Add guile-swayer Alec Barreto
2024-09-12 17:12   ` Ludovic Courtès
2024-09-13 12:03     ` Alec Barreto
2024-09-14 14:18       ` Alec Barreto
2024-09-14 15:52         ` Nicolas Graves via Guix-patches via
2024-09-14 18:23           ` Alec Barreto
2024-09-16 19:49             ` Nicolas Graves via Guix-patches via
2024-09-17  0:51               ` Alec Barreto
2024-09-17  0:54 ` [bug#72452] [PATCH v6] " Alec Barreto
2024-09-19 10:47   ` bug#72452: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd04d2e36022a9e7ec931728b14dd08f@posteo.net \
    --to=mrh57@posteo.net \
    --cc=72452@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.