From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EDEDG0v5ZWDzBgEAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 18:48:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oAvWFEv5ZWDPEgAAbx9fmQ (envelope-from ) for ; Thu, 01 Apr 2021 16:48:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EFD3D22AE7 for ; Thu, 1 Apr 2021 18:48:10 +0200 (CEST) Received: from localhost ([::1]:35522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lS0UL-0006pz-FT for larch@yhetil.org; Thu, 01 Apr 2021 12:48:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lS0UE-0006pq-45 for guix-patches@gnu.org; Thu, 01 Apr 2021 12:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46899) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lS0UD-0006DZ-Rn for guix-patches@gnu.org; Thu, 01 Apr 2021 12:48:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lS0UD-0005Mq-Pk for guix-patches@gnu.org; Thu, 01 Apr 2021 12:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47539] [PATCH 00/28] Add gh and dependencies Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47539 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 47539@debbugs.gnu.org Received: via spool by 47539-submit@debbugs.gnu.org id=B47539.161729562720546 (code B ref 47539); Thu, 01 Apr 2021 16:48:01 +0000 Received: (at 47539) by debbugs.gnu.org; 1 Apr 2021 16:47:07 +0000 Received: from localhost ([127.0.0.1]:58445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS0TL-0005LK-3H for submit@debbugs.gnu.org; Thu, 01 Apr 2021 12:47:07 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:65118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lS0TI-0005LA-R9 for 47539@debbugs.gnu.org; Thu, 01 Apr 2021 12:47:05 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FB8Gr6zPvz3yrT; Thu, 1 Apr 2021 18:47:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1617295621; bh=yILHdmyWrDrtZ09mIO1pxUpN5waCXzPKIjGXg97dGAA=; h=Subject:From:To:Date:In-Reply-To:References; b=GVNud+dfurv1+KGzLWTDe+KXbxHShkzWgodGAuOwlXvGHfdbkiU7uAtpapyDyY5Ct 1Gaq8CK11WBg2PYoU2MdRR89T3a7irlD1fIpYm3cezEBKrhBd2lu9G3+acYvaH/5oA GlyU1xpeVFFkczSi/58eiUbzy08TNOCOXMxJj/bo= Message-ID: From: Leo Prikler Date: Thu, 01 Apr 2021 18:47:00 +0200 In-Reply-To: <877dlm3rak.fsf@yoctocell.xyz> References: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> <87czve3vrg.fsf@yoctocell.xyz> <877dlm3rak.fsf@yoctocell.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617295691; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yILHdmyWrDrtZ09mIO1pxUpN5waCXzPKIjGXg97dGAA=; b=g0HS89+EBtFKY7O3jrcPk3Ubn6EEF1gN+Qql/Okcki+tT9HYEjf+czhO2vSyzMz0jR2p8+ S3zvNY0IneNtAsMitP4sm7srQSwoQ2wYdiQhQs3nxOuYVMbaKQV7Gm5VlGEsMtYtzEffJP ViOWHcOeCAd/2LEZawBvaSIIoD4/GF9fah6D1mgmiWYKDMc7nAOtAFVGrAIdZeIflngwEm 4f9Pcl/EmQVHfNmXvZcRhlksgHsWADAWWE2tLWga2/D9Afv/MyLz3WN9qTKb5dUnuowJwR DPL7BCBdOQMyo335/NgCH3O5yQ6tlOnogmTqet33CxEzwaV3/evxdWTe+pOCZA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617295691; a=rsa-sha256; cv=none; b=H6WrBoXttZ46a0+pdNISqbRTE3GDYjCG+ytY5qVRMjXkGxmujO+1b+rnWLpTOEZv9rluO3 CRmLZ/eSlBuLPEzYNJGkRNtYIev2xr8TI4/amKmnoEabKGPnSyz5U365F966sFjysC88FQ n1WBcBJ1b0mQKGho97V1KjIYEbG2C1i9Er8C5C6Gszo555AOTjVPw3YAl9kFZLIUxFom8w Jn5EOetV01bN+T56BLaM4MwiBN+gNZNJzEI4dH+X7iIL9hg1qZ4nGPAUKY/LVT+xRU291L Y9zGzkPaGFDC29QkFwEahO8J6Fd3EFnDQvI1y4d0t9xMizEhqNRLReU3RrLkog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=GVNud+df; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=GVNud+df; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EFD3D22AE7 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: rCpkUKZHbmDg Am Donnerstag, den 01.04.2021, 18:25 +0200 schrieb Xinglu Chen: > On Thu, Apr 01 2021, Xinglu Chen wrote: > > > > > - When building'gh', I couldn't get > > > > 'go-github-com-charmbracelet-glamour' to build without moving > > > > some > > > > native-inputs to propagated-inputs, though, if I was only > > > > building > > > > 'go-github-com-charmbracelet-glamour' it would build without > > > > moving > > > > things to propagated-inputs. I am not sure why this happens. > > > Perhaps you need to add those native inputs as native inputs to > > > gh as > > > well? Try adding its native inputs to gh and see whether that > > > changes > > > something. > > > > I will try and report back. > > Adding the packages as native-inputs for github-cli fixed the > problem. > Thank you! You're welcome. > > > > - The patch marked with 'W' adds a package which is needed by > > > > 'gh', > > > > but only used on Windows. It is still Free Software (BSD-2), > > > > but I > > > > have also marked it as hidden. > > > This is at least in some sense an acceptable workaround, but how > > > large > > > would the effort be to outright drop references to this package, > > > given > > > that it's already not "actively" being used? > > > > I am not familiar with the Go ecosystem so I don't know if this > > will be > > possible, but I will look into it. > > Compiling github-cli without the package doesn't work, and the > package > is used in multiple places in the source code. I don't really know > what > we can do here. Should I open an issue on their GitHub page, or just > leave it as is? For now, I don't think this is going to be a blocking issue, as long as the package and the input are appropriately marked, e.g. with comments, and we make sure not to endorse the Microsoft OS through them. As to how we might handle this, we could do our own investigations into dropping the dependency, but asking a question (make sure to tag it as such) should work as well. Also be clear, that the goal is not necessarily to remove the dependency altogether, but rather make it an optional one. After doing some quick investigations myself, I think the following pair of substitute*s might work: (("github.com/cli/safeexec") "os/exec") (("safeexec") "exec") Regards, Leo