From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yOZXK8tXpF/9cAAA0tVLHw (envelope-from ) for ; Thu, 05 Nov 2020 19:51:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uGMrJ8tXpF+4dwAA1q6Kng (envelope-from ) for ; Thu, 05 Nov 2020 19:51:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F7AD94011C for ; Thu, 5 Nov 2020 19:51:39 +0000 (UTC) Received: from localhost ([::1]:42820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kalIH-0001Ji-Qh for larch@yhetil.org; Thu, 05 Nov 2020 14:51:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kalHi-0001Gf-GF for guix-patches@gnu.org; Thu, 05 Nov 2020 14:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kalHh-0002o8-NM for guix-patches@gnu.org; Thu, 05 Nov 2020 14:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kalHh-0004Yp-L1 for guix-patches@gnu.org; Thu, 05 Nov 2020 14:51:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44470] [PATCH] gnu: Added emacs-solidity. Resent-From: Martin Becze Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Nov 2020 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44470 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 44470@debbugs.gnu.org Received: via spool by 44470-submit@debbugs.gnu.org id=B44470.160460584117504 (code B ref 44470); Thu, 05 Nov 2020 19:51:01 +0000 Received: (at 44470) by debbugs.gnu.org; 5 Nov 2020 19:50:41 +0000 Received: from localhost ([127.0.0.1]:54179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kalHN-0004YG-Ds for submit@debbugs.gnu.org; Thu, 05 Nov 2020 14:50:41 -0500 Received: from mx1.riseup.net ([198.252.153.129]:57032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kalHL-0004Y8-D8 for 44470@debbugs.gnu.org; Thu, 05 Nov 2020 14:50:39 -0500 Received: from bell.riseup.net (bell-pn.riseup.net [10.0.1.178]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4CRvJZ58BdzDqSv; Thu, 5 Nov 2020 11:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1604605838; bh=NwvdZGDxGs8wN14XUt8NxaIqMWFScbE3ze2dAcHj7gc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=du0We/d0G9YBkfCrRezqdiay6N40tPmjRGOYFDe0ddYXWmzQf5xJmHY47IYOylztX 08xg4zVr64Vv+IJ3N+hF5p8Xvla2l7qgIn1QSh9gSEsY2VfM1ztuiuVVjUMRsFd/sa uQPdyfHI4+fBiNNKNjRjV4Apt9v4Cmz5TvXFe1ps= X-Riseup-User-ID: 627BDF0F3970F0553ACAC1E2AAAA8ADBAE10EC1E0F1A4F60EC69F08D9229E298 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bell.riseup.net (Postfix) with ESMTPSA id 4CRvJY2x6JzJpbM; Thu, 5 Nov 2020 11:50:34 -0800 (PST) References: <20201105152052.6017-1-mjbecze@riseup.net> <87zh3vlokf.fsf@nicolasgoaziou.fr> From: Martin Becze Message-ID: Date: Thu, 5 Nov 2020 13:50:30 -0600 MIME-Version: 1.0 In-Reply-To: <87zh3vlokf.fsf@nicolasgoaziou.fr> Content-Type: multipart/mixed; boundary="------------0ABB2FC16AC2BCBEAF93D59F" Content-Language: en-US X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=riseup.net header.s=squak header.b=du0We/d0; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: NaAGKz4c2fPG This is a multi-part message in MIME format. --------------0ABB2FC16AC2BCBEAF93D59F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thank you for the review Nocolas. I choose the latest commit because it fixes some spacing issues and has support for more keywords. While not absolutely necessary the release cycle seems to be very slow and this is the version that is on Melpa. Attachedd is an updated patch. On 11/5/20 11:07 AM, Nicolas Goaziou wrote: > Hello, > > Martin Becze writes: > >> * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable. > > Thank you. > >> + ;; No release. >> + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e")) > > Is there any reason to use this particular instead of > e91c36cc20a2e683b930712a7f9c0ab28451b347, which is the exact "0.1.10" > release? If so, please mention it in the comment above. > >> + (package >> + (name "emacs-solidity") >> + (version (git-version "0.1.10" "1" commit)) > > If we use the commit above, `version' can simply become "0.1.10". > >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/ethereum/emacs-solidity") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq")))) >> + (build-system emacs-build-system) >> + (propagated-inputs >> + `(("emacs-company" ,emacs-company) >> + ("emacs-flycheck" ,emacs-flycheck))) >> + (home-page "https://github.com/ethereum/emacs-solidity") >> + (synopsis "Major mode for writing Solidity code") >> + (description "A simple language mode for the Solidity language. It is a >> +constant work in progress as the language itself also progresses.") > > The first sentence should be "complete", i.e., with a subject and > a verb. > > Could you send an updated patch? > > Regards, > --------------0ABB2FC16AC2BCBEAF93D59F Content-Type: text/x-patch; charset=UTF-8; name="v1-0001-gnu-Added-emacs-solidity.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="v1-0001-gnu-Added-emacs-solidity.patch" >From 1216fc95cc9b480375e8dc344510f1a24f7b2c84 Mon Sep 17 00:00:00 2001 From: Martin Becze Date: Thu, 5 Nov 2020 09:18:01 -0600 Subject: [PATCH v1] gnu: Added emacs-solidity. * gnu/packages/emacs-xyz.scm (emacs-solidity): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 2043ce19df..78cf2e31c3 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -25281,3 +25281,28 @@ the TypeScript implementation.") (description "This package provides an Emacs client for the Rocket.chat service.") (license license:expat)))) + +(define-public emacs-solidity + ;; This commit fixes a spacing issue and adds new keywords + (let ((commit "d166a86b83907e0cfd64c191e9dfce4b44a9843e")) + (package + (name "emacs-solidity") + (version (git-version "0.1.10" "1" commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ethereum/emacs-solidity") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "19hgvsrqch2vp49ag6m76bi5qxd20v95z0ib838rib9as15b17wq")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-company" ,emacs-company) + ("emacs-flycheck" ,emacs-flycheck))) + (home-page "https://github.com/ethereum/emacs-solidity") + (synopsis "Major mode for writing Solidity code") + (description "This is a simple language mode for the Solidity language. +It is a constant work in progress as the language itself also progresses.") + (license license:gpl3+)))) -- 2.29.2 --------------0ABB2FC16AC2BCBEAF93D59F--