From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czi1L-0001zv-Fc for guix-patches@gnu.org; Sun, 16 Apr 2017 07:07:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czi1G-0004JE-DX for guix-patches@gnu.org; Sun, 16 Apr 2017 07:07:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51625) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czi1G-0004Iu-29 for guix-patches@gnu.org; Sun, 16 Apr 2017 07:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1czi1F-00082Q-Pf for guix-patches@gnu.org; Sun, 16 Apr 2017 07:07:01 -0400 Subject: bug#26454: [PATCH 2/2] gnu: add emacs-exwm Resent-Message-ID: Message-Id: MIME-Version: 1.0 From: Arun Isaac Date: Sun, 16 Apr 2017 16:36:23 +0530 In-reply-to: <87a87gr93p.fsf@gnu.org> References: <20170411225803.2420-1-tumashu@163.com> <20170411225803.2420-2-tumashu@163.com> <87inm9sdcs.fsf@gmail.com> <60b3e50e.AEEAJadpHi4AAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY7oh5@mailjet.com> <67fed3f6.1a3b.15b64e00dfd.Coremail.tumashu@163.com> <87mvbj6w72.fsf@163.com> <4d35676d.AEUAI-hEBJAAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8M5G@mailjet.com> <87a87gr93p.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26454@debbugs.gnu.org >>>> In your new patch, could you add a phase for generating this code from >>>> the xcb-proto xml files as well? Thanks! >> >>> I don't think it it a good idea, xcb-xproto.el provided by repo is >>> tested by developer. if we regenerate it, i don't know whether it >>> work or not. > > That would effectively mean we don’t have the source code for this, > which would be a problem. > > What about generating it, and if we do find differences compared to the > pre-compiled xcb-proto.el, then we can keep it in mind and report any > issues upstream? In the latest version of the patch, we are regenerating the sources from xcb-proto. So, this issue has been addressed.