From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5AJ5-0007cS-V2 for guix-patches@gnu.org; Sat, 16 Mar 2019 10:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5AJ4-0005Yz-Uk for guix-patches@gnu.org; Sat, 16 Mar 2019 10:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h5AJ4-0005YO-75 for guix-patches@gnu.org; Sat, 16 Mar 2019 10:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h5AJ3-0001cF-Ms for guix-patches@gnu.org; Sat, 16 Mar 2019 10:29:01 -0400 Subject: [bug#34795] LXQT update to version 0.14.1 Resent-Message-ID: Mime-Version: 1.0 Message-Id: In-Reply-To: <20190315171929.GD32161@jasmine.lan> References: <20190315171929.GD32161@jasmine.lan> Date: Sat, 16 Mar 2019 04:14:34 -0400 From: "Reza Alizadeh Majd" Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 34795@debbugs.gnu.org Thanks for your response, OK, sure, first I need to change our internal commit message formats to gnu style. later I will submit our LXQt patches again. On Fri, Mar 15, 2019, at 8:49 PM, Leo Famulari wrote: > On Sat, Mar 09, 2019 at 06:29:23PM +0330, Reza Alizadeh Majd wrote: > > diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm > > index a5720ce97..f6bfcfa64 100644 > > --- a/gnu/packages/lxde.scm > > +++ b/gnu/packages/lxde.scm > > @@ -190,7 +190,7 @@ performance, all instances of the terminal are sharing a single process.") > > (define-public menu-cache > > (package > > (name "menu-cache") > > - (version "1.0.2") > > + (version "1.1.0") > > Thank you for this patch! > > I request two changes: > > First, can you split up the patch into several patches? In general, each > package should be updated in its own patch, unless this will cause the > other packages to break. > > Second, can you write a complete commit message? For the first package > update, for example, you'd write it this way: > > ------ > gnu: menu-cache: Update to 1.1.0. > > * gnu/packages/lxde.scm (menu-cache): Update to 1.1.0. > ------ > > If there are other changes, they should be described as well. > > I recommend looking at our Git history for examples, or asking here on > or IRC if you need help. Can you send an updated patch series? > > By the way, this style of commit logs is called the 'GNU Change Log' > style and is documented here: > > https://www.gnu.org/prep/standards/html_node/Change-Logs.html > > But looking at `git log` is probably the clearest way to learn it. > > Attachments: > * signature.asc