From: Roel Janssen <roel@gnu.org>
To: Leo Famulari <leo@famulari.name>,
Efraim Flashner <efraim@flashner.co.il>
Cc: 47822-done@debbugs.gnu.org
Subject: bug#47822: [PATCH] gnu: Add r-naturalsort.
Date: Tue, 04 May 2021 21:36:49 +0200 [thread overview]
Message-ID: <cb9cb30a9fb0c14da29218f7acf0688f863187da.camel@gnu.org> (raw)
In-Reply-To: <YJF29GvSab5i4ViV@jasmine.lan>
On Tue, 2021-05-04 at 12:31 -0400, Leo Famulari wrote:
> On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> > Here's a patch for r-naturalsort.
> >
> > Also: is it OK to push patches like this ("another" fairly trivial
> > R
> > package) directly?
>
> Yes. Quoting the manual section Commit Access:
>
> ------
> For patches that just add a new package, and a simple one, it’s OK to
> commit, if you’re confident (which means you successfully built it in
> a
> chroot setup, and have done a reasonable copyright and license
> auditing). Likewise for package upgrades, except upgrades that
> trigger a
> lot of rebuilds (for example, upgrading GnuTLS or GLib).
> ------
>
> If you aren't feeling confident, just let us know what you'd like
> someone else to check for you. Otherwise, feel free to push.
>
Thanks Efraim and Leo. I pushed this patch in
aa7eeabe9a782afc2535581298990050d16b1895.
I will push trivial patches like these directly from now on. Please do
let me know if I pushed something that would've benefitted from review.
Kind regards,
Roel Janssen
prev parent reply other threads:[~2021-05-04 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 10:57 [bug#47822] [PATCH] gnu: Add r-naturalsort Roel Janssen
2021-05-04 15:52 ` Efraim Flashner
2021-05-04 16:31 ` Leo Famulari
2021-05-04 19:36 ` Roel Janssen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb9cb30a9fb0c14da29218f7acf0688f863187da.camel@gnu.org \
--to=roel@gnu.org \
--cc=47822-done@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.