From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggWyb-0000vr-NR for guix-patches@gnu.org; Mon, 07 Jan 2019 10:38:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggWyZ-0000Zd-51 for guix-patches@gnu.org; Mon, 07 Jan 2019 10:38:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49587) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggWyX-0000V9-T8 for guix-patches@gnu.org; Mon, 07 Jan 2019 10:38:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ggWyX-0005Hu-PB for guix-patches@gnu.org; Mon, 07 Jan 2019 10:38:01 -0500 Subject: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename Resent-Message-ID: References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> From: Tim Gesthuizen Message-ID: Date: Mon, 7 Jan 2019 16:37:17 +0100 MIME-Version: 1.0 In-Reply-To: <878szwinp0.fsf@ambrevar.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 33598@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV Content-Type: multipart/mixed; boundary="bBeAsaqqwKCUODe2IoR55PgFp6vNxY8iq"; protected-headers="v1" From: Tim Gesthuizen To: Pierre Neidhardt Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , 33598@debbugs.gnu.org Message-ID: Subject: Re: [bug#33598] Optimizations for emacs-clang-format and emacs-clang-rename References: <871s6l9h54.fsf@gnu.org> <87r2ekea1u.fsf@ambrevar.xyz> <04daca2a-705d-6255-85bd-48132879f5a8@yahoo.de> <87lg4se6wf.fsf@ambrevar.xyz> <8d15b1a4-5f0b-28aa-a3d9-78520431b8ef@yahoo.de> <87imzwe2d3.fsf@ambrevar.xyz> <2df7cbf3-81d5-7d50-35d7-f3b369d1ac0e@yahoo.de> <87ftuth0d7.fsf@ambrevar.xyz> <14de0933-fddc-94d0-d75a-cdf4b49fce1a@yahoo.de> <87wonhipbw.fsf@ambrevar.xyz> <792d34a0-b048-b84f-b7b8-d9d996da2a28@yahoo.de> <878szwinp0.fsf@ambrevar.xyz> In-Reply-To: <878szwinp0.fsf@ambrevar.xyz> --bBeAsaqqwKCUODe2IoR55PgFp6vNxY8iq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07.01.19 14:47, Pierre Neidhardt wrote: > Merged! >=20 >> : > +;;; Returns a package definition that packages an emacs-lisp file= from the >> :=20 >> : "Return", not "Returns". >=20 > You forgot this! Anyways, I was confused by the docstring, so I took t= he > liberty to simplify it a little bit to the following: Whoops... Maybe I did not reformat the patches. > "Return a package definition named PACKAGE-NAME that packages the Ema= cs Lisp > SOURCE-FILES found in SOURCE-PACKAGE." >=20 > If you think this is missing something, let me know and I'll fix it. Much better. That was probably just to straight forward for me. > Oops, got too fast: there is a circular dependency problem because emac= s.scm > depends on llvm.scm. > The function must be moved to some other place. I'll place it in emacs= utils or > something. So that is my "weird issue"! I first packaged the function in emacs-utils.scm and experienced much worse things. I suspected it to be a circular dependency as any package using emacs-build-system includes emacs-utils under the hood and moved it to packages/emacs.scm. I thought it was something different because the same error appeared there too. Maybe we should have a file with "shortcuts" for package definitions of special kind and place the function there? I would claim that we would have the same problems in emacs-utils.scm. Tim. --bBeAsaqqwKCUODe2IoR55PgFp6vNxY8iq-- --Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKUiC5+8BRKEri5fa0uWPaa77GdUFAlwzcjMACgkQ0uWPaa77 GdWWJAf/W3fluWSXYSE9FKxIh2u93X8UXRc8q00RJk892I2qOUFR/GkTpkFp5pSG xO5FGtG/Lcv1UBkJVsMNOFsquZRW6qVtx5lrN1/U3jg1ravkvp3/ecNOB4hmJ3oM xGQFXbPgF/YVhWsnT576sOrT939I+CfN8lzYuqUMExgJwJRXwK+LMAxf4FnfJOTl CzMpHpCDvW9ViuXWDGLUbnXT9HevBLJJ8tnshJ4T/af436lehFSRYtfLVRaV08eP 3K8TH6rNMdqrwhnso+FA+W1pR9EGx80SrikeyFwrFvj1J6mHto0LqOZ2t1zurliq 1K3DxpyMcPVGRad9fWg6Wy8SLF3S/A== =JZKT -----END PGP SIGNATURE----- --Ssc45n3QdnHBEpolOWwWFLU6U4lzgw4lV--