all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Morgan Smith <morgan.j.smith@outlook.com>
Cc: Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	70632@debbugs.gnu.org, Andrew Tropin <andrew@trop.in>
Subject: [bug#70632] [PATCH 1/2] aux-files: comp-integrity: Adjust for newer emacs.
Date: Mon, 29 Apr 2024 23:38:22 +0200	[thread overview]
Message-ID: <cb1611ac9414e4d0b0366d8f31bd41a3f300931a.camel@gmail.com> (raw)
In-Reply-To: <CH3PR84MB3424CB88BCC92AECD7E838B3C51B2@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM>

Am Montag, dem 29.04.2024 um 16:43 -0400 schrieb Morgan Smith:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > Hi,
> > 
> > the change itself LGTM, but I think it should be accompanied by a
> > change to Emacs 30 and also we should really try to version it
> > because it rebuilds Emacs as a whole.  The emacs-team branch hasn't
> > been used for a while and I think there's nothing big there; and
> > neither is there a need to exercise it if we just add another file
> > and replace the phase.
> > 
> > Cheers
> 
> I think some people might want to build newer Emacs's before the 30
> release.  Like how people wanted the pgtk and tree-sitter features
> early.  People might want to try the new GC that's being developed.
That's fair and we aim to support that case.

> I'm not a fan of adding another file so I came up with this solution.
> See attached patch.
Hmm, I'm a bit torn on the solution.  On one hand, it is a local
solution with just a phase, on the other having the file makes it
easier to just mv it.

> If we believe that a core-updates merge will occur before Emacs 30
> then I would like to see my original patch applied there.
It'd be only emacs-team, not core-updates, but we could do this
"quickly" either way.  But the point behind those is to keep them small
and manageable in a sense, so core-updates is typically not concerned
with leaves or leaf-like stuff.

Cheers




  reply	other threads:[~2024-04-29 21:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28 17:07 [bug#70632] [PATCH 1/2] aux-files: comp-integrity: Adjust for newer emacs Morgan Smith
2024-04-28 17:40 ` [bug#70632] [PATCH v2] " Morgan Smith
2024-04-29 18:44 ` [bug#70632] [PATCH 1/2] " Liliana Marie Prikler
2024-04-29 20:43   ` Morgan Smith
2024-04-29 21:38     ` Liliana Marie Prikler [this message]
2024-05-01 16:32       ` Morgan Smith
2024-05-01 16:46         ` Liliana Marie Prikler
2024-05-01 20:06           ` Morgan Smith
2024-05-02  4:24             ` Liliana Marie Prikler
2024-05-08 18:48               ` Morgan Smith
2024-07-07  6:36                 ` bug#70632: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb1611ac9414e4d0b0366d8f31bd41a3f300931a.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=70632@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=morgan.j.smith@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.