From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] Add junit.
Date: Fri, 22 Apr 2016 09:59:27 -0500
Message-ID: <caec98e990a0afabc93df3a04411dc15@openmailbox.org>
References: <idjlh4591ae.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58875)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1atcYR-0003AS-C2
	for guix-devel@gnu.org; Fri, 22 Apr 2016 10:59:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1atcYQ-0005yE-JO
	for guix-devel@gnu.org; Fri, 22 Apr 2016 10:59:35 -0400
In-Reply-To: <idjlh4591ae.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org, Guix-devel <guix-devel-bounces+ericbavier=openmailbox.org@gnu.org>

On 2016-04-22 09:16, Ricardo Wurmus wrote:
> Hi Guix,
>=20
> here=E2=80=99s a first batch of patches for Java libraries.  Many Java =
packages
> depend on JUnit, so that=E2=80=99s where I started.  =E2=80=9Chamcrest-=
core=E2=80=9D is just a
> small part of the whole hamcrest library, but it=E2=80=99s enough to bu=
ild
> JUnit.
[...]
> +         (add-before 'configure 'patch-build.xml
> +           (lambda _
> +             (substitute* "build.xml"
> +               (("unit-test, ") "")
> +               (("\\$\\{build.timestamp\\}") "guix"))

Is using "guix" here as a timestamp safe?  Will nothing read the=20
manifest and expect an actualy timestamp?  (I've become unfamiliar with=20
most of java-land lately).

> +         ;; Java's "getMethods()" returns methods in an unpredictable=20
> order.
> +         ;; To make the output of the generated code deterministic we=20
> must
> +         ;; sort the array of methods.
> +         (add-after 'unpack 'make-method-order-deterministic

Should we patch our java package instead?  Perhaps that can be saved as=20
a future exercise.

> +              (snippet
> +               '(begin
> +                  ;; Delete bundled jar archives.
> +                  (delete-file-recursively "lib")
> +                  #t))))

Is this very common in java packages?

Otherwise LGTM.

--=20
`~Eric