From: Eric Bavier <ericbavier@openmailbox.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org,
Guix-devel
<guix-devel-bounces+ericbavier=openmailbox.org@gnu.org>
Subject: Re: [PATCH] Add junit.
Date: Fri, 22 Apr 2016 09:59:27 -0500 [thread overview]
Message-ID: <caec98e990a0afabc93df3a04411dc15@openmailbox.org> (raw)
In-Reply-To: <idjlh4591ae.fsf@bimsb-sys02.mdc-berlin.net>
On 2016-04-22 09:16, Ricardo Wurmus wrote:
> Hi Guix,
>
> here’s a first batch of patches for Java libraries. Many Java packages
> depend on JUnit, so that’s where I started. “hamcrest-core” is just a
> small part of the whole hamcrest library, but it’s enough to build
> JUnit.
[...]
> + (add-before 'configure 'patch-build.xml
> + (lambda _
> + (substitute* "build.xml"
> + (("unit-test, ") "")
> + (("\\$\\{build.timestamp\\}") "guix"))
Is using "guix" here as a timestamp safe? Will nothing read the
manifest and expect an actualy timestamp? (I've become unfamiliar with
most of java-land lately).
> + ;; Java's "getMethods()" returns methods in an unpredictable
> order.
> + ;; To make the output of the generated code deterministic we
> must
> + ;; sort the array of methods.
> + (add-after 'unpack 'make-method-order-deterministic
Should we patch our java package instead? Perhaps that can be saved as
a future exercise.
> + (snippet
> + '(begin
> + ;; Delete bundled jar archives.
> + (delete-file-recursively "lib")
> + #t))))
Is this very common in java packages?
Otherwise LGTM.
--
`~Eric
next prev parent reply other threads:[~2016-04-22 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 14:16 [PATCH] Add junit Ricardo Wurmus
2016-04-22 14:59 ` Eric Bavier [this message]
2016-04-22 21:03 ` Ricardo Wurmus
2016-04-29 15:16 ` HTTP server invalid date header Ludovic Courtès
2016-04-29 20:15 ` Ricardo Wurmus
2016-05-01 13:07 ` Ludovic Courtès
2016-05-02 15:27 ` Ricardo Wurmus
2016-05-08 20:10 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caec98e990a0afabc93df3a04411dc15@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=guix-devel-bounces+ericbavier=openmailbox.org@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.