From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KO4uC49EcWYJIQEAqHPOHw:P1 (envelope-from ) for ; Tue, 18 Jun 2024 08:25:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id KO4uC49EcWYJIQEAqHPOHw (envelope-from ) for ; Tue, 18 Jun 2024 10:25:51 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ayOzNwX8; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718699151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=ryqs09dQ8Nq8YtjM+iel6U7QAVLFqysB6urSfhUqgw4=; b=I+lyCPmENVraNXl6M4mAdD4UbdRcSFmIdCcj4yC0/g+Ok7qH6XBowL3igOvciPd+A+nV2M Cvvmgp9ZxX8Zk1dgMw4WmLcmF7BokY2OympL37Y4afOMXSKbj084G+RLYlpFq8szNVvpsY CaOfRTOBYx5sp86vW+1vmk0kx70lUhAhMjTcoG75kiFOQRgDDi8SAYzElGwgxLjzPzqK2V N+YFVB8NhQdj1b0JBQqvscCvFeD9Vf/t9y7x4hDLZyUVV2EBkkqZnowQ1aoPZE/DaMneM9 Reis0CH+k+3slk5Uw+GsPDTOz3Zf+HCADHGYjzkh/IlC//zalHaFsvkNfizDqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ayOzNwX8; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718699151; a=rsa-sha256; cv=none; b=hWx18UPsNAkicECFI/VrVtSJzOYc5Ycu6p4nFxxnDl5bDcFZaB8drb9xOZJlBWLhYlkgKo /zQF1vnHySTA6rmzbhMmzP3yjuQWtT3SHil0uU/6GMtMC9QoCybtDdskjqucJzQuG8He7A jP+RbguSoMzhyEMmyAEY6Iny9PMPFGU2wuplFcd3zUWx0YC+JWekdS1xvW8eBuJDFT5wwV 65C6TXbMQhfdv9PDHm68zFj1/qT1zn0y4RRUNY47GCsprl6xCJ2mv06YUb2pox0ifVo2Z5 /MjrdtVmg8VhN35fxZhBPTCeuMVxCHu7UTRwq7iwDiKFvuzoLcNRdtVjqbCe1A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D353167BA for ; Tue, 18 Jun 2024 10:25:51 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJU9g-0006ff-6q; Tue, 18 Jun 2024 04:25:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJU9e-0006f4-VS for guix-devel@gnu.org; Tue, 18 Jun 2024 04:25:27 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJU9d-0000pB-8c; Tue, 18 Jun 2024 04:25:26 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-7042a8ad9f5so4036819b3a.0; Tue, 18 Jun 2024 01:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718699122; x=1719303922; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ryqs09dQ8Nq8YtjM+iel6U7QAVLFqysB6urSfhUqgw4=; b=ayOzNwX8+V7eWtpbV2hk73RnMNPpYz8EAtP8wVgPoWnf9NZO8U7kDcXD0jGVKHvhm1 /Itc+aCmpMbU80jPHc0IVbnmPZXKSA73JE8O0t3qMnrv2Ev442zuHf0yrFYpU+97IoDp Aozj3wXAfFzQIRCGv+mRzqxf2Z4Ek+cvm7h+RZZDxwESWY2SZYUSLPhRIzDoJRkqv4ay 4DkuQRaHr0jcmOKR0jfUARtI7lKHiXqgJNgm7QusRMYVmxBkaikJzyLADGMQijv7mTtP 8UqSSnA1QXGdmz6axj6v8FtYwHbs2UDA+f3qGaedPzoevpf0MY28JBRXlmomSmJUnnK/ TTvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718699122; x=1719303922; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ryqs09dQ8Nq8YtjM+iel6U7QAVLFqysB6urSfhUqgw4=; b=nuHKEBQXZphPstBKMKENX9GBvJknRZ/klfRZm495yF0rwROYHVCtMTVXLSIrPEm5UD HIiWTsMjV/cQJmj+Z37/YsCxAZr4IQX4QqBpsy1T7DlS9GCAPtHxFTh0YLuzLmCKvWlz CexQ0wly8O05umn2aMcEf64y73ESpbNZ/53d2uOE5EDSMQvTY4uKxaCSuaCZCqhIDJ/u hLGEQ7kNJO++rACwlUVcGruREh7ON6jYHNT5dTmdqm8aijEIjWDXWYOMeGHFMfEQ4ZxT Uyvwg4N4k7kpW3m787vAJDDgcmBEtwPPehZTGIYUnBKGZSrudNSjBzI5AQpVCya5WoaH vgqg== X-Gm-Message-State: AOJu0Yy45H6rdAADin5ai/vXkYtCzVLEQ5OMu9+OKk34lE5USJG9Jmor Nef9XuePLbOaoEhFb5DD9yLyaEaKgSogT5Oj8vIZrVP+inWUuEj52H/wUg== X-Google-Smtp-Source: AGHT+IGKUxcqDTO4Q7eKp5248lEFwGm/FWm3L4aSU/Kc0DRD+8dWkNdnAeGR+PKvnv/6dnAUYv9oew== X-Received: by 2002:a17:90a:2f21:b0:2c2:cc03:a4ad with SMTP id 98e67ed59e1d1-2c6cb1b4db6mr2693038a91.21.1718699122532; Tue, 18 Jun 2024 01:25:22 -0700 (PDT) Received: from [10.143.113.222] ([130.95.40.104]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c4f01a82c9sm7425100a91.31.2024.06.18.01.25.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Jun 2024 01:25:22 -0700 (PDT) Message-ID: Date: Tue, 18 Jun 2024 08:25:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: Disabling authentication checks for tests in local Guix checkouts Content-Language: en-US To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Cc: Guix Devel References: <87zfrj7m8a.fsf@gnu.org> From: Ada Stevenson In-Reply-To: <87zfrj7m8a.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=adanskana@gmail.com; helo=mail-pf1-x432.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-1.388, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 0D353167BA X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.70 X-Spam-Score: -9.70 X-TUID: gzinNJqRT929 Hi Ludo' On 17/06/2024 1:05 pm, Ludovic Courtès wrote: > Hi Ada, > > Ada Stevenson skribis: > >> I'm currently trying to help test the changes to GRUB submitted in >> issue #71348[1]. Unfortunately, `make check`, whilst building the >> local Guix channel, authenticates every commit. That means commits not >> signed by people in `guix-authorizations` will stop the channel from >> building and prevents running any of the tests. > > Bummer. :-( > >> I have tried to fix the issue by writing a patch: > > This patch looks like the right thing to do. > > I’m not sure how to integrate it though: in the general case, we > probably want to keep authentication enabled by default, but how to > allow users to easily disable it when using a personal checkout? > >> Initially this seems like it works, as it starts to index all of the >> commits in the local checkout, which didn't occur beforehand, instead >> immediately giving a `Git error: cannot locate remote-tracking branch >> 'origin/keyring'` (I've run `git fetch -a`, and my Savannah remote is >> called `origin`). > > Guix caches clones under ~/.cache/guix/checkout. It may be that there’s > a clone of your local repo there, but that the clone itself lack a copy > of the ‘keyring’ branch? (You can run ‘git fetch -a’ in there.) I tried invoking the tests from within a `./pre-inst-env guix repl` and managed to get both of the tests to run using my patch! They both passed too. I think you're right, there must have been some sort of caching error. Anyway, I'm new to contributing using Debbugs. Is there a way to tag an issue as 'reviewed' or something like that? Or do I just send an email saying I tested the patch and everything looks good? Let me know :-) > > Thanks for testing! You're welcome! Thanks for writing the patch. > > Ludo’. Warmly, Ada