all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Evan Straw <evan.straw99@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Christopher Howard <christopher@librehacker.com>,
	Brett Gilio <brettg@gnu.org>,
	38865-done@debbugs.gnu.org
Subject: [bug#38865] [PATCH]  add package definition for liquid-dsp-1.3.2
Date: Wed, 15 Jan 2020 22:46:28 +0000 (UTC)	[thread overview]
Message-ID: <ca311c53-d0db-4570-bb25-3d7b57161dcb@localhost> (raw)
In-Reply-To: <87imlcph38.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]


Hi,
I think the only problem that this will introduce is that my redsea package definition in my third patch depends on the definition for liquid-dsp being in the same file, so an import will have to be added. I can submit a revision for this in a few hours when I get back on my PC, if needed.

--Evan

Jan 15, 2020 1:04:00 PM Ludovic Courtès <ludo@gnu.org>:

> Hello,
> 
> Christopher Howard <christopher@librehacker.com> skribis:
> 
> 
> > From 0064c61e7884c6f7d6356dfa22b04279bc460b2a Mon Sep 17 00:00:00 2001
> > From: Christopher Howard <christopher@librehacker.com>
> > Date: Fri, 10 Jan 2020 21:19:24 -0900
> > Subject: [PATCH] gnu: Add liquid-dsp.
> > 
> > * gnu/packages/sdr.scm (liquid-dsp): New variable
> > 
> 
> Thanks, I’ve added the file to ‘gnu/local.mk’ and committed.
> 
> Evan, I hope that’s fine with you! The changes I noticed between both
> patches are: Evan’s did not include a dependency on FFTW, and
> Christopher’s lives in sdr.scm while Evan’s in ham-radio.scm.
> 
> Evan, let us know if it’s fine for the rest of your patches!
> 
> Thanks everyone,
> Ludo’.
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 854 bytes --]

  reply	other threads:[~2020-01-15 22:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  5:05 [bug#38865] [PATCH] add package definition for liquid-dsp-1.3.2 Christopher Howard
2020-01-09 22:21 ` Ludovic Courtès
2020-01-11  1:57   ` Brett Gilio
2020-01-11  6:42     ` Christopher Howard
2020-01-15 21:03       ` bug#38865: " Ludovic Courtès
2020-01-15 22:46         ` Evan Straw [this message]
2020-01-16  8:59           ` [bug#38865] " Ludovic Courtès
2020-01-16 14:49             ` Christopher Howard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca311c53-d0db-4570-bb25-3d7b57161dcb@localhost \
    --to=evan.straw99@gmail.com \
    --cc=38865-done@debbugs.gnu.org \
    --cc=brettg@gnu.org \
    --cc=christopher@librehacker.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.