From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OuESLZJPuWCETQAAgWs5BA (envelope-from ) for ; Thu, 03 Jun 2021 23:54:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UGKyJ5JPuWAdfwAAbx9fmQ (envelope-from ) for ; Thu, 03 Jun 2021 21:54:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B225B9BC for ; Thu, 3 Jun 2021 23:54:26 +0200 (CEST) Received: from localhost ([::1]:43704 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lovIH-00055w-G7 for larch@yhetil.org; Thu, 03 Jun 2021 17:54:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lovC6-0003hw-8K for guix-patches@gnu.org; Thu, 03 Jun 2021 17:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lovC5-0004n1-Vz for guix-patches@gnu.org; Thu, 03 Jun 2021 17:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lovC5-0006lO-UK for guix-patches@gnu.org; Thu, 03 Jun 2021 17:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48729] [PATCH v2 47/47] gnu: Add bitmask-vpn. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 03 Jun 2021 21:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 48729@debbugs.gnu.org Cc: jgart@disroot.org Received: via spool by 48729-submit@debbugs.gnu.org id=B48729.162275686625978 (code B ref 48729); Thu, 03 Jun 2021 21:48:01 +0000 Received: (at 48729) by debbugs.gnu.org; 3 Jun 2021 21:47:46 +0000 Received: from localhost ([127.0.0.1]:44947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lovBq-0006kw-Fq for submit@debbugs.gnu.org; Thu, 03 Jun 2021 17:47:46 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:36736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lovBn-0006km-Eh for 48729@debbugs.gnu.org; Thu, 03 Jun 2021 17:47:44 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id Clnh2500B0mfAB406lnhWo; Thu, 03 Jun 2021 23:47:41 +0200 Message-ID: From: Maxime Devos Date: Thu, 03 Jun 2021 23:47:35 +0200 In-Reply-To: <20210603205110.7102-47-rg@raghavgururajan.name> References: <20210603205110.7102-40-rg@raghavgururajan.name> <20210603205110.7102-47-rg@raghavgururajan.name> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-MZ3YZq5j0gImcksDFIxz" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1622756861; bh=3x21uT+cAl3mCVBmapEuaYsPt/g0lcyLGzCFPOV7fAE=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=bDf8DhnmiwMQr3aOV5YbDCGpnDOhzf6Sgqj89NG9h7c1hYIJKA+bSiS0Jo5x2hnXR +M7XaEe/RfDvJIMTMMbaHAzlXx+KA7U84ZY0W4YFPSwId00aATxtYxjQ04ZcAJQ8aZ x2iUvU36wQ34GezkSBpuv0ni2faxgO37KOdJkVWUZe/Dq+BJm9YS860jSSQPOL3s5z Ldf6GgxZ2RFtrSxTJg8GgPDCya0Dr5xzxMLZxF26MEhrk9qYUoqK/BxLnHTIgEL0Xp SaBrNqrw0QE2YKhzNkd9J9IEXvKad1RmxhEtuW6yAkH2Jow2EDo69khPM43pmvMP0R zUp+sN58SnXRA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 7B225B9BC X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: YL+qlElhZ36R --=-MZ3YZq5j0gImcksDFIxz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable One comment about this patch. Raghav Gururajan via Guix-patches via schreef op do 03-06-2021 om 16:51 [-0= 400]: >=20 > + (replace 'build > + (lambda* (#:key source system outputs search-paths build-flag= s unpack-path inputs #:allow-other-keys) > + (for-each > + (lambda (directory) > + ((assoc-ref %standard-phases 'build) > + #:source source > + #:system system > + #:outputs outputs > + #:search-paths search-paths > + #:build-flags build-flags > + #:unpack-path unpack-path > + #:inputs inputs > + #:import-path directory)) > + (list [...] This can be done a bit simpler, and less prone to breakage if/when a new keyword argument is introduced at some poit in the future (untested): (replace 'build (lambda arguments (lambda (directory) (apply (assoc-ref %standard-phases 'build) `(,@arguments #:directory ,directory))))) WDYT? Likewise in other places. Also, trailing #t in phases aren't required anymore (but harmless), though you probably know that already. (The warning should disappear when core-updates is merged.) Greetings, Maxime. --=-MZ3YZq5j0gImcksDFIxz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYLlN9xccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sAnAQD4cGtx1M/sewKvRpxVeCVRsRLz EmCicMR9jZ9r8O17tgEAzf0GeowULKabsrGbKivydP1BrTPhL8BFYbYMEjOMAwY= =bKKf -----END PGP SIGNATURE----- --=-MZ3YZq5j0gImcksDFIxz--