From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iGZqLl+oL2duHwEA62LTzQ:P1 (envelope-from ) for ; Sat, 09 Nov 2024 18:22:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id iGZqLl+oL2duHwEA62LTzQ (envelope-from ) for ; Sat, 09 Nov 2024 19:22:23 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=KC8HX4IH; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=soverin1 header.b=eozOG98O; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731176543; a=rsa-sha256; cv=none; b=Xq8BP3juZ5lHE6Hu8nWGx1YYpuQUS0LT7y8mlTC47xz+FyvmLTIZVR78wNwYMmmXQ5hLyE +de6fn6Imk+MNfMGJC2ckthKVD/YbGNohOPOrQ7FMpHl7huIgbqHYk5KksccZq3GGIQmWX NRJ4skyTZW4YPcq0Lb7m34txBS7Ypfk6ISKZv+SwHN0ghSdzsruzGCfB2lWk+5GIfRblJa diIVSodru2X1GGl/AjsLo7ESJm4fXnoPV3Jp8j69T6Sb+jhLlYalR6GDJeGOGpTeuzHXaT LFr+7ZURCyZizAbxzTQduPjCoRlthXtI6Vnb4yt05a7ARLFYPP2IEeMPPjAd8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=KC8HX4IH; dkim=fail ("headers rsa verify failed") header.d=elenq.tech header.s=soverin1 header.b=eozOG98O; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731176543; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=X2aB+jFimwOqk7B4KnyVdQ0hWxtuACUHspo0C/mVhtA=; b=CUZo7C8NXw42QoKRdn5QiXzs2EBxu9ZwNx26DSVOlcIwTYQRb6Qt2s4/R/6lmoG/lpLAWT uPXJuLCJ4ZKl4j1YLanlJJQLlmd/s7jGPIfvRS0GK8WUeJfNMkt3+XFWqR+XstM6lvHstJ hmyGy+DHmVxo4xmUV8zIws7eovLumRY/C0SPg8f5rIcPYjmnKE8GWRtdJfu/D8uCZcDWVU 7D1Ek1et1mPnPU9QYHz4Kn6cVWB738XFWL+k9D3Ph5Wg/2DtyJaLR0GwkY4HOU2J5NQ+qC OJq7LJbk0U4f2GXNoMxr5TVqMgNy4TPsojjZSU5izL5kg6LpHSpKvzqVsl4F3Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2BF72737FB for ; Sat, 09 Nov 2024 19:22:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9q62-0000lX-UQ; Sat, 09 Nov 2024 13:22:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9q60-0000l1-0b for guix-patches@gnu.org; Sat, 09 Nov 2024 13:22:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9q5z-0002RY-11 for guix-patches@gnu.org; Sat, 09 Nov 2024 13:22:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=X2aB+jFimwOqk7B4KnyVdQ0hWxtuACUHspo0C/mVhtA=; b=KC8HX4IHW7k+/+2p/Oj0BXENxJkCYxlKbIIVuW3l65INpsY5pk7Q/nmUKl+ncU+xuUOxnvtx1oUkEXeM3I2hW1LVG06rv4X3JUSp6aucrvzga4Dsec52D6NI5YDgxMw/4OPvA5MVQQLN1NzcGLNyeACsxbuNfXXHL+q62HUZDnP8dyShNQdrDM4f1gaDLqUQBXGS8OxpqDMJ/nE/g6uorMxNXjN3cA3Syjw4NV56oWa8TGaSDz4RtYES74OVnXcgKrhx2qO55MS3uRCwE7fW2w5qtJJ8M8H+0CizLhfAY23Er+EceClLZVim0yE5nCo6l2EwFmMHNLmDUMGQE533tQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9q5x-0000VQ-S6 for guix-patches@gnu.org; Sat, 09 Nov 2024 13:22:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74251] [PATCH] Adding jack-mixer audio package Resent-From: Ekaitz Zarraga Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Nov 2024 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74251 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74251@debbugs.gnu.org Cc: Divya Ranjan Received: via spool by 74251-submit@debbugs.gnu.org id=B74251.17311764841887 (code B ref 74251); Sat, 09 Nov 2024 18:22:01 +0000 Received: (at 74251) by debbugs.gnu.org; 9 Nov 2024 18:21:24 +0000 Received: from localhost ([127.0.0.1]:54430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9q5L-0000UN-W4 for submit@debbugs.gnu.org; Sat, 09 Nov 2024 13:21:24 -0500 Received: from dane.soverin.net ([185.233.34.24]:48581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9q5I-0000U9-JJ for 74251@debbugs.gnu.org; Sat, 09 Nov 2024 13:21:22 -0500 Received: from smtp.soverin.net (c04smtp-lb01.int.sover.in [10.10.4.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dane.soverin.net (Postfix) with ESMTPS id 4Xm3yg474Vzyft; Sat, 9 Nov 2024 18:20:43 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [10.10.4.100]) by soverin.net (Postfix) with ESMTPSA id 4Xm3yg04TPzHb; Sat, 9 Nov 2024 18:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=elenq.tech; s=soverin1; t=1731176443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X2aB+jFimwOqk7B4KnyVdQ0hWxtuACUHspo0C/mVhtA=; b=eozOG98OkIBZsNzeQVwxueTOrXFVfyDWVsY+vyQKjJQgM5kwKLDzakdS13bDhBDKAAF0kM +A/k/i611pc5IJNg0j1+DYw0HX2gYGynoAHOxmejozpXSzhBQRQIdYx7wMazmLpW4dR7Ej S2M9id0vpi2u36oG2c8Im8KtREpi8WAmM35qnDBDfx5s28AnKFJZPUDKFr64LuKJyo0iKg c6sNohnsaPWdDc24FF4sUgg6mL0QxQYbm1lerjP1rVgc50U8LPILTY1N/QaXhuf+h7LNkl rRjOljuiWUWBsF1nk7y87RpaVm1mvLCky9MvwXriYs9o6rNpt8LBAonFC7BHbw== Message-ID: Date: Sat, 9 Nov 2024 19:20:42 +0100 MIME-Version: 1.0 References: Content-Language: en-US, es-ES, eu From: Ekaitz Zarraga Autocrypt: addr=ekaitz@elenq.tech; keydata= xsFNBGcvh/QBEACePF16wEeQaqfJNgeaSQB6ty6PzLaYtl8UVApPSCF1PYNEhDtxQOOpBXeu k6h68cjhRX7hmug8mAraXotw4aG4Z3kbUro4fzXOYW3rCi/mAm5NFXLUmBX3E1AV1pcD8hDA 5s3LeGzfTo4xRGTW4zTzxGEyrvbChkVib7wTSk52a/WkFas6l3sXnepF8HmIEOWkwQcYdcuo gaNDFP1kjZYvqfKJXmCZnY+lC8Zfe/vlD/x8FZQYBQ5xgXIfbSR0xlRz/XIHfJv6j+3myUUr 2UKMku1dkjlkhNkyfw+RypQzmbJ0oJ4bk76/ju0nnlN65/LvyeTVUh/2O2VnPnZ49keL8sqr APXF4di4pWT+/mPxfoEtiSDtjyzbr8+ajcwLa4SSKLlexqjZj8X6R4tt31Rf/Pliwe4TdPmd 2leE3BIJl9bAuslEvd5tqZ1oa3Zfb62tvpaJCRYMtOEWuGkYdyrwTW7UXJPQpam4X7WoW2jW c5aTpAnpnqIPzaWJmua1lGQjEXgt4xvVdhVmZq32fkTy/rXw9l5a+XU7N4/Zz8AR/0xO+UBc Q1J+wHADjL8Q0v0tZLEaiWL72AsxN3GMWNPXWAplaTPUNPUlNK0JPHwhTX/cQVkIc9avSKc3 BeUofC96d13I7QmRjQ0gcBaLtV9lMOuYwbC+6tb70x2fQsI3bwARAQABzSJFa2FpdHogWmFy cmFnYSA8ZWthaXR6QGVsZW5xLnRlY2g+wsGUBBMBCAA+FiEEXb4j05BTZSZ/jMdq/blSvT9z VtYFAmcvh/QCGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ/blSvT9zVtbW CRAAkbla35s8RKhQBweqwEcdYDV2Zpt16OgENymjLs/qhh7Y9WgWZ0YraSNYDGCt6lemhior vrXX48+yZC98c8ZgCrr4Hmt8i/6TvJqVhwlZ9//3W/z/YuYDtUPBzRHgwM8tejiXmNqYM8lF Jg64pQaczmGAR29Xf0WTQegSociBSUg9eC7BS74Uh7UbHCgytyretoKmqJAp8SKE/Czt5x4R lXKVgGawzg1GerriwnNbudy0eyl1q0Pn7Q+K+tQ14EPDAM+QsGR/fBV4a3uYP6sBF+SdM+DO LX5MRVbWJ8O3kLmbAKQeLgSLlnYydMY/mTvjgxMAakfGCA4q69gmyDSB0fzAUm3c1JV5VwIo 63rykiOEB/k2m4aiiujH5kOC86sjb273+XXWlOhOEO/vKHHdAh+B7dnEEYUPXnUEMQ23PaF4 22u7C62kw3yH/krKr60t5FxcqNWtCOxEWc0WMZw12Q3Gw8+9oA5DI/f4gjlGvQiQWqj6dvoX vIDmifr0R3sTi6xh+udu2Rp8PsKOW8ZRyQ0/VOiwzBfQkf4PFowaiRp8LnkjLEVft6ruuA1h awO2SKKJ8WpgZPw5oMigZR5DgbunxMD4BcqmD7bSoTRV/ljx1I8UgAaQLPqVVnLt31iENtLv 43kPHl56AbYpAzcvf8nGU3KPhGOoByyuyph4RYDOwU0EZy+H9AEQANc9vw7DnBeNGKhq1Bg5 oiGII7npGXCChe7PB6CJjkvN6n1kXrvBYsaORXvZJPNgmBTKu/ETGYS0t0YeGlI4WTOK9dgB /7T8dngRmrGjPmZjryzfk18tXnJq0zoLixLizDT3FqV4jOG5KjPTxQvpdBMiX9oX4Je2OMqF d14fopLGav0rW7Fh5p83OSREpXbJUJJiUaH3p9U9Ss8IBHzr669PViAqe09EfxL/L0l1JIFj HQjJcg01PUXZAW6aPtd7q6eNCSLTXYPiDRQe2GdRUcB7WfqCogR/LEpzLLcd0NkxCnc0T6da rq2Dupt8rvQ95L4/cOGVcDUDOGE6U92XCkaCvUQkypxQCGKSEjbTFoLRG/4JQj0pAWSaqxPS 7hkTFql4qUAdRwzHN1ib6XedcFfqHSy2Mk5ttW8DaBGKhCm7Mn6+4smXENHSuQxCqHlCQ2m+ 9ogpbxavNVfAblE/ucxyfyo6FlDbGHEG3Yu5296kUPT7PqZLiR3KetMPJfCLY2jVPio3t4tD s7Sj41sG5aIwEApb0Zoz3bPBt5O5GUoPFnXyjO306WLxXrM2tjY38jwHxF1Qvs3HQTJgRei2 g3D3KiiR27cXXs/8lrr8tblr5J1tE4TaQCea5lDuEgTCDLnlcopoYcKpFAUBGQtzcNkudT9w sM2nf9y6INcUE3FlABEBAAHCwXwEGAEIACYWIQRdviPTkFNlJn+Mx2r9uVK9P3NW1gUCZy+H 9AIbDAUJA8JnAAAKCRD9uVK9P3NW1td1D/4xx8AbDKAKx9ezT6GdTZbK6FS66qRQCEzTa5MX ZCEogASOla71CB10l5fFtsRWCtNQLzmgwkFwhdxyjqendDgacc5v/71NBb5KpKni6wDJMeiG s3Lq3ZgWfHte3NZ99iSH+La3aBSFbCloJ/Yf/MJBkzrm1sTTKcgF9/i0pzkume5vtpKRDjjS z4abHu7qk4Sgi5gwWpoKFTT38q6nLP+9SUla3JJjNqU3gvn8kwv6KDMKc4marnSp/c+5O6E+ lNrxMdD0n8+io/Bf/UEI6BU8F7JshPq732bHN1NzUXvgMd4cNsAlvsWM8UCKZ4/usFl1euMM FOvnadZinsTHpXhahJzkYWA7nAKbCoNNq9LPtWxfjHsIfhs+QQafF31Pw+jqHqruB4tH0eiL abrz7kejaZvJdVipNIzRUWYnpP+18khep2UtT1n9VNs6QNb4cHPsoe+s4ga4ZK/klCdEhLya XtbcaNEHb7NZUOBj3HhKFgIY8PD1AptAObHjsUNF5+jfEnl+5WjwyTZTIgDRiOrwn8LWOANQ 0JpR69t06uJwmiogQgnlYe36YFaauHGQZFa+L+R2zgnGn8TnR4C3tH7gNAef9+PKqgmJT5pN IkFzlDmZi05E9xzhj4WQ/OOsqU64eHL2PaDk+2TdfrzNwNFbkABJ+C7BHNAytQ6h9cpUbg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spampanel-Class: ham X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.39 X-Spam-Score: -5.39 X-Migadu-Queue-Id: 2BF72737FB X-Migadu-Scanner: mx10.migadu.com X-TUID: 6aTa1N4NSKTt Hi, The commit message should follow the Changelog format as described the Submitting-Patches section of the manual. That said: > Hello Guix devs, > > Apologies, I forgot to `--annotate` the git send-email, the following patch adds the jack-mixer application to the `(gnu packages audio)`. It's a python package built with meson, I've tested it with my system and it is deterministic. > > Let me know if any changes need to be done. > > P.S: CC me, since I'm not subscribed to the mailing list. > > Regards, > > > On 8 November 2024 00:01:01 GMT, Divya Ranjan wrote: > >--- > > gnu/packages/audio.scm | 68 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > > >diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm > >index 467dc4a74f..70477d1071 100644 > >--- a/gnu/packages/audio.scm > >+++ b/gnu/packages/audio.scm > >@@ -79,6 +79,7 @@ (define-module (gnu packages audio) > > #:use-module (gnu packages check) > > #:use-module (gnu packages cdrom) > > #:use-module (gnu packages compression) > >+ #:use-module (gnu packages commencement) This is already included in the `build-system` so you don't need to add it. In fact, it breaks Guix when you do :) > > #:use-module (gnu packages cpp) > > #:use-module (gnu packages curl) > > #:use-module (gnu packages dbm) > >@@ -160,6 +161,7 @@ (define-module (gnu packages audio) > > #:use-module (guix build-system python) > > #:use-module (guix build-system trivial) > > #:use-module (guix build-system waf) > >+ #:use-module (guix build utils) > > #:use-module (guix download) > > #:use-module (guix gexp) > > #:use-module (guix git-download) > >@@ -2772,6 +2774,72 @@ (define-public jacktrip > > audio signal streaming.") > > (license (list license:gpl3+ license:lgpl3 license:expat)))) > > > >+(define-public jack-mixer > >+ (package > >+ (name "jack-mixer") > >+ (version "19") > >+ (source > >+ (origin > >+ (method git-fetch) > >+ (uri (git-reference > >+ (url "https://github.com/jack-mixer/jack_mixer") > >+ (commit (string-append "release-" version)))) > >+ (sha256 > >+ (base32 "18m6a9asbwaslw418i2w04kgc6jgdpw01i3kawdqy903kw66hnhj")))) > >+ (build-system meson-build-system) > >+ (arguments > >+ (list > >+ #:build-type "release" > >+ #:phases #~(modify-phases %standard-phases > >+ ;; Replaces hardcoded path with /gnu/store > >+ (add-after 'unpack 'path-patch > >+ (lambda _ > >+ (substitute* '("meson.build") > >+ (("'/', 'etc', 'xdg'") > >+ (string-append "'" > >+ #$output "'"))))) > >+ > >+ ;; To wrap the paths for python and GTK > >+ (add-after 'install 'wrap-path > >+ (lambda* (#:key outputs #:allow-other-keys) > >+ (let* ((out (assoc-ref outputs "out")) > >+ (bin (string-append out "/bin/")) > >+ (gi-typelib-path (getenv "GI_TYPELIB_PATH")) > >+ (version #$(version-major+minor (package-version > >+ (this-package-input > >+ "python")))) > >+ (lib (string-append out "/lib/python" version > >+ "/site-packages"))) > >+ (wrap-program (string-append bin "jack_mixer") > >+ `("GUIX_PYTHONPATH" ":" prefix > >+ (,(getenv "GUIX_PYTHONPATH") ,lib)) > >+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))))))) > >+ (native-inputs > >+ (list gcc-toolchain As said, remove gcc-toolchain > >+ pkg-config > >+ python-cython > >+ python-docutils > >+ gnu-gettext > >+ glib)) > >+ (propagated-inputs > >+ (list gtk+ > >+ `(,gtk+ "bin") ;; Required during runtime. > >+ python > >+ bash-minimal > >+ python-wrapper > >+ python-pygobject > >+ python-pycairo > >+ python-platformdirs ;; Required to save sessions. > >+ jack-2)) > >+ (synopsis > >+ "JACK Mixer: A multi-channel audio mixer for the JACK Audio Connection Kit") > >+ (description > >+ "The jack_mixer is a GTK+ JACK audio mixer app with a look & handling > >+similar to hardware mixing desks. It has lot of useful features, apart > >+from being able to mix multiple JACK audio streams.") > >+ (home-page "https://rdio.space/jackmixer/") > >+ (license license:gpl2+))) > >+ > > (define-public jalv > > (package > > (name "jalv") > >-- > >2.46.0 Also when running `./pre-inst-env guix lint jack-mixer` there are several problems with the package. Some you can fix with `./pre-inst-env style jack-mixer` but some others you have to fix by hand: guix/gnu/packages/audio.scm:2777:2: jack-mixer@19: 'gettext' should probably switched for its minimal variant gnu/packages/audio.scm:2777:2: jack-mixer@19: "bash-minimal" should be in 'inputs' when 'wrap-program' is used ... Please, run the linter and fix the problems. Thanks for the patch!