From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gJTrDiD+AWKiFAAAgWs5BA (envelope-from ) for ; Tue, 08 Feb 2022 06:22:40 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wJBrDCD+AWIGCgEA9RJhRA (envelope-from ) for ; Tue, 08 Feb 2022 06:22:40 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADC4B3F534 for ; Tue, 8 Feb 2022 06:22:39 +0100 (CET) Received: from localhost ([::1]:50392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHIxa-0003x4-0Z for larch@yhetil.org; Tue, 08 Feb 2022 00:22:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHIx1-0003sI-Tw for guix-patches@gnu.org; Tue, 08 Feb 2022 00:22:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nHIx0-0001Yf-BO for guix-patches@gnu.org; Tue, 08 Feb 2022 00:22:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nHIx0-0000Ac-5n for guix-patches@gnu.org; Tue, 08 Feb 2022 00:22:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53676] [PATCH 0/5] *** PulseAudio service improvements *** Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Feb 2022 05:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer , Jack Hill Cc: 53676@debbugs.gnu.org Received: via spool by 53676-submit@debbugs.gnu.org id=B53676.1644297700613 (code B ref 53676); Tue, 08 Feb 2022 05:22:02 +0000 Received: (at 53676) by debbugs.gnu.org; 8 Feb 2022 05:21:40 +0000 Received: from localhost ([127.0.0.1]:44722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHIwe-00009p-IL for submit@debbugs.gnu.org; Tue, 08 Feb 2022 00:21:40 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nHIwZ-00009Z-9n for 53676@debbugs.gnu.org; Tue, 08 Feb 2022 00:21:39 -0500 Received: by mail-ed1-f66.google.com with SMTP id co28so7919269edb.1 for <53676@debbugs.gnu.org>; Mon, 07 Feb 2022 21:21:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=gdQq3mdICGj/V/iQNFQuhZFNAGIN2eUVcSW2ponL2MA=; b=odCHTCnyRThZ8AGGFZ8RTdB2xKHh4jn9X7RXW1P1uJc0cqF/+62sGl9enT0N+d0ywB A+gJ/JZclmgGN8stsrWBCBI3eugZDWER+JcBudgAUA3gFIE6REJwFKWFpcF8HhZ6iX6d fZilYRCrHxLgks/6MVjCSXIhVWSOR+sXX0X/Lw2BZGU4PXNt9Ikdj+wIxZjN9jm5+Rb2 sGjinjTOZHMZPUE3GuGY9f1NHca7xjUApfTFV2RBJ4WkzyZBlHaFhCRYkyEaVLxufw90 8ScjwaVOXUJCd1tdLsihOY09aXOjF/Doo83bvKyrFLpMUJrJanm8OtLdqJlqoVhix767 8z5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gdQq3mdICGj/V/iQNFQuhZFNAGIN2eUVcSW2ponL2MA=; b=EdMyi+d0WRnyTKgmEyTpvoT0rAwBFjZAjN1OHH8FDPU6GzM2UYfmvvWGxGSjCh96Sj 3GY3VOh+XvU6R/oPhTXG+Fsk/EmPdPQR8L5IxUhYTrmSu1SWrxvsNp6ezdFQAXKjnPt/ TyIdG+6oZppMGtcx7xajU7KQdPXBQa6RbF1jDCQ1KJqkPpFX/ULqC4NG9mnHDmnmRkMu UQU0NJ0stkufC8DuSUrBfGTSIz0bzNiQ/y8TSTZLH82B/6pwpikKg5yb3359WAkZJjUb +Onhqp03xE3Peqd7BRUmrUWiVTMPYjMSY9+je3rVWCjvERhNtT9X8tUYHGJ8QiPSGG9A Zgcg== X-Gm-Message-State: AOAM532wcQ8S0A1JfdxRV5wuUuNmIM08bRkFRKaNxxZvdOvE8NVL3nQX xzP5gf+h6+nESWwKFJoRrOg= X-Google-Smtp-Source: ABdhPJxRGz0GrLZ9Ps/lZn+XlnqHCosz7KljcvqBkhNzmd/x+4BAzrBohTLbZtybfRtRcFgmcpND3g== X-Received: by 2002:aa7:cc06:: with SMTP id q6mr2805760edt.44.1644297689151; Mon, 07 Feb 2022 21:21:29 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id h21sm2432955edt.26.2022.02.07.21.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 21:21:28 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Tue, 08 Feb 2022 06:21:26 +0100 In-Reply-To: <87mtj2z4xe.fsf_-_@gmail.com> References: <20220201041933.16603-1-maxim.cournoyer@gmail.com> <20220201041933.16603-5-maxim.cournoyer@gmail.com> <87mtj2z4xe.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644297759; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gdQq3mdICGj/V/iQNFQuhZFNAGIN2eUVcSW2ponL2MA=; b=qBJFUrapj6ftbT/AwzzWdj75tPX8t49v21du6WSb5WEgSRrCrvqMdx/MhjPTljsX8ozwmj K/oouTaXrh5TmvUVaLFQ4F6egpMKR+UB+Cb9dCMZEtR+jxspTWAKJxtxVyAO785lByCAKk Z/RiyCd175TeYgM4T0qNBAlTIZa+cFO8Gm71jgeCQntNJ5kMl2NwrZiHDCmoQxMCa9LQtA z7SC1kaZCRdwTJrJHPk2VcQNJenBlq+ve0fw8VgFx+/e7/aD85k5q9xO/9qwjX3yqCtKXU cxZWOqBG8cenu0DmoSpYxqAqWXTqerULLdrU3WTVXogBg6hqYygryLhYc/4EeQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644297759; a=rsa-sha256; cv=none; b=iAcipSGTabie0M2T9SIJH/HzxLvrK1B08d3zqshSdA5QfSb4W9RyI/9cbEugS2FpvhfDaL vU9eBVxDX20l2We5izm0J67YKfLTKTpquRq/awGE56OhvB6qjNjLwX8Jo/Hi8KpmgOqvW1 +WuPAJ2b7UHN1NRWeQ68zOhG1MGa8aDFKfW4ttZFOmteMhgnOS3EvCmM2GYnNBCkoNCT2b D4tzZV0GzIHbrHdn+Ae2Pvx7ARb7YgQNbdTC6IiRRqBb2rmNbv/DDjuEgWqNCTQNajYnF8 /J35jdsOF3FG0Sgmkt3bFLcj9MEYe14VCeg9pt9PGpUrYOHXop96CBcQEelbpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=odCHTCny; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=odCHTCny; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: ADC4B3F534 X-Spam-Score: -2.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3pgCJt+75Sdt Hi, Am Montag, dem 07.02.2022 um 17:29 -0500 schrieb Maxim Cournoyer: > Thanks for this!  I wasn't aware of the history; I tried it and it > failed the same.  The following fix I attempted in webkitgtk did not > seem to do anything: > > --8<---------------cut here---------------start------------->8--- > modified   > Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp > @@ -24,6 +24,7 @@ >  #include >  #include >  #include > +#include >  #include >  #include >  #include > @@ -337,7 +338,16 @@ static void bindIfExists(Vector& args, > const char* path, BindFlags bind >          bindType = "--ro-bind-try"; >      else >          bindType = "--bind-try"; > -    args.appendVector(Vector({ bindType, path, path })); > + > +    // Canonicalize the source path, otherwise a symbolic link could > +    // point to a location outside of the namespace. > +    char canonicalPath[PATH_MAX]; > +    if (!realpath(path, canonicalPath)) { > +        if (strlen(path) + 1 > PATH_MAX) > +            return;                  // too long of a path > +        strcpy(path, canonicalPath); // no-op > +    } > +    args.appendVector(Vector({ bindType, canonicalPath, > path })); >  } Apart from raw char arrays and string.h looking funny (and wrong) in C++, what is strcpy supposed to do here? Would it work if we mapped canonicalPath to path (i.e. `ls path' in the container would be `ls canonicalPath' under the hood)? Cheers