From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uLmCJB77MGUoBgEAG6o9tA:P1 (envelope-from ) for ; Thu, 19 Oct 2023 11:47:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uLmCJB77MGUoBgEAG6o9tA (envelope-from ) for ; Thu, 19 Oct 2023 11:47:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 563894CBCA for ; Thu, 19 Oct 2023 11:47:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VOIUFyjE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697708830; a=rsa-sha256; cv=none; b=Eg0B/B4EvLWp2sKn8BWbpnO/V8W5MlVGl6anPOmJ+QkfFL5C2su8Hbf3wl4PGGOAqp7waR 9pekkKfSohXM25xBVG8ag/PfjUH42m6z6Dq1tbuyjchKBj2MhtLOCySwg9BTkBCs0nK0V1 umL/wNdr0jlTOTAX8rFoy01gebxoT/hFgAFIyUyOgbHqnptXNcjsiNj+aO6n4HbA+4r1yn duoRTJnuWmj9hQt5Qxo3O62vcKS0VsLsna5WpJixjWxSTzbS9txG4QvrVIfX1wh87aOVRe kNDthv2CPjWyUXrynfCcGhSs8PO0Z6hZaDK9U5DNwGTcufI6W+XykAdUOWSaqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=VOIUFyjE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697708830; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4PdguxofxtB/Pij8Db7wYZs0lIOuX2Z/sJMlS8p8OBs=; b=CTa4nFj+X1UvAL8+bqoeRZDsy42c4T6UnBOM4HcljgSjOcBTHCJQJeLjEthgqt57lfjKTg NKuJbqPHfNL5bj956tJK+kTLXwkib+aBoSap51wMEB67a0fHclY6GBEmi8eos2qJtiw6G2 4iDK4b3VtMHg4Q/D3onj1iWCSAFYH3IbvxqpSqSZstDkaNj6Wtp/3IPd/kr754jSIxnYID dW68TfMMV53BmpxOSdVz8MKr8YsD6PIXpx/BjMWZp+HqnFGieTrBjxREoRWa0S9wa1hc5f UqDqoazkoW6RMmP/EBdSi/kWHgvR8/HqSDJ6ax877hrd59VAjF+v+hamylInPw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtPcG-0004sZ-B8; Thu, 19 Oct 2023 05:46:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtPc2-0004qy-GC for guix-patches@gnu.org; Thu, 19 Oct 2023 05:46:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtPbw-00039D-8a for guix-patches@gnu.org; Thu, 19 Oct 2023 05:46:37 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtPcM-0003Jj-Gg for guix-patches@gnu.org; Thu, 19 Oct 2023 05:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66500] [PATCH core-updates 1/3] build: copy-build-system: Allow specifying different output labels. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 19 Oct 2023 09:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66500 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal , 66500@debbugs.gnu.org Received: via spool by 66500-submit@debbugs.gnu.org id=B66500.169770880912717 (code B ref 66500); Thu, 19 Oct 2023 09:47:02 +0000 Received: (at 66500) by debbugs.gnu.org; 19 Oct 2023 09:46:49 +0000 Received: from localhost ([127.0.0.1]:35835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtPc8-0003J3-Qj for submit@debbugs.gnu.org; Thu, 19 Oct 2023 05:46:49 -0400 Received: from mail-ed1-x542.google.com ([2a00:1450:4864:20::542]:56501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtPc4-0003Ik-1e for 66500@debbugs.gnu.org; Thu, 19 Oct 2023 05:46:47 -0400 Received: by mail-ed1-x542.google.com with SMTP id 4fb4d7f45d1cf-52bd9ddb741so13419514a12.0 for <66500@debbugs.gnu.org>; Thu, 19 Oct 2023 02:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697708771; x=1698313571; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4PdguxofxtB/Pij8Db7wYZs0lIOuX2Z/sJMlS8p8OBs=; b=VOIUFyjEuBYzfFyN4timhx7RPFNrlDBqwyVbJxPhmvOP/D6kubDlpueZA7GDp4TR1g fk91zDxnreBn8+FMwCbGdF0ftwRTas+T7aEVka1GxmYj3MGoCF6CQoyXLMzNVsNgmx9l TNraRgayWcY8PhhDpI7TaDfQGe6HDINzDxDT7KrjlNiRSe74DTXDXIEH0aTbmME/MVle zimDDXoEww9H4IlIX3OQ6w6WdLcW25gJ4AFMvSWFCHwTl6kyDgPsG2Mv+hA5dAqoc7A6 yijQoDUbLg+ojZsoOLg91WoHE+LtK6bJWyVVB981/ME/DgoXvHHNJfbUkXhxlvWJ0uM/ vJMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697708771; x=1698313571; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4PdguxofxtB/Pij8Db7wYZs0lIOuX2Z/sJMlS8p8OBs=; b=CQfUCsWXvBC4hzEGNIK9RB/k7yQGKvraXQGepLy+wA9+fiy2iJXUoYKhqneEa6vpN/ EdRTqef9ti4WKwlO9OXHRE8qYNClAVtbybNc2vw04CxPMVDpPX8OjRgAOT5glRt0F/w+ oCUak+xsnzoydUwMhVUPPV/OAnTJ5UGEbun/n0mUwjXEbtr07DqwjNY4iRCQF5rYe4cz FpP0W7un1qVozkpTavQiCX6AhbC7yUKOG21keb3x92Xv0uxv0w3LXvQE4FOloxg2FKsY mlP7NsRKQX7aI165cTuwna6fiX6mxEFB0A+iJ/0JpAxI0kWBPFCz58kC+5yPhxL52m16 XkMw== X-Gm-Message-State: AOJu0Yy46+I0cqWFrrphD55vFBqthL848LFNawVP3ZxqIRiesh/8uXnw scAPirZLQFj6mMnqeZqu8nk= X-Google-Smtp-Source: AGHT+IFcuqQSk57BOKoRz/m86E3HlaZmdWHkNaDSR7e5hlPZWLUzEDVwuud2pYSl7K5UJFT/g+Exvg== X-Received: by 2002:a05:6402:2753:b0:53e:f4:ef85 with SMTP id z19-20020a056402275300b0053e00f4ef85mr1242268edd.10.1697708770551; Thu, 19 Oct 2023 02:46:10 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id m26-20020a50999a000000b00537666d307csm4236721edb.32.2023.10.19.02.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 02:46:09 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Thu, 19 Oct 2023 11:46:07 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: 2.84 X-Spam-Score: 2.84 X-Migadu-Queue-Id: 563894CBCA X-TUID: zOX926rNJ693 Hi Bruno, Am Donnerstag, dem 12.10.2023 um 16:30 +0100 schrieb Bruno Victal: > [...] > +@item When a package has multiple outputs the @code{#:output} > argument > +can be used to specify which output label the files should be > installed > +to. This is perhaps extremely nitpicky, but there should be a comma before "the @code{#:output} argument". > @@ -63,6 +64,9 @@ (define* (install #:key install-plan outputs > #:allow-other-keys) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 If both `#:include*` and `#:exclude*= ` are specified, the > exclusion is done > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 on the inclusion list. > =C2=A0 > +- When a package has multiple outputs the `#:output` argument can be > used > +to specify which output label the files should be installed to. > + Same here. > =C2=A0Examples: > =C2=A0 > =C2=A0- `(\"foo/bar\" \"share/my-app/\")`: Install bar to \"share/my- > app/bar\". > @@ -72,7 +76,9 @@ (define* (install #:key install-plan outputs > #:allow-other-keys) > =C2=A0- `(\"foo/\" \"share/my-app\" #:include (\"sub/file\"))`: Install > only \"foo/sub/file\" to > =C2=A0\"share/my-app/sub/file\". > =C2=A0- `(\"foo/sub\" \"share/my-app\" #:include (\"file\"))`: Install > \"foo/sub/file\" to > -\"share/my-app/file\"." > +\"share/my-app/file\". > +- `(\"foo/doc\" \"share/my-app/doc\" #:output \"doc\")`: Install > \"foo/doc\" to > +\"share/my-app/doc\" for output labelled \"doc\"." s/for output labelled/within the output named/ or=20 s/for output labelled \"doc\"/within the \"doc\" output/ > =C2=A0=C2=A0 (define (install-simple source target) > =C2=A0=C2=A0=C2=A0=C2=A0 "Install SOURCE to TARGET. > =C2=A0TARGET must point to a store location. > @@ -133,8 +139,10 @@ (define* (install #:key install-plan outputs > #:allow-other-keys) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (string-append target "/"))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 file-list)))) > =C2=A0 > -=C2=A0 (define* (install source target #:key include exclude include- > regexp exclude-regexp) > -=C2=A0=C2=A0=C2=A0 (let ((final-target (string-append (assoc-ref outputs= "out") "/" > target)) > +=C2=A0 (define* (install source target > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:key include exclude include-re= gexp exclude- > regexp > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (output "out")) > +=C2=A0=C2=A0=C2=A0 (let ((final-target (string-append (assoc-ref outputs= output) > "/" target)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (filters? (o= r include exclude include-regexp exclude- > regexp))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (when (and (not (file-is-directory? = source)) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 filters?) Otherwise LGTM. Note, however, that CI doesn't like this series. Cheers