From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Prikler Subject: bug#38613: Disabling bytecompilation on a list of files. Date: Sun, 15 Dec 2019 01:35:27 +0100 Message-ID: References: <87tv62itdl.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-CvGK59/GcDXiE7sr+QzE" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:35392) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igHtE-0001pL-2c for bug-guix@gnu.org; Sat, 14 Dec 2019 19:36:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igHtC-0005pX-Id for bug-guix@gnu.org; Sat, 14 Dec 2019 19:36:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igHtC-0005nY-1N for bug-guix@gnu.org; Sat, 14 Dec 2019 19:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1igHtB-00013g-Ua for bug-guix@gnu.org; Sat, 14 Dec 2019 19:36:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: 87tv62itdl.fsf@posteo.net List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: brettg@posteo.net Cc: 38613@debbugs.gnu.org --=-CvGK59/GcDXiE7sr+QzE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hey Brett. Am Dienstag, den 14.12.2019, 13:45 -0600 schrieb Brett Gilio: > Just forwarding along an idea discussed between Leo Prikler, Tobias, > and I on IRC. Thanks for the mention ;) > Obviously just outright deleting the phase responsible for > bytecompilation is not the _best_ solution. So what Leo and I > proposed > was adding a #:no-bytecomp which takes a list of REGEXP or files that > will be excluded from the in-place byte-compilation. > > I wanted to float this idea by those of us who use the > emacs-build-system regularly. I actually came up with an alternative solution, that I already hinted at in IRC. 0001 implements a function to disable byte compilation for a single file, 0002 applies this to the package in question. I'm not quite sure why the files are not writable and wonder, whether the chmod should be added into 0001, but keeping it out of it should hopefully prevent abuse. It's rather late and this is just a proof of concept. I haven't fully evaluated the impact this will have on Guix (specifically in the amount of rebuilds it will cause). Also beware of my somewhat ill-formed commit messages. After painfully checking each of the themes for this bug however (on my machine, YMMV), I did update the comment for what it's worth. Regards, Leo --=-CvGK59/GcDXiE7sr+QzE Content-Disposition: attachment; filename*0=0001-guix-emacs-utils-Add-emacs-batch-disable-compilation.pat; filename*1=ch Content-Type: text/x-patch; name="0001-guix-emacs-utils-Add-emacs-batch-disable-compilation.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzNjVmNWMwMjg3NmI1MWNmNTY2MjI0ZjYwY2Q2ZDRjNmI3MDIzZDY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFN1biwgMTUgRGVjIDIwMTkgMDA6NDU6MDggKzAxMDAKU3ViamVjdDogW1BB VENIIDEvM10gZ3VpeDogZW1hY3MtdXRpbHM6IEFkZCBlbWFjcy1iYXRjaC1kaXNhYmxlLWNvbXBp bGF0aW9uLgoKKiBndWl4L2J1aWxkL2VtYWNzLXV0aWxzLnNjbSAoZW1hY3MtYmF0Y2gtZGlzYWJs ZS1jb21waWxhdGlvbik6Ck5ldyBwcm9jZWR1cmUuCi0tLQogZ3VpeC9idWlsZC9lbWFjcy11dGls cy5zY20gfCA3ICsrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYg LS1naXQgYS9ndWl4L2J1aWxkL2VtYWNzLXV0aWxzLnNjbSBiL2d1aXgvYnVpbGQvZW1hY3MtdXRp bHMuc2NtCmluZGV4IGZkYWNkMzBkZDYuLjJhYTYzYzMzNjMgMTAwNjQ0Ci0tLSBhL2d1aXgvYnVp bGQvZW1hY3MtdXRpbHMuc2NtCisrKyBiL2d1aXgvYnVpbGQvZW1hY3MtdXRpbHMuc2NtCkBAIC0y Myw2ICsyMyw3IEBACiAgICM6ZXhwb3J0ICglZW1hY3MKICAgICAgICAgICAgIGVtYWNzLWJhdGNo LWV2YWwKICAgICAgICAgICAgIGVtYWNzLWJhdGNoLWVkaXQtZmlsZQorICAgICAgICAgICAgZW1h Y3MtYmF0Y2gtZGlzYWJsZS1jb21waWxhdGlvbgogICAgICAgICAgICAgZW1hY3MtZ2VuZXJhdGUt YXV0b2xvYWRzCiAgICAgICAgICAgICBlbWFjcy1ieXRlLWNvbXBpbGUtZGlyZWN0b3J5CiAgICAg ICAgICAgICBlbWFjcy1zdWJzdGl0dXRlLXNleHBzCkBAIC01MCw2ICs1MSwxMiBAQAogICAgICAg ICAgIChzdHJpbmctYXBwZW5kICItLXZpc2l0PSIgZmlsZSkKICAgICAgICAgICAoZm9ybWF0ICNm ICItLWV2YWw9flMiIGV4cHIpKSkKIAorKGRlZmluZSAoZW1hY3MtYmF0Y2gtZGlzYWJsZS1jb21w aWxhdGlvbiBmaWxlKQorICAoZW1hY3MtYmF0Y2gtZWRpdC1maWxlIGZpbGUKKyAgICAnKHByb2du CisgICAgICAoYWRkLWZpbGUtbG9jYWwtdmFyaWFibGUgJ25vLWJ5dGUtY29tcGlsZSB0KQorICAg ICAgKGJhc2ljLXNhdmUtYnVmZmVyKSkpKQorCiAoZGVmaW5lIChlbWFjcy1nZW5lcmF0ZS1hdXRv bG9hZHMgbmFtZSBkaXJlY3RvcnkpCiAgICJHZW5lcmF0ZSBhdXRvbG9hZHMgZm9yIEVtYWNzIHBh Y2thZ2UgTkFNRSBwbGFjZWQgaW4gRElSRUNUT1JZLiIKICAgKGxldCogKChmaWxlIChzdHJpbmct YXBwZW5kIGRpcmVjdG9yeSAiLyIgbmFtZSAiLWF1dG9sb2Fkcy5lbCIpKQotLSAKMi4yNC4wCgo= --=-CvGK59/GcDXiE7sr+QzE Content-Disposition: attachment; filename*0=0002-gnu-emacs-doom-themes-Only-disable-breaking-compilat.pat; filename*1=ch Content-Type: text/x-patch; name="0002-gnu-emacs-doom-themes-Only-disable-breaking-compilat.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAzZjM3NjgyOGQ4OTcwYzA3NTFiODZhZWYwYjQ5ZTI1NmVlMDkyODdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gUHJpa2xlciA8bGVvLnByaWtsZXJAc3R1ZGVudC50dWdy YXouYXQ+CkRhdGU6IFN1biwgMTUgRGVjIDIwMTkgMDA6NDk6MjYgKzAxMDAKU3ViamVjdDogW1BB VENIIDIvM10gZ251OiBlbWFjcy1kb29tLXRoZW1lczogT25seSBkaXNhYmxlIGJyZWFraW5nCiBj b21waWxhdGlvbnMuCgoqIGdudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy1kb29tLXRo ZW1lcykgW3BoYXNlc106CjxidWlsZD46IFVuZGVsZXRlIGl0Lgo8ZGlzYWJsZS1icmVha2luZy1j b21waWxhdGlvbj46IE5ldyBwaGFzZS4KLS0tCiBnbnUvcGFja2FnZXMvZW1hY3MteHl6LnNjbSB8 IDIzICsrKysrKysrKysrKysrKysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9u cygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IDUwNTU5NGFhMGQuLjFjMDZh OTEyMmQgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBiL2dudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC0xOTgwMyw2ICsxOTgwMywxMCBAQCBjb250cmFzdCBh bmQgZmV3IGNvbG9ycy4iKQogICAgICAgKGFyZ3VtZW50cwogICAgICAgIGAoIzp0ZXN0cz8gI3QK ICAgICAgICAgICM6dGVzdC1jb21tYW5kICcoImVydC1ydW5uZXIiKQorICAgICAgICAgIzptb2R1 bGVzICgoZ3VpeCBidWlsZCBlbWFjcy1idWlsZC1zeXN0ZW0pCisgICAgICAgICAgICAgICAgICAg IChndWl4IGJ1aWxkIHV0aWxzKQorICAgICAgICAgICAgICAgICAgICAoZ3VpeCBidWlsZCBlbWFj cy11dGlscykKKyAgICAgICAgICAgICAgICAgICAgKHNyZmkgc3JmaS0xKSkKICAgICAgICAgICM6 cGhhc2VzCiAgICAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCiAgICAgICAg ICAgIChhZGQtYWZ0ZXIgJ3VucGFjayAnbW92ZS10aGVtZXMKQEAgLTE5ODEzLDEyICsxOTgxNywy MSBAQCBjb250cmFzdCBhbmQgZmV3IGNvbG9ycy4iKQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgKHJlbmFtZS1maWxlIGYgKGJhc2VuYW1lIGYpKSkKICAgICAgICAgICAgICAgICAgICAgICAg ICAoZmluZC1maWxlcyAiLi90aGVtZXMiICIuKlxcLmVsJCIpKQogICAgICAgICAgICAgICAgI3Qp KQotICAgICAgICAgICA7OyBYWFg6IFRoZXJlIGlzIGEgYnl0ZS1jb2RlIG92ZXJmbG93IGlzc3Vl IGluIHRoZSBsYXRlc3QKLSAgICAgICAgICAgOzsgY2hlY2tvdXQgd2hpY2ggYWZmZWN0cyBieXRl LWNvbXBpbGF0aW9uIGZvciBzZXZlcmFsIHRoZW1lCi0gICAgICAgICAgIDs7IGZpbGVzLiBUaGUg ZWFzaWVzdCB3YXkgdG8gd29yayBhcm91bmQgdGhpcyBpcyB0byBkaXNhYmxlCi0gICAgICAgICAg IDs7IGJ5dGUtY29tcGlsYXRpb24gdW50aWwgdGhlIGlzc3VlIGlzIHJlc29sdmVkLgorICAgICAg ICAgICA7OyBUaGVyZSBpcyBhIGJ5dGUtY29kZSBvdmVyZmxvdyBpc3N1ZSBpbiB0aGUgbGF0ZXN0 IGNoZWNrb3V0CisgICAgICAgICAgIDs7IHdoaWNoIGFmZmVjdHMgYnl0ZS1jb21waWxhdGlvbiBm b3Igc2V2ZXJhbCAocmVhZCBgbW9zdCcpIHRoZW1lCisgICAgICAgICAgIDs7IGZpbGVzLiAgSW4g b3JkZXIgdG8gY29wZSB3aXRoIHRoaXMgaXNzdWUsIHdlIGRpc2FibGUKKyAgICAgICAgICAgOzsg Ynl0ZS1jb21waWxhdGlvbiB1bnRpbCBpdCBpcyByZXNvbHZlZC4KICAgICAgICAgICAgOzsgPGh0 dHBzOi8vZ2l0aHViLmNvbS9obGlzc25lci9lbWFjcy1kb29tLXRoZW1lcy9pc3N1ZXMvMzE0Pgot ICAgICAgICAgICAoZGVsZXRlICdidWlsZCkpKSkKKyAgICAgICAgICAgKGFkZC1hZnRlciAnbW92 ZS10aGVtZXMgJ2Rpc2FibGUtYnJlYWtpbmctY29tcGlsYXRpb24KKyAgICAgICAgICAgICAobGFt YmRhIF8KKyAgICAgICAgICAgICAgIChmb3ItZWFjaCAobGFtYmRhIChmaWxlKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGNobW9kIGZpbGUgI282MDApCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAoZW1hY3MtYmF0Y2gtZGlzYWJsZS1jb21waWxhdGlvbiBmaWxlKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAoY29ucyAiZG9vbS10aGVtZXMtZXh0LW5lb3RyZWUuZWwiCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxzZXQtZGlmZmVyZW5jZSBzdHJpbmctY29udGFp bnMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmaW5k LWZpbGVzICIuIiAiLiotdGhlbWUuZWwiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJygic25henp5IiAidG9tb3Jyb3ctZGF5IikpKSkKKyAgICAgICAg ICAgICAgICN0KSkpKSkKICAgICAgIChzeW5vcHNpcyAiV2lkZSBjb2xsZWN0aW9uIG9mIGNvbG9y IHRoZW1lcyBmb3IgRW1hY3MiKQogICAgICAgKGRlc2NyaXB0aW9uICJFbWFjcy1kb29tLXRoZW1l cyBjb250YWlucyBudW1lcm91cyBwb3B1bGFyIGNvbG9yIHRoZW1lcyBmb3IKIEVtYWNzIHRoYXQg aW50ZWdyYXRlIHdpdGggbWFqb3IgbW9kZXMgbGlrZSBPcmctbW9kZS4iKQotLSAKMi4yNC4wCgo= --=-CvGK59/GcDXiE7sr+QzE--