From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56994) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOk64-0006iI-FN for guix-patches@gnu.org; Wed, 15 Apr 2020 11:37:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOk63-0000CD-2C for guix-patches@gnu.org; Wed, 15 Apr 2020 11:37:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOk62-0000Bb-Gx for guix-patches@gnu.org; Wed, 15 Apr 2020 11:37:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOk62-0004Br-Cp for guix-patches@gnu.org; Wed, 15 Apr 2020 11:37:02 -0400 Subject: [bug#36599] [PATCH] gnu: Add node-semver. (Updated) Resent-Message-ID: MIME-Version: 1.0 Date: Wed, 15 Apr 2020 15:36:06 +0000 From: goodoldpaul@autistici.org In-Reply-To: <20200409200150.GQ1518@E5400> References: <20190711121221.16123-1-goodoldpaul@autistici.org> <20200409200150.GQ1518@E5400> Message-ID: Content-Type: multipart/mixed; boundary="=_e3195db86fc34cc545c6e62c16f3cff8" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Efraim Flashner Cc: 36599@debbugs.gnu.org --=_e3195db86fc34cc545c6e62c16f3cff8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed Hi Efraim, > Overall it looks good to me. I also checked npm¹ and it agrees that > there are no dependencies for this package. Do you happen to know why > there's a test directory installed? I don't know if it's supposed to be > there but it seems strange to me I didn't notice and I agree that tests shouldn't be installed but IIUC it's a limitation of the node-build-system that copies recursively the contents of the node_modules directory. I checked and it seems that other packages using the node-build-system have the same problem (i.e. node-color-name install test.js, node-far installs a test directory). One way to fix this could be adding an extra phase (either to each package or in the node-build-system with a special field indicating a list of tests directories) where we delete the test directory from node_modules preventing the copy. On my system I get orang3@frastanato ~/code/guix [env]$ du -sh /gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1 732K /gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1 orang3@frastanato ~/code/guix [env]$ du -sh /gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1/lib/node_modules/semver/test/ 264K /gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1/lib/node_modules/semver/test/ which is not much but amounts nearly to 1/3 of the total disk usage of semver. If you believe that another phase deleting the tests would be better I attached an attempt. Giacomo --=_e3195db86fc34cc545c6e62c16f3cff8 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-Add-node-semver.patch Content-Disposition: attachment; filename=0001-gnu-Add-node-semver.patch; size=2163 RnJvbSA3N2ZmZTdjM2EwYmU4ZTIxNWY0ZjRhZTBiNzgwMzg1ZmZlMzljMWEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHaWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBhdXRpc3RpY2ku b3JnPgpEYXRlOiBXZWQsIDggQXByIDIwMjAgMDA6NTk6MTMgKzAyMDAKU3ViamVjdDogW1BBVENI XSAgZ251OiBBZGQgbm9kZS1zZW12ZXIuCgoqIGdudS9wYWNrYWdlcy9ub2RlLXh5ei5zY20gKG5v ZGUtc2VtdmVyKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9ub2RlLXh5ei5zY20g fCAzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDMy IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbm9kZS14eXouc2NtIGIv Z251L3BhY2thZ2VzL25vZGUteHl6LnNjbQppbmRleCA0NDIzNmVjNDY5Li45MzMyODk2OWU1IDEw MDY0NAotLS0gYS9nbnUvcGFja2FnZXMvbm9kZS14eXouc2NtCisrKyBiL2dudS9wYWNrYWdlcy9u b2RlLXh5ei5zY20KQEAgLTEsNSArMSw2IEBACiA7OzsgR05VIEd1aXggLS0tIEZ1bmN0aW9uYWwg cGFja2FnZSBtYW5hZ2VtZW50IGZvciBHTlUKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBFZnJhaW0g Rmxhc2huZXIgPGVmcmFpbUBmbGFzaG5lci5jby5pbD4KKzs7OyBDb3B5cmlnaHQgwqkgMjAyMCBH aWFjb21vIExlaWRpIDxnb29kb2xkcGF1bEBhdXRpc3RpY2kub3JnPgogOzs7CiA7OzsgVGhpcyBm aWxlIGlzIHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTI0NCwzICsyNDUsMzQgQEAgcHJvdG9j b2wgdXNlZCBpbiBAY29kZXtub2RlLWx5bnh9LiIpCiAgICAgKGRlc2NyaXB0aW9uICJUaGlzIHBh Y2thZ2UgcHJvdmlkZXMgdGhlIE5vZGUuanMgQGNvZGV7dXRpbC5kZXByZWNhdGUoKX0KIGZ1bmN0 aW9uIHdpdGggYnJvd3NlciBzdXBwb3J0LiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkp KQorCisoZGVmaW5lLXB1YmxpYyBub2RlLXNlbXZlcgorICAocGFja2FnZQorICAgIChuYW1lICJu b2RlLXNlbXZlciIpCisgICAgKHZlcnNpb24gIjcuMi4xIikKKyAgICAoc291cmNlIChvcmlnaW4K KyAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICAgICAgICh1cmkgKGdp dC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXRodWIuY29t L25wbS9ub2RlLXNlbXZlci5naXQiKQorICAgICAgICAgICAgICAgICAgICAoY29tbWl0IChzdHJp bmctYXBwZW5kICJ2IiB2ZXJzaW9uKSkpKQorICAgICAgICAgICAgICAoZmlsZS1uYW1lIChnaXQt ZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAg ICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMDZiaWtucWIwNXI5eHNtY2ZsbTN5Z2g1 MHBqdmRrODR4NnI3OXc0M2ttY2s0Zm4zcW41cCIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBub2Rl LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzp0ZXN0cz8gI2YgOzsgRklY TUU6IFRlc3RzIGRlcGVuZCBvbiBub2RlLXRhcAorICAgICAgICM6cGhhc2VzCisgICAgICAgKG1v ZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgKGFkZC1iZWZvcmUgJ2luc3Rh bGwgJ2RlbGV0ZS10ZXN0cy1kaXIKKyAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAg OzsgRGVsZXRlIHRlc3RzIHRvIHByZXZlbnQgaW5zdGFsbGluZyB0aGVtCisgICAgICAgICAgICAg KGRlbGV0ZS1maWxlLXJlY3Vyc2l2ZWx5ICJ0ZXN0IikKKyAgICAgICAgICAgICAoZGVsZXRlLWZp bGUtcmVjdXJzaXZlbHkgInRhcC1zbmFwc2hvdHMiKQorICAgICAgICAgICAgICN0KSkpKSkKKyAg ICAoaG9tZS1wYWdlICJodHRwczovL2dpdGh1Yi5jb20vbnBtL25vZGUtc2VtdmVyIikKKyAgICAo c3lub3BzaXMgIlBhcnNlcyBzZW1hbnRpYyB2ZXJzaW9ucyBzdHJpbmdzIikKKyAgICAoZGVzY3Jp cHRpb24KKyAgICAgIkBjb2Rle25vZGUtc2VtdmVyfSBpcyBhIEphdmFTY3JpcHQgaW1wbGVtZW50 YXRpb24gb2YgdGhlCitAdXJlZntodHRwczovL3NlbXZlci5vcmcvLCBTZW1WZXIub3JnfSBzcGVj aWZpY2F0aW9uLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTppc2MpKSkKLS0gCjIuMjYuMQoK --=_e3195db86fc34cc545c6e62c16f3cff8--