From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id ONuFDI3K8mRNRwAAauVa8A:P1 (envelope-from ) for ; Sat, 02 Sep 2023 07:39:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ONuFDI3K8mRNRwAAauVa8A (envelope-from ) for ; Sat, 02 Sep 2023 07:39:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 996603AA3A for ; Sat, 2 Sep 2023 07:39:24 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=hA9DLfXo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693633165; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bTXbd9ldQZBNzjo1E4FWmK1ZM/56xZbZufeb0VfNsOE=; b=J3RyCEgdOeppjG9WG931g5scEJp14xDZ/wx/9A8KpPVM4ldCdZQfCYhD4x8EwvWjRwngNM eax6fn2Zrqgmwn//6kdo5MpomOZ4HC/dg8t2muEdW/EtTKcpNGCUq3pyxEoFmmuvPPKO01 VCv2PmEsQv2WjKNZ/3cjnUABuGEKMQGKNA4CEKU0gmtJpJjGUyCeg4SwQdxZo3FSQvj0kK iZDpeVXBG3mqGY5wuFvOAWgZFFoNQG76Ohozx0CfMg7xFPUaZyiqD8tUiasD6LKc9lXHkR dknB8o+xwQHMaYBhQB9V/9auoS0bwf8Ka8TbwDAk4PePI1lJ6URxr4VVTom1CA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=hA9DLfXo; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693633165; a=rsa-sha256; cv=none; b=SqDXl2wZl2vYXqJtcFNrjh6jtOMh4R3coleYKjI64yi9Xe1pLDJ17VtHo5JmhSieuBWEkR Z3fiHCqJ+zb+okjPCysSSYmsZuwNL78CKs29ruTfXpj5d4E38PntXmN//LgZq/+AzIb46D KVhVdII681qUcdmdUOidBOwEm2SKWoDPs1zN8ffacXdDuC43cXDPmuC+MDpowTBcfeOKSJ WJINPMSmsaNSVAwYbvCxejHi7gaE3cBR7u0UjiXVkGjm7yqp4xetqnUPxN5JdwiG3uPmHK 3SXdSDOf7TFfepO/E831ybnSOFcnwRbTCVe6SYyFscO1KEyUHwubUKc9OPWBfw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcIji-00020z-0X; Sat, 02 Sep 2023 00:59:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcIjg-0001zg-P6 for guix-patches@gnu.org; Sat, 02 Sep 2023 00:59:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcIjg-0006sK-GP for guix-patches@gnu.org; Sat, 02 Sep 2023 00:59:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcIjp-0008VT-VO for guix-patches@gnu.org; Sat, 02 Sep 2023 01:00:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65668] [PATCH] gnu: gst-plugins-bad: Remove the svt-hevc input. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Sep 2023 05:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Raghav Gururajan , 65668@debbugs.gnu.org Received: via spool by 65668-submit@debbugs.gnu.org id=B65668.169363079032638 (code B ref 65668); Sat, 02 Sep 2023 05:00:01 +0000 Received: (at 65668) by debbugs.gnu.org; 2 Sep 2023 04:59:50 +0000 Received: from localhost ([127.0.0.1]:34844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcIjd-0008UM-SN for submit@debbugs.gnu.org; Sat, 02 Sep 2023 00:59:50 -0400 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]:52429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcIjb-0008Ty-M4 for 65668@debbugs.gnu.org; Sat, 02 Sep 2023 00:59:48 -0400 Received: by mail-ej1-x642.google.com with SMTP id a640c23a62f3a-986d8332f50so336897166b.0 for <65668@debbugs.gnu.org>; Fri, 01 Sep 2023 21:59:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693630772; x=1694235572; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bTXbd9ldQZBNzjo1E4FWmK1ZM/56xZbZufeb0VfNsOE=; b=hA9DLfXocBVdxU8+PZZbWNkL7IFakBhtk3bgk6bquUH/4QN8JTMeCH9ooqzmGZTxeo 44TQ4EIyx2Q5OYrICqAcofiDxQ7wFgHtsKHXeEziKcutN7SbCyiA/YMcT7lyYaRsNAec CsE9l20m99eL52cgPVPy1SrLCRiWDUE/5z3roxY1kummF/Qk/7eEk49Kw6Nhu9/q2se2 XeYOGNbawZjcqEcxGtQVjHxBsad9NVNDXSyqCHVlZdg3QNDP6nAFVodGVFCuOfqdywZZ lDD0FCP8wHVVOy8KwRoWdKcP/feyzkZ6WjpDxBQJqrPJLkIQFhjbVMvfSXYa6soQSLSa xjdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693630772; x=1694235572; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bTXbd9ldQZBNzjo1E4FWmK1ZM/56xZbZufeb0VfNsOE=; b=ZtqDRwZE++hn9Q8m9cJuo92Kr2tA57kNK/ys16sBEslNUZp7u4ts8F0t2brxisDZNc 2MENI8Yb3uYF649/+uBp40BSsZlTPXvSBEHSOdZkpYsW9L1Jxkb+I7PWsMSPfcB+JqO4 cy22TGcQRtzovLl/uPAcDijVhvPpRA7jW7DV2OeR7Lt8aUTHRzNjjCnsrGbpy+9HKyiI Zo6n9aPyFZovXJCa1oyELDYD4LNXswwNoz1HGugrs/qEUOHDN4vygNoTa2Yc1R/uAV3c aU5xhiJPZPmetqG0GWKz6oA4yxuj2aoSbBoselKmNj1sUQhgHRy7xOu9tqZDwlo18Bx6 pd0w== X-Gm-Message-State: AOJu0Ywxaahde7RNEi+/5n4kj9MWa+rkjzZpcNWhc8KEs4+tBiopIDPZ R6IVO8RUZ8g1ZNCuV4LJvNU= X-Google-Smtp-Source: AGHT+IGFvEK6TmD5CGqs8R3OKAP9X5y8n/jDJjoMdbns0ZCAjIg8Xt3vP6lz/fhsRdNbet/M+O7Z7g== X-Received: by 2002:a17:906:186:b0:9a5:9038:b1e7 with SMTP id 6-20020a170906018600b009a59038b1e7mr3121729ejb.36.1693630772049; Fri, 01 Sep 2023 21:59:32 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id i7-20020a170906444700b0099297c99314sm2913762ejp.113.2023.09.01.21.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 21:59:30 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sat, 02 Sep 2023 06:59:29 +0200 In-Reply-To: <878r9p1gxj.fsf@gmail.com> References: <3e0b2b90b037404da7bf9be8932f9b0d69c1a39a.1693537692.git.maxim.cournoyer@gmail.com> <4fa4754ecb68e0e9d7bc72c44229bcc404a5525a.camel@gmail.com> <878r9p1gxj.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.78 X-Spam-Score: 2.78 X-Migadu-Queue-Id: 996603AA3A X-Migadu-Scanner: mx1.migadu.com X-TUID: Xz3rnsmjwEDT Am Freitag, dem 01.09.2023 um 21:51 -0400 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler writes: >=20 > > Am Donnerstag, dem 31.08.2023 um 23:08 -0400 schrieb Maxim > > Cournoyer: > > > * gnu/packages/gstreamer.scm (gst-plugins-bad) > > > [inputs]: Remove svt-hevc; add comment. > > > --- > > > =C2=A0gnu/packages/gstreamer.scm | 4 +++- > > > =C2=A01 file changed, 3 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/gnu/packages/gstreamer.scm > > > b/gnu/packages/gstreamer.scm > > > index 86886c025f..f38d2157bd 100644 > > > --- a/gnu/packages/gstreamer.scm > > > +++ b/gnu/packages/gstreamer.scm > > > @@ -849,7 +849,9 @@ (define-public gst-plugins-bad > > > =C2=A0=C2=A0=C2=A0=C2=A0 (inputs > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (append > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (target-x86?) (list mediasdk= ) '()) > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (target-x86-64?) (list svt-hevc) = '()) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; Note: svt-hevc cannot be used, as = it would break the > > > package for > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; older x86_64 CPUs such as Core 2 D= uo that lack AVX2 > > > (see: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; > > > https://github.com/OpenVisualCloud/SVT-HEVC/issues/573#issuecomment-6= 80678144 > > > ). > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list bluez > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 bzip2 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 cairo > > I think you should put that comment above the commented existing > > line rather than deleting it outright.=C2=A0 We should also look into > > building svt-hevc without those CPU extensions; perhaps using > > tuning instead. >=20 > It's not possible to build svt-hevc without those extensions: they > are depended upon.=C2=A0 Because it can't be used, I think it makes sense > to not leave dead code (since it's not going to be resolved in the > future and re-enabled). Looking at the code of svt-hevc, these additional libraries appear to be just adding versions of the methods already implemented in C. You might want to look into commenting the following lines add_subdirectory(ASM_SSE2) add_subdirectory(ASM_SSSE3) add_subdirectory(ASM_SSE4_1) add_subdirectory(ASM_AVX2) HTH > > The comment could itself be shortened to=C2=A0 > > =C2=A0 svt-hevc is broken on older x86_64 CPUs [such as=E2=80=A6] > > =C2=A0 see also > > but you do you in terms of phrasing :) >=20 > :-)=C2=A0 I've moved things a bit.=C2=A0 Is it a 'LGTM' from you? Well, I'd rather keep the svt-hevc issue above open than concluding it cannot be done, but otherwise, yes, LGTM. Cheers