Re: [PATCH] gnu: Add gnome-sudoku and qqwing

[kei@openmailbox.org]

[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]

On 2016-04-11 00:44, Leo Famulari wrote:
> On Sun, Apr 10, 2016 at 11:23:51PM -0400, kei@openmailbox.org wrote:
>> I'm attempting something new with this patch. I want to add 
>> gnome-sudoku to
>> the tree, and it requires qqwing as a dependency. QQwing didn't seem 
>> to fit
>> in any other category so I put it in it's own file.
>> 
>> Guidance would be appreciated! Thank you in advance.
> 
> Thanks for trying something new :)
> 
> I think they both would fit in games.scm. Can you put them there in a
> revised patch series?
> 

I decided to add gnome-sudoku to gnome.scm because of how a new version
is released with each new version of GNOME. Also, since qqwing seems to
be used only by gnome-sudoku, I moved it over to gnome.scm as well.

>> * gnu/packages/qqwing.scm (qqwing): New variable.
>> * gnu/packages/gnome.scm (gnome-sudoku): New variable.
> 
> We like to add packages as separate commits. Can you separate them in
> the revised patch series?
> 
> Also, remember to add a copyright line for yourself at the top of the
> file.
> 
>> +(define-public gnome-sudoku
> 
> Okay with the changes requested above.
> 
>> +(define-public qqwing
> 
> [...]
> 
>> +              (uri (string-append
>> +                    "mirror://debian/pool/main/q/qqwing/"
>> +                    name "_" version ".orig.tar.gz"))
> 
> Why download the source code from Debian instead of https://qqwing.com
> (which redirects to GitHub)?
> 
I switched to using the link at the bottom of the page.

>> +    (synopsis "Software for working with sudoku puzzles.")
> 
> Can you capitalize Sudoku here? Also be sure to run `guix lint` on 
> these
> packages; the linter should complain about the period in the synopsis.
> 
>> +    (description
>> +     "QQwing is software for generating and solving Sudoku puzzles.")
> 
> Sometimes there isn't much to say. But can you try to add a little more
> here? You could look for inspiration in the man page.

This is as extensive as the descriptions for this software get in its 
own
documentation as well as across many different software repositories. 
Any
ideas for what else to put here?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-gnu-Add-gnome-sudoku.patch --]
[-- Type: text/x-diff; name=0002-gnu-Add-gnome-sudoku.patch, Size: 1993 bytes --]

From cef2c561297399caad3e6fceea9f7299d93e5c04 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Mon, 11 Apr 2016 11:58:34 -0400
Subject: [PATCH 2/2] gnu: Add gnome-sudoku.

* gnu/packages/gnome.scm (gnome-sudoku): New variable.
---
 gnu/packages/gnome.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6ba1fc5..db95c08 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -2229,6 +2229,41 @@ floating in an ocean using only your brain and a little bit of luck.")
      "QQwing is software for generating and solving Sudoku puzzles.")
     (license license:gpl2+)))
 
+(define-public gnome-sudoku
+  (package
+    (name "gnome-sudoku")
+    (version "3.18.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1b60z22fjrjzsz0kfhv0kfhvigzn54wvh9s31zrlp7sx2h2dxvsf"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("desktop-file-utils" ,desktop-file-utils)
+       ("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("xmllint" ,libxml2)))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("json-glib" ,json-glib)
+       ("libgee" ,libgee)
+       ("librsvg" ,librsvg)
+       ("qqwing" ,qqwing)))
+    (home-page "https://wiki.gnome.org/Apps/Sudoku")
+    (synopsis "Japanese logic game")
+    (description
+     "Sudoku is a Japanese logic game that exploded in popularity in 2005.
+GNOME Sudoku is meant to have an interface as simple and unobstrusive as
+possible while still providing features that make playing difficult Sudoku
+more fun.")
+    (license license:gpl2+)))
+
 (define-public gnome-terminal
   (package
     (name "gnome-terminal")
-- 
2.7.3


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0001-gnu-Add-qqwing.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-qqwing.patch, Size: 1770 bytes --]

From ee4d6962a4a9666e026224722c7e8c8f97205e22 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Mon, 11 Apr 2016 11:57:14 -0400
Subject: [PATCH 1/2] gnu: Add qqwing.

* gnu/packages/gnome.scm (qqwing): New variable.
---
 gnu/packages/gnome.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 5c2cf01..6ba1fc5 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 Jochem Raat <jchmrt@riseup.net>
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+;;; Copyright © 2016 Kei Yamashita <kei@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2207,6 +2208,27 @@ and other secrets.  It communicates with the \"Secret Service\" using DBus.")
 floating in an ocean using only your brain and a little bit of luck.")
     (license license:gpl2+)))
 
+(define-public qqwing
+  (package
+    (name "qqwing")
+    (version "1.3.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://qqwing.com/"
+                    name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "0bw0papyqjg22z6irf36gs54y8236wa37b6gyn2h1spy65n76lqp"))))
+    (build-system gnu-build-system)
+    (native-inputs
+      `(("pkg-config" ,pkg-config)))
+    (home-page "https://qqwing.com/")
+    (synopsis "Software for working with Sudoku puzzles")
+    (description
+     "QQwing is software for generating and solving Sudoku puzzles.")
+    (license license:gpl2+)))
+
 (define-public gnome-terminal
   (package
     (name "gnome-terminal")
-- 
2.7.3