From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QGo8KCz4eWbsiQAAqHPOHw:P1 (envelope-from ) for ; Mon, 24 Jun 2024 22:50:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QGo8KCz4eWbsiQAAqHPOHw (envelope-from ) for ; Tue, 25 Jun 2024 00:50:20 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=RpP037rt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719269420; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tC2IGqUP0MS8n/04fN2L2Gi/CjzuoM+mPYmPnqba+s0=; b=MhtqpUSFbOLchxQLm5UAxVqrEH51AQQbXdrF/+FKU6umAjHTDcLSJ82EOCQlmt3+WobZiK l6BMpfOdBPqbZ5JvFQ3h2gMIf0NTwxcNSJRXib/T7eK8CkycupbHB5hnCC972OMKijhxBa SEmgI9iCoo9NP+c8r6gCsV5MKBjde6K2cWDJqWoNgC17n6rUNdJlCRKfgY1YL1l86pWwjm 8+NeSSQ2RUyxZ7MICoBs34+y9xyyOfVDcQ+CxHUXMvEJoCj0h013RBNUCKRO0zTvAkka9M lFsagqRCWGNG7IXS9gcwfobCs88Qw4JnzshMHttZ7dXldrRRgnpuMQYhSIN4tA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719269420; a=rsa-sha256; cv=none; b=IZb69qJAmx9/lD2WaIlfDDydIkgHyB0a0IAAPWSDH8Ml+ZrYBoOmDzCj5P8rkE8jmX0uqa 6fHdGlmPdDn79rQF8hHa64V3eV0b6M14Q0d1xxYrru1VtDZaA5sxKkclcvOL1CK2+BnIqq 8+dWiF3w2DVJbf10qI1CZWL8MjO2EbcHoblOe+Bdgz42vuxUtTdfQC8Feuia+azH3bm7Q5 He87J/sRPptE2Vnr9lC3VE99pBzkUpdYlwp5izATlKPL8n+YI7KuTtuf/davsHMpvxziUQ AVL5rCI2scQjAEbrekWxvKJPIG+f0dVMxndsEZ7ONdMpqNoVHJVtslTtYpXLfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=RpP037rt; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 219D63145E for ; Tue, 25 Jun 2024 00:50:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLsVe-0002Zw-Ka; Mon, 24 Jun 2024 18:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLsVd-0002Zf-3D for guix-patches@gnu.org; Mon, 24 Jun 2024 18:50:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLsVc-0004QP-Rc for guix-patches@gnu.org; Mon, 24 Jun 2024 18:50:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLsVd-0000Pw-On for guix-patches@gnu.org; Mon, 24 Jun 2024 18:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71639] [PATCHv2 0/5] Improve on restic-backup-service Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jun 2024 22:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71639 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71639@debbugs.gnu.org Cc: Richard Sent Received: via spool by 71639-submit@debbugs.gnu.org id=B71639.17192693611545 (code B ref 71639); Mon, 24 Jun 2024 22:50:01 +0000 Received: (at 71639) by debbugs.gnu.org; 24 Jun 2024 22:49:21 +0000 Received: from localhost ([127.0.0.1]:35778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLsUz-0000Oq-2o for submit@debbugs.gnu.org; Mon, 24 Jun 2024 18:49:21 -0400 Received: from confino.investici.org ([93.190.126.19]:28961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLsUw-0000Of-18 for 71639@debbugs.gnu.org; Mon, 24 Jun 2024 18:49:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1719269347; bh=tC2IGqUP0MS8n/04fN2L2Gi/CjzuoM+mPYmPnqba+s0=; h=Date:To:Cc:References:Subject:From:In-Reply-To:From; b=RpP037rtb1DlgDtSRZOjrZfxDCuHpX1gNGQlQSSl/4YolZyrOYETLNWVCcxgrp8Bq +h//TfDJqeG1C/uktQ1sKGESKzIrctj7k/pundyRM7jxSm3YKa8QijM+786zz2INfg 6W5poRAAZVxrsM61GlBkpW5LGO1fYJY9V7hHvFHQ= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4W7NS35zZLz112F; Mon, 24 Jun 2024 22:49:07 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4W7NS35XLyz1127; Mon, 24 Jun 2024 22:49:07 +0000 (UTC) Message-ID: Date: Tue, 25 Jun 2024 00:49:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: paul X-ACL-Warn: , paul via Guix-patches From: paul via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 219D63145E X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.46 X-Spam-Score: -5.46 X-TUID: Ts4GAlAWXiDJ Hi Richard, thank you for this work, it looks really useful and in general I think the patches are ok but I have some points I'd like to discuss. I think it would be nice to have an init action for the restic-guix command shipped with the service and move there the logic for initializing repositories. The service then could be adapted in a way that it would call the restic-guix init before calling restic-guix backup. Would you be interested in implementing this? At last, my use case for having a restic package field for each job is to have some critical jobs that I don't want to touch running with Guix's bootstrapped restic package and some personal jobs that I run with a restic 0.16 binary package I have in my personal channel . I'm not sure this warrants a field in each single job, but they are optional anyway. Anyway I wouldn't consider this a blocker and if the Guix project has some guidelines in this sense I'd say follow them. Cheers, giacomo