From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8NVgJDhcfWTlxAAASxT56A (envelope-from ) for ; Mon, 05 Jun 2023 05:53:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KBRjJDhcfWROFQAA9RJhRA (envelope-from ) for ; Mon, 05 Jun 2023 05:53:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB60E403B7 for ; Mon, 5 Jun 2023 05:53:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q61HE-0002ae-V5; Sun, 04 Jun 2023 23:53:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q61HD-0002aT-5z for guix-patches@gnu.org; Sun, 04 Jun 2023 23:53:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q61HC-0002Vw-TY for guix-patches@gnu.org; Sun, 04 Jun 2023 23:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q61HC-00038l-Fq for guix-patches@gnu.org; Sun, 04 Jun 2023 23:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63877] [PATCH v2] gnu: services: web: Allow specifying extra php-fpm environment variables. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Jun 2023 03:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63877 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timo Wilken Cc: 63877@debbugs.gnu.org Received: via spool by 63877-submit@debbugs.gnu.org id=B63877.168593712612006 (code B ref 63877); Mon, 05 Jun 2023 03:53:02 +0000 Received: (at 63877) by debbugs.gnu.org; 5 Jun 2023 03:52:06 +0000 Received: from localhost ([127.0.0.1]:47669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q61GI-00037a-BP for submit@debbugs.gnu.org; Sun, 04 Jun 2023 23:52:06 -0400 Received: from smtpm5.myservices.hosting ([185.26.105.236]:43618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q61GG-00037R-5F for 63877@debbugs.gnu.org; Sun, 04 Jun 2023 23:52:05 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm5.myservices.hosting (Postfix) with ESMTP id 1140120D25; Mon, 5 Jun 2023 05:52:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 1999B80097; Mon, 5 Jun 2023 05:44:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oFBD1LC2XNHk; Mon, 5 Jun 2023 05:44:38 +0200 (CEST) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 9285B80060; Mon, 5 Jun 2023 05:44:38 +0200 (CEST) Message-ID: Date: Mon, 5 Jun 2023 04:44:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US References: From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685937208; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=rOFP9ai9LkHiggNFxF1UQvv2MizVgpmNtIb9IfnoUYw=; b=tAQD/1JXBL6iabBsnX7Tip9VwMd1v/UXfsw/ESwsJZ4doMRPAK11bvWbUYm+cOLCbZx5XB gejAI6sqef9eTINsfjsXe9IluYzpBm746qqiSBTiPuUV+g9T31yfK6P9hE0Lg+ndyIIVPR 5J6ZXEKFzyOKdhbnxiUU3CileoFy0TnSYj8YpBRII2jCQWuPpTWC935fombL1jtgHKjERy Xr9zFTSBoE7YSKPZj/rGqiGkQmyWY6w5RN9JPNmcCWQCr/d8tymUaZXeABlXmlIuH0mTN1 MyaQIGj7+TrhZz3RhLtef+xrKZ2DKM/tfcl8dfY9BqhK1iMYDld/utIjFwuweA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685937208; a=rsa-sha256; cv=none; b=hgBqkGGQwl2l6yM7KkKpdFIPqljSiiVz3lKmbCzx4SGVyfQXF3jHO8BROLynOshG2ZNn2D kM/6NMyZ323ixCAPTjlGM4r3KuntEHA7ah0JGxE2cL6smOSxMMyDgk1SKHqFSa8HrCNbiV b1z7CQgWG1dNJYtCDwSYyfX8ak7uKOF47pvs6FXLz1F05Yxp4WPa5m5OzUFBpV6NSefvdl lqR98Om1xuoRJGTgS5l5zICVYcQZoVVXZHb5YkDogL7Zs5nXS4Lz9O2b4ZeR1gbJV+ROB7 NKWsyGZmTaH5CeMsMs8dxv3MOYreJhAt+9U1Vle1fWmdlhzhVGx7YBlddSangQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.69 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CB60E403B7 X-Spam-Score: -1.69 X-TUID: 3BMkKicOB2F/ On 2023-06-04 14:59, Timo Wilken wrote: > @@ -1096,6 +1100,9 @@ (define php-fpm-shepherd-service > #$@(if php-ini-file > `("-c" ,php-ini-file) > '())) > + #:environment-variables > + (append #$environment-variables > + (default-environment-variables)) Ungexp-ing lists can be rather tricky since your snippet will expand to: --8<---------------cut here---------------start------------->8--- ... #:environment-variables (append ("FOO=bar" ...) (default-environment-variables)) ... --8<---------------cut here---------------end--------------->8--- Which is interpreted as a procedure call. (and results in a hanged shepherd) You need to quote the list here: --8<---------------cut here---------------start------------->8--- #:environment-variables (append '#$environment-variables (default-environment-variables)) --8<---------------cut here---------------end--------------->8--- Bonus points if you can write a small system test for this. (see gnu/tests/web.scm for inspiration) For our purposes, a pair of HTTP servers where one of them uses a self-signed certificate will suffice. -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno.