From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id QPMdGA4kPWZMCQAAqHPOHw:P1 (envelope-from ) for ; Thu, 09 May 2024 21:29:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id QPMdGA4kPWZMCQAAqHPOHw (envelope-from ) for ; Thu, 09 May 2024 21:29:18 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=a-lec.org header.s=mail header.b=RPpsw3Do; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715282958; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=1Nf8Dir+wXrgGgSsNZ/ZwFt4sQBi7DiaWK+z00Hd+F8=; b=ttBCa4V/xFeMMa32iQ6X+qADYdR0lG8xl7mBUPIvzfqjxV7na2ChomuawIdpYU/jyalOts 2y+jN29wTU3VV7WaUkxsvf5NBqZhXhGhfoJ6pKDravPae88trc6bGTaLlxO8jx+LUewr9u 4yEPsBKjrBlqQciyamsT/zdOffIIOjtLxZMNPvMSrkcX3TjweRPe+IZDIpSWjtYX4gYl9G rRUzWjSU3au5+UV9p1KC42rVmK6ZTnQwAfSDKIogbNro/Y0PJnQuBotCROQLNvxY/OviXT +mAtwoWYKDbv27eXHxn1PRdQtaFAhh5ttQQytawCeXDF926fz3VYhaEXImj7rQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=a-lec.org header.s=mail header.b=RPpsw3Do; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715282958; a=rsa-sha256; cv=none; b=Q6rJJ18d8NkI38ODOEXlH5lASE64IcG0ED8PP3xcA9F1aWtRjyCptdbEND/9WeaOah7KoS ZM84CIV9XMST981BTT59bg0ez7TCe+gWPPiXDddWpkCQEN9mMEubgY/hXdSi25ytzG50W9 5hwj+9IVOjedOLXGGbCXY4A/y7kn21lFkYewp+xyWForl5neP31rFpg1SvCGJbvD4fngJg RY0kTbL6QyC1gzoRJyUt78Q/hnlj3PPGUsX+TxSSTPGjnLt5OiWxTVdrTis09faniyJMQ8 hQOPUlb1tFsuTi2KGMfm+mXF4L8KD6N5MrTAZKYliRiLugoxhmYn7CjRLJnKfA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED1126132F for ; Thu, 9 May 2024 21:29:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s59Ry-00086r-Li; Thu, 09 May 2024 15:29:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s59Rw-00083W-GZ for guix-patches@gnu.org; Thu, 09 May 2024 15:29:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s59Rw-0000OV-7s for guix-patches@gnu.org; Thu, 09 May 2024 15:29:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s59Ru-0000fF-FJ for guix-patches@gnu.org; Thu, 09 May 2024 15:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70845] [PATCH] services: Add fancontrol-service-type Resent-From: Adrien 'neox' Bourmault Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 May 2024 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70845@debbugs.gnu.org Cc: Denis 'GNUtoo' Carikli Received: via spool by 70845-submit@debbugs.gnu.org id=B70845.17152829212545 (code B ref 70845); Thu, 09 May 2024 19:29:02 +0000 Received: (at 70845) by debbugs.gnu.org; 9 May 2024 19:28:41 +0000 Received: from localhost ([127.0.0.1]:40816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s59RZ-0000ez-6e for submit@debbugs.gnu.org; Thu, 09 May 2024 15:28:41 -0400 Received: from leparc.libre-en-communs.org ([80.67.176.33]:60024 helo=a-lec.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s59RV-0000et-6Y for 70845@debbugs.gnu.org; Thu, 09 May 2024 15:28:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=a-lec.org; s=mail; t=1715282885; bh=1Nf8Dir+wXrgGgSsNZ/ZwFt4sQBi7DiaWK+z00Hd+F8=; h=Subject:From:To:Cc:In-Reply-To:References:Date:From; b=RPpsw3Do3PdqqPoWAz6qCKLU6sRiUCEBzlgFgBWtUcne1/X6ooXoUfYBaaggbHo2i Szx4xkgv1BWkl6YxWWWzDVW0mdXvC9t3zEiVys3yZhOewtTybzK4hatMVpUzQy1Ima LmJpNMzSjsw7pJjP6MpC6ygWE5m5kVqJIUP6GGx7raDqLW6cLNO2cqjYBHmmg9L3EK pEkxcVV5wZsWngUQ03Dws7CE/ZXcMQBHXD+5oxXXy7rUWYB07gV6VFmGTNxwGPWicY wZf5wkUNWK5FjZh4o9uqs9MOU0VEhb/4YRhYdi5gN7qLr2uA8vWj0IdVWx1jVi3w3j fr7jwfV3myxqw== Received: from n-guix-fix-2.home (2a01cb0803b54e0031dab61d4c18e856.ipv6.abo.wanadoo.fr [IPv6:2a01:cb08:3b5:4e00:31da:b61d:4c18:e856]) (Authenticated sender: neox) by mail.a-lec.org (Postfix) with ESMTPSA id D40AB8095E; Thu, 9 May 2024 21:28:05 +0200 (CEST) Message-ID: In-Reply-To: <20240509193942.20e6ec8e@primary_laptop> References: <20240509193942.20e6ec8e@primary_laptop> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-fgR0EYVxCEf0ZgUh2cvn" Date: Thu, 09 May 2024 21:28:02 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.48.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adrien 'neox' Bourmault X-ACL-Warn: , Adrien 'neox' Bourmault via Guix-patches From: Adrien 'neox' Bourmault via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.41 X-Spam-Score: -8.41 X-Migadu-Queue-Id: ED1126132F X-Migadu-Scanner: mx13.migadu.com X-TUID: lWsRO32dsiRX --=-fgR0EYVxCEf0ZgUh2cvn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 09 mai 2024 =C3=A0 19:39 +0200, Denis 'GNUtoo' Carikli a =C3=A9cri= t=C2=A0: > Hi, >=20 > Thanks a lot for the patch. >=20 > For the record I'm not a Guix maintainer / committer, and that I > didn't look at everything but I spotted something that could be > improved: the user has no way to override the lm-sensors package being > used. >=20 > Most services provide a way to do that kind of override, so it would > make sense to add that at some point. >=20 > Denis. Hi and thanks for you feedback. Not every service I saw allows such overrid= e, but it seems indeed a good idea. However, it would complicate a bit this pa= tch as it would require to create a proper configuration type for the service a= nd I also did not dig into that (did not have much time). Someone else might be = able to do it. Happy hacking! --=20 Adrien Bourmault Maintainer, GNU Boot project Associate member, Free Software Foundation GPG : 393D4CC68136F39799DA75F295F65F55F682A17A --=-fgR0EYVxCEf0ZgUh2cvn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQ5PUzGgTbzl5nadfKV9l9V9oKhegUCZj0jvQAKCRCV9l9V9oKh emnAAQCKZsuPXxvAHUTyOasO6pPsABwyWiIk1oiyrxN5mK4i3wD+OlXilD4SYdjW yV3V4L+9DyUYsbh+Zmz+EZtelQ5SQwk= =OUk2 -----END PGP SIGNATURE----- --=-fgR0EYVxCEf0ZgUh2cvn--