From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WHo/IOVqtmHEWAAAgWs5BA (envelope-from ) for ; Sun, 12 Dec 2021 22:34:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GAjTG+VqtmGeAwAAbx9fmQ (envelope-from ) for ; Sun, 12 Dec 2021 21:34:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2392710D28 for ; Sun, 12 Dec 2021 22:34:29 +0100 (CET) Received: from localhost ([::1]:57422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwWUG-0007EZ-BH for larch@yhetil.org; Sun, 12 Dec 2021 16:34:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwWTq-0007E0-JM for guix-patches@gnu.org; Sun, 12 Dec 2021 16:34:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwWTq-0001Nr-AN for guix-patches@gnu.org; Sun, 12 Dec 2021 16:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwWTq-0004CU-90 for guix-patches@gnu.org; Sun, 12 Dec 2021 16:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v3 26/43] gnu: Add node-nan. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Dec 2021 21:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 51838@debbugs.gnu.org X-Debbugs-Original-Cc: 51838@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163934480216064 (code B ref 51838); Sun, 12 Dec 2021 21:34:02 +0000 Received: (at 51838) by debbugs.gnu.org; 12 Dec 2021 21:33:22 +0000 Received: from localhost ([127.0.0.1]:53325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWTC-0004B2-4d for submit@debbugs.gnu.org; Sun, 12 Dec 2021 16:33:22 -0500 Received: from mail-ua1-f51.google.com ([209.85.222.51]:33763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwWT9-0004Ao-Qr for 51838@debbugs.gnu.org; Sun, 12 Dec 2021 16:33:20 -0500 Received: by mail-ua1-f51.google.com with SMTP id a14so26173304uak.0 for <51838@debbugs.gnu.org>; Sun, 12 Dec 2021 13:33:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Fh0n71o0yBejAfFYUu8ZkIT5wWTgB7nmIsZAs4iFpmA=; b=QBOQw8P7a3zV/7FF4lfmFeFy9Eoi4NMu5YQ1dF8EzwxT/wwfnvymaCYIqyw7sIDcVi GTO/6gQ5L5dYzsbnZQDK82zpVYxR3F4C15/A+RaR7P1pTSgVG3keZmdbM6NSK7ZVfQGR PrQnzm2jP6FJoR+N6v1h9KVODwecVNTjdGVU85NEvj7fBWF/6mKbYc0nlOZR/A3lz5T7 2h1LDHbi/GjchWZNQw7BeiCHez8lLI81w/2q8YkRMtaLzKY3tH1k2sKdVHznBSVSwM7w Apwme5CfMwBlimMgKNvv66WdTIHzsGDy1qDvBte6V/FDWTe/B0y2Z1HD6XyVUmkhjREH fDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Fh0n71o0yBejAfFYUu8ZkIT5wWTgB7nmIsZAs4iFpmA=; b=zMYQb1NyJ0iIlECY4UCPdOPuixW9je2EVlYerB0jCik41HcH/H7+FGj1DeR7S1lIi4 EPUIof9xIx7fosyFBp4ULn1Ef5ya4JSaOeVfh2NDfCF8bm5+HbLlN90e2X5elwPVGjcy 7uM2kXQ4ahi0Lbe2zXG6tArVYyEJHjdaQIU4zd8wGSVuQw84wonvjJjgrtL/bHaH2BmL Y4iWbYSTyZCZVQJZBqK7t+szsQ5Ka9bA/jmSwhC5hSIDmxGX4OqyWykb9C1tVTB0AOFN M/kCjajFQOU6pmFvmkdtJ7rKBu5HkcVKiMI0qnnDvqkhGzVvumu1CDGfDvYFd3+Knaeu ZiDA== X-Gm-Message-State: AOAM533DfFt6WEACyHM+h3bZv3BhbkvJ/OgyUPfvYshf+78XzJEJbBQc whvVFDkw6dQ/dUVFMEOdIdt8BA== X-Google-Smtp-Source: ABdhPJwj9MLBPAB9LFxh/z/lKKSOTHFRTczSfOSEBe1bBMEhn319WQxcaJRz672NxSW57KpkHv8hcw== X-Received: by 2002:a67:2dd7:: with SMTP id t206mr22463350vst.62.1639344794288; Sun, 12 Dec 2021 13:33:14 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id s13sm3602749vkh.32.2021.12.12.13.33.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Dec 2021 13:33:14 -0800 (PST) Message-ID: Date: Sun, 12 Dec 2021 16:33:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <46a042bc08eb72a068b1e8c69bfe28cf2d4b2e53.camel@gmail.com> <20211208202838.752542-1-philip@philipmcgrath.com> <20211208202838.752542-27-philip@philipmcgrath.com> <87bl1lyeo3.fsf@gmx.com> From: Philip McGrath In-Reply-To: <87bl1lyeo3.fsf@gmx.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639344869; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Fh0n71o0yBejAfFYUu8ZkIT5wWTgB7nmIsZAs4iFpmA=; b=kDmWqkLgdprO1+rC4urCcirvwU1RpmvZRrsDPCVsFeLtLVNBpNontiNqE4pG/Ji1iprmuL IaTu5kHcqLZJtcekJV23PenYbMfohko16qTYY9/P95vjOj52707OtcLy8kO7HGGnRSn0SQ X3/HLuxTHOBbs/EZRwSNKEPLwCmKb0+7YuQueCsSSTDsM5E9vVkhrPxaO73nYL+yHLmEMM 8NIPsq7eJjYDdzhK6hwkVPCs+Kwydmcb5FcdX/LNejFGM1Vnen2eK765fvdDPCqqd+mQTv SrBX5nqVj59/jucV+rjA75SU7iozJ4ZNTcke+f+WAhjwJWRvVsSSBoXYxcVEAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639344869; a=rsa-sha256; cv=none; b=IdF+iy9PdB+J5awGEVc3Ax0vaB6C84tIOp4uXgMse7aBzES7/HX8F50EQr2at/sMPdGqAb guXSiCc70l5Iw77t3w9Fy7EL6qLqC/JZZ27gkRxafjFxPNjzH5UlntnhJELYY09f5K0aMf gO+R2DRYR1op/H67pOTc23Q0brA+W/jywCT9SjobS9mNVj9WsuwS1qZiLwr/c8iraYp0vf oUReyU3fVy5q2GIx82SKTnVAyLy1S4Hm0a6V/H//GaidjyyScZUhsyHDw9wzb8LagsopJc /0P84PPwvHQX9y9bnVQhb5damXw5aifCYYqOCsJx9F424ny/VtD/pkIv0E5VJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=QBOQw8P7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=QBOQw8P7; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2392710D28 X-Spam-Score: -1.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: x+tFDIrw/uMQ On 12/12/21 11:17, Pierre Langlois wrote: > > Philip McGrath writes: > >> * gnu/packages/node-xyz.scm (node-nan): New variable. >> --- >> gnu/packages/node-xyz.scm | 44 +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/gnu/packages/node-xyz.scm b/gnu/packages/node-xyz.scm >> index 3e06413908..ed169c0778 100644 >> --- a/gnu/packages/node-xyz.scm >> +++ b/gnu/packages/node-xyz.scm >> @@ -553,3 +553,47 @@ (define-public node-irc >> (description "@code{node-irc} is an IRC client library for Node.js. >> It has functions for joining, parting, talking, and many other IRC commands.") >> (license license:gpl3+))) >> + >> +(define-public node-nan >> + (package >> + (name "node-nan") >> + (version "2.15.0") >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/nodejs/nan") >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "18xslh9va5ld872scrp5y4251ax9s3c6qh0lnl1200lpzbsxy7yd")))) >> + (build-system node-build-system) >> + (arguments >> + `(#:tests? >> + ;; tests need tap and other dependencies >> + #f > > Formatting nit, you can write this all in one line: > > #:tests? #f ;; Tests need tap an other dependencies. Yes, I'll do that. It causes problems for automatic indentation if it's the first line, but I can put it after #:absent-dependencies, as I started doing elsewhere. > >> + #:absent-dependencies >> + '("bindings" >> + "commander" >> + "glob" >> + "request" >> + "node-gyp" ;; would be needed for tests >> + "tap" >> + "xtend"))) >> + (inputs >> + `(("readable-stream" ,node-readable-stream))) >> + (home-page "https://github.com/nodejs/nan") >> + (synopsis "Native Abstractions for Node.js") >> + (description "A header file filled with macro and utility goodness for >> +making add-on development for Node.js easier across versions 0.8, 0.10, 0.12, >> +1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 and 16. > > Given our packages only work with the node what Guix uses, you could > remove the version numbers from the description. Mostly because we > probalby won't think to update this description when future node > releases appear. > >> + >> +Thanks to the crazy changes in V8 (and some in Node core), keeping native >> +addons compiling happily across versions, particularly 0.10 to 0.12 to 4.0, is >> +a minor nightmare. > > I'd remove this sentence, it doesn't make much sense in Guix given we > don't support older versions. Both of these seem like good changes to me. (Personally, I think a lot of complexity in JavaScript land comes from trying to support obsolete versions of things.) -Philip