From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MCsiLdfg4WE/2wAAgWs5BA (envelope-from ) for ; Fri, 14 Jan 2022 21:45:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gOV0Ktfg4WFKigAA9RJhRA (envelope-from ) for ; Fri, 14 Jan 2022 21:45:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 566D4A27D for ; Fri, 14 Jan 2022 21:45:11 +0100 (CET) Received: from localhost ([::1]:41616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8TRe-0007vZ-Do for larch@yhetil.org; Fri, 14 Jan 2022 15:45:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8TNi-0007u3-MN for guix-patches@gnu.org; Fri, 14 Jan 2022 15:41:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45426) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8TNe-0005ZN-Eh for guix-patches@gnu.org; Fri, 14 Jan 2022 15:41:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8TNe-0004kN-CH for guix-patches@gnu.org; Fri, 14 Jan 2022 15:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53222] [PATCH] gnu: autokey fix paths. References: In-Reply-To: Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Jan 2022 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53222 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 53222@debbugs.gnu.org, Nicolas Goaziou Received: via spool by 53222-submit@debbugs.gnu.org id=B53222.164219282318169 (code B ref 53222); Fri, 14 Jan 2022 20:41:02 +0000 Received: (at 53222) by debbugs.gnu.org; 14 Jan 2022 20:40:23 +0000 Received: from localhost ([127.0.0.1]:38323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8TN0-0004iy-TS for submit@debbugs.gnu.org; Fri, 14 Jan 2022 15:40:23 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:18089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8TMz-0004ij-IF for 53222@debbugs.gnu.org; Fri, 14 Jan 2022 15:40:22 -0500 Date: Fri, 14 Jan 2022 20:40:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1642192814; bh=enogcmI6Q8hZNnPGOAnII5CypLjIfdZuhrM94TrTqE8=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:From:To:Cc; b=Zz+/09AUw9zWaz5CdCpJCbGWSjF2KUJKYTy4UMG+Xwyq87CCTTG3XiOmmjhdiO0p7 f8ZtXw3KCxdooi51VkCeacy0HW9jDXPNKqYI0y+QtCa1skEDIXQTMYy5MM/im6hcWy 7ica+Q2tcFv/ge3bkpA/NfBZpuJGQE6q7Eo2ZprFlGtfdv7q546t/eRasYLz03TbS/ e9AoPqOf0etX8rfhc/nkMELKsf9363JyYkbYMDvHxqIiGzwrCroIrhdak5x31Xvpvn ZlFi8KvGxdsqpSx9UGWxk7kZB90xwEciRQ26jSW7de+zYFkHPN3vkVQUTLOfzO7Y0c UutbGGviiS7Vg== Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_b9emaUPAOdJSVfebTN4v6mTuDVDbx1KTtpoCbDnc" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642193111; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=enogcmI6Q8hZNnPGOAnII5CypLjIfdZuhrM94TrTqE8=; b=GJQnC0lc0nONNwATGt+Xo5h6cDdEY7Xmh3Gu22UQsiZlCY0lclWE39YZl5lQGkypuURp8+ f6MxrtyOKc+zfEi7RclxcdnL7n+JTiqrWRqgbD8uJDdp888QZrlLqOXm9FwqcLD2UK9BkF lXT1Q8O+1Xh/CppwUdgR7fLKNdH7BaX+fpohFOmAgQNSMdAuTV467MStkF7XmcNmB9s1Z/ Wfyv1HNrds0lQCgIttwtUavk5/khy6wxGn+fWQGn8WsSnkKcLUPBCstfeX36x0k0Z7xEA7 h7Z5iFOk+MduFE100MW8R+htcba6JZXt0O4zFtXen+ot5sbXOK9iUmzbJawPFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642193111; a=rsa-sha256; cv=none; b=D17YZbOQwEwb6kx8FmeaCIOvBk0PKkBQQr4xmLyGo+DwYsm6awSqscO/87cT4XlemMhjlX QCitrKkabpPP1jZDc0cuHv7MeXJIVHBvmXhyEJY+hrfI9WaJl+SjAhytM8FmSjFnTk7ihN fV83iWw9PM+kz9PLezGja04lKiKAIAgf3ivwY05baKjfHMSXKlTCa7NNo2II+CmfZYumP9 6Gz9TqaF8CTLk18ZNWukQofnKJqjJFkDoXKSZ6jJelyayPKUHWOZoYkJO09ftL4r0BYC7l WP6lI+ApXzYBu6nDpQvnnXn5VhZf9goPBM9QDL0EApGJ0oqSkyG/MJ/Y26DERQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b="Zz+/09AU"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b="Zz+/09AU"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 566D4A27D X-Spam-Score: -3.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZNlg9KfCjAx8 This is a multi-part message in MIME format. --b1_b9emaUPAOdJSVfebTN4v6mTuDVDbx1KTtpoCbDnc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Maxime, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Thursday, January 13th, 2022 at 2:34 AM, Maxime Devos wrote: >> I can submit a patch to change the wrap and inputs if that would be clea= ner. > > * Maybe you make the GUIX_PYTHONPATH wrapping explicit (e.g. by > removing the wrap phase, or moving the 'wrap-autokey' phase before > the 'wrap', or letting it replace the 'wrap' phase), adding a comment > > ;; Use 'prefix' instead of '=3D' to allow the user to use additional > ;; Python libraries from their autokey scripts. > * or maybe don't do that, but still add a similar comment to the 'wrap' > phase. > * Could you make the comment next to #:tests? a bit more explicit? > Okay, I hope I understood correctly, attached is a patch with these updates= (on top of the already applied originally package addition). I noticed that autokey-shell had calls to ipython3 (or python3) that should= have been substituted, so I did that with the added input for ipython3. Added the comment about the tests and GI_TYPELIB_PATH. Note that this is th= ere because otherwise the gtk pieces won't run as it needs the girepository= (I think this is also the reason this is done in most cases?). I did add t= he comment you suggested so it is clear this is prefix in case there are ot= her GI paths a user wants, and that the GUIX_PYTHONPATH wrapping is done by= python-build-system already. Thanks again! John --b1_b9emaUPAOdJSVfebTN4v6mTuDVDbx1KTtpoCbDnc Content-Type: text/x-patch; name=0001-gnu-autokey-Fix-paths.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-autokey-Fix-paths.patch RnJvbSBhZWM0NzMyY2FjN2UyMzk1OTBjN2JiODU2NDlmZDk5ZjZiZTJkNDc1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2huIEtlaGF5aWFzIDxqb2huLmtlaGF5aWFzQHByb3Rvbm1h aWwuY29tPgpEYXRlOiBGcmksIDE0IEphbiAyMDIyIDE1OjI2OjM2IC0wNTAwClN1YmplY3Q6IFtQ QVRDSF0gZ251OiBhdXRva2V5OiBGaXggcGF0aHMuCgoqIGdudS9wYWNrYWdlcy9weXRob24teHl6 LnNjbSAoYXV0b2tleSk6IEFkZCBjb21tZW50cyBvbiB0aGUgZGlzYWJsZWQgdGVzdHMKYW5kIEdJ X1RZUEVMSUJfUEFUSCB3cmFwcGluZy4KW2lucHV0c106IEFkZCBpcHl0aG9uLgpbcGhhc2VzXXtm aXgtcGF0aHN9OiBVc2UgcGF0aHMgdG8gaXB5dGhvbjMgYW5kIHB5dGhvbjMgaW4gYXV0b2tleS1z aGVsbApzY3JpcHQuCnt3cmFwLWF1dG9rZXl9OiBDaGFuZ2UgbmFtZSB0by4uLgp7d3JhcC1hdXRv a2V5LWdpfTogLi4udGhpcyBhbmQgbW92ZSB0byBiZWZvcmUgd3JhcCBmb3IgY2xhcml0eS4KLS0t CiBnbnUvcGFja2FnZXMvcHl0aG9uLXh5ei5zY20gfCAyNiArKysrKysrKysrKysrKysrKystLS0t LS0tLQogMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3B5dGhvbi14eXouc2NtIGIvZ251L3BhY2thZ2VzL3B5 dGhvbi14eXouc2NtCmluZGV4IGI4NTIzMmYyYjcuLjdlYzY3MWE0NzYgMTAwNjQ0Ci0tLSBhL2du dS9wYWNrYWdlcy9weXRob24teHl6LnNjbQorKysgYi9nbnUvcGFja2FnZXMvcHl0aG9uLXh5ei5z Y20KQEAgLTQxOTcsNyArNDE5Nyw5IEBAIChkZWZpbmUtcHVibGljIGF1dG9rZXkKICAgICAoYnVp bGQtc3lzdGVtIHB5dGhvbi1idWlsZC1zeXN0ZW0pCiAgICAgKGFyZ3VtZW50cwogICAgICAobGlz dAotICAgICAgIzp0ZXN0cz8gI2YgOyBUZXN0cyBhcmUgZGVwcmVjYXRlZC9icm9rZW4gdW50aWwg bmV4dCB2ZXJzaW9uLgorICAgICAgOzsgVGVzdHMgYXJlIGRlcHJlY2F0ZWQgYW5kIGJyb2tlbiB1 bnRpbCBuZXh0IHZlcnNpb24sIHNlZQorICAgICAgOzsgaHR0cHM6Ly9naXRodWIuY29tL2F1dG9r ZXkvYXV0b2tleS9pc3N1ZXMvMzI3CisgICAgICAjOnRlc3RzPyAjZgogICAgICAgIzpwaGFzZXMK ICAgICAgICN+KG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcwogICAgICAgICAgIChhZGQt YWZ0ZXIgJ3VucGFjayAnZml4LXBhdGhzCkBAIC00MjA2LDggKzQyMDgsMTYgQEAgKGRlZmluZS1w dWJsaWMgYXV0b2tleQogICAgICAgICAgICAgICAgICgoIlwid21jdHJsXCIiKQogICAgICAgICAg ICAgICAgICAoc3RyaW5nLWFwcGVuZCAiXCIiIChzZWFyY2gtaW5wdXQtZmlsZSBpbnB1dHMgImJp bi93bWN0cmwiKSAiXCIiKSkKICAgICAgICAgICAgICAgICAoKCJcInplbml0eVwiIikKLSAgICAg ICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIlwiIiAoc2VhcmNoLWlucHV0LWZpbGUgaW5wdXRz ICJiaW4vemVuaXR5IikgIlwiIikpKSkpCi0gICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFsbCAn d3JhcC1hdXRva2V5CisgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kICJcIiIgKHNlYXJj aC1pbnB1dC1maWxlIGlucHV0cyAiYmluL3plbml0eSIpICJcIiIpKSkKKyAgICAgICAgICAgICAg KHN1YnN0aXR1dGUqICJhdXRva2V5LXNoZWxsIgorICAgICAgICAgICAgICAgICgoIidpcHl0aG9u MyciKQorICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAiJyIgKHdoaWNoICJpcHl0aG9u MyIpICInIikpCisgICAgICAgICAgICAgICAgKCgiJ3B5dGhvbjMnIikKKyAgICAgICAgICAgICAg ICAgKHN0cmluZy1hcHBlbmQgIiciICh3aGljaCAicHl0aG9uMyIpICInIikpKSkpCisgICAgICAg ICAgOzsgVXNlICdwcmVmaXgnIGluc3RlYWQgb2YgJz0nIHRvIGFsbG93IHRoZSB1c2VyIHRvIHVz ZSBhZGRpdGlvbmFsCisgICAgICAgICAgOzsgR0kgcGF0aHMgZnJvbSB0aGVpciBhdXRva2V5IHNj cmlwdHMuICBHVUlYX1BZVEhPTlBBVEggaXMgYWxyZWFkeQorICAgICAgICAgIDs7IHdyYXBwZWQg d2l0aCBwcmVmaXggaW4gcHl0aG9uLWJ1aWxkLXN5c3RlbSdzIHdyYXAuCisgICAgICAgICAgKGFk ZC1iZWZvcmUgJ3dyYXAgJ3dyYXAtYXV0b2tleS1naQogICAgICAgICAgICAgKGxhbWJkYSBfCiAg ICAgICAgICAgICAgIChsZXQgKChnaS10eXBlbGliLXBhdGggKGdldGVudiAiR0lfVFlQRUxJQl9Q QVRIIikpKQogICAgICAgICAgICAgICAgIChmb3ItZWFjaApAQCAtNDIyMywxNCArNDIzMywxNCBA QCAoZGVmaW5lLXB1YmxpYyBhdXRva2V5CiAgICAgICAgICAgIGd0a3NvdXJjZXZpZXctMwogICAg ICAgICAgICBsaWJhcHBpbmRpY2F0b3IKICAgICAgICAgICAgbGlibm90aWZ5Ci0gICAgICAgICAg IHdtY3RybAotICAgICAgICAgICB6ZW5pdHkpKQotICAgIChwcm9wYWdhdGVkLWlucHV0cwotICAg ICAobGlzdCBweXRob24tZGJ1cworICAgICAgICAgICBweXRob24tZGJ1cworICAgICAgICAgICBw eXRob24taXB5dGhvbgogICAgICAgICAgICBweXRob24tcHlnb2JqZWN0CiAgICAgICAgICAgIHB5 dGhvbi1weWlub3RpZnkKICAgICAgICAgICAgcHl0aG9uLXB5cXQrcXNjaW50aWxsYQotICAgICAg ICAgICBweXRob24teGxpYikpCisgICAgICAgICAgIHB5dGhvbi14bGliCisgICAgICAgICAgIHdt Y3RybAorICAgICAgICAgICB6ZW5pdHkpKQogICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHVi LmNvbS9hdXRva2V5L2F1dG9rZXkiKQogICAgIChzeW5vcHNpcwogICAgICAgIktleWJvYXJkIGFu ZCBHVUkgYXV0b21hdGlvbiB1dGlsaXR5IikKLS0gCjIuMzQuMAoK --b1_b9emaUPAOdJSVfebTN4v6mTuDVDbx1KTtpoCbDnc--