From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:33933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioely-0006Vt-81 for guix-patches@gnu.org; Mon, 06 Jan 2020 21:39:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioelw-0002GK-0X for guix-patches@gnu.org; Mon, 06 Jan 2020 21:39:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioelq-0002Bu-71 for guix-patches@gnu.org; Mon, 06 Jan 2020 21:39:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ioelq-0002LS-4e for guix-patches@gnu.org; Mon, 06 Jan 2020 21:39:02 -0500 Subject: [bug#38965] [PATCH 00/12] gnu: coq: Update to 8.10.2. Resent-Message-ID: Date: Tue, 7 Jan 2020 02:38:20 +0000 (UTC) From: Brett Gilio Message-ID: In-Reply-To: <2E36EFCF-C7C0-442B-8F03-46CC3167DA92@lepiller.eu> References: <874kx9xa9u.fsf@gnu.org> <53E54994-18D2-4D82-8E96-3D6E8A3A9D14@lepiller.eu> <87o8vgm37i.fsf@gnu.org> <2E36EFCF-C7C0-442B-8F03-46CC3167DA92@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 38965@debbugs.gnu.org Jan 6, 2020 8:35:23 PM Julien Lepiller : > Le 6 janvier 2020 21:04:49 GMT-05:00, Brett Gilio a =C3=A9crit : > > > Julien Lepiller writes: > > > > > > > Le 6 janvier 2020 03:24:29 GMT-05:00, Brett Gilio a > > > > > =C3=A9crit : > > > > > > > > > > > > > > > > > > > Looks like lablgtk2 -> ocaml-cairo2 -> lablgtk3 so we can't get rid > > > > > of lablgtk2. Are we sure we need it though? > > > > > > > > In general, make sure to run guix lint on these patches, I could spot > > > > > missing double spaces in descriptions of the first two for instance. > > > > The OPAM page for cairo2 does not mention needing lablgtk2. So, if that > > is the case I imagine we could be fine deprecating it in favor of > > lablgtk3. > > > > I forgot to lint those who packages, yes. I can change those before > > pushing them. How does everything else look? > > > > The rest looks pretty good :). The introduction of (gnu packages autotool= s) is too late though, it should be added on the first patch that needs it = (5 I think). > Right. My mistake. Consider it done. I will revise the issues, and double/t= riple check everything and push. --=20 Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]