From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aLxbJd+wcGBDJQAAgWs5BA (envelope-from ) for ; Fri, 09 Apr 2021 21:54:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id Yl1SH9+wcGA6IgAA1q6Kng (envelope-from ) for ; Fri, 09 Apr 2021 19:54:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 380F486FF for ; Fri, 9 Apr 2021 21:54:07 +0200 (CEST) Received: from localhost ([::1]:42114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUxCg-0002sx-Cd for larch@yhetil.org; Fri, 09 Apr 2021 15:54:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUxCc-0002sr-Pj for guix-patches@gnu.org; Fri, 09 Apr 2021 15:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUxCc-0004ow-Gd for guix-patches@gnu.org; Fri, 09 Apr 2021 15:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lUxCc-0001lU-FI for guix-patches@gnu.org; Fri, 09 Apr 2021 15:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47643] [PATCH staging 07/10] gnu: gst-plugins-bad: Update to 1.18.4. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 09 Apr 2021 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Maxime Devos , 47643@debbugs.gnu.org Cc: rg@raghavgururajan.name, leo@famulari.name Received: via spool by 47643-submit@debbugs.gnu.org id=B47643.16179980246756 (code B ref 47643); Fri, 09 Apr 2021 19:54:02 +0000 Received: (at 47643) by debbugs.gnu.org; 9 Apr 2021 19:53:44 +0000 Received: from localhost ([127.0.0.1]:50996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUxCK-0001ku-FL for submit@debbugs.gnu.org; Fri, 09 Apr 2021 15:53:44 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:33819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lUxCH-0001kh-Oc for 47643@debbugs.gnu.org; Fri, 09 Apr 2021 15:53:43 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FH82T3Z6bz1LBRt; Fri, 9 Apr 2021 21:53:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FH82T3Z6bz1LBRt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1617998018; bh=AS7v1x+Mykx4czuNjRt/RByJi5b5EGU1OIjnoB1H0kg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=QchSGcS9DfKTtK7HN4EK/j2yC17ohOB7Bf/eyK9vlztJ8roi7nvnahdtPCxsvEBDk Hq96/UZG8O1LaUg7CWGPp0tFAnOZlvJQtlz7cSgqVdJfxdmsaNB/VUEr6XGSFnGNcp legP4cD1NOGjgTANaz7uNx2xmOmyzz6H9nH1vPi8= Message-ID: From: Leo Prikler Date: Fri, 09 Apr 2021 21:53:36 +0200 In-Reply-To: <725add4bac2875c6ee8dc600c2dc8f7a22f9d7ea.camel@telenet.be> References: <20210409183900.24175-1-leo.prikler@student.tugraz.at> <20210409183900.24175-8-leo.prikler@student.tugraz.at> <725add4bac2875c6ee8dc600c2dc8f7a22f9d7ea.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617998047; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AS7v1x+Mykx4czuNjRt/RByJi5b5EGU1OIjnoB1H0kg=; b=LnxHA1pDqZqiF/NN02w6ixLNTsOI1uztFe4PyPYtjGoV1EbE/Ez5AsEt5gPcVGBsOUAgoK 6l0PoGnAPsFkMXap0LB2oiKyUPoDpp4rWxDQS/A35Pq0xMp3B8qxS/gxMpZfaz3cCMIWfM w/qhWYveFSdYuTD0jlx+GdiPqJ1bdZcZ6wXT7BtkOI2RpZEWouwHmpDpNfyeJL0eXI2Tti nBB/cIyU3cHylNENWevu9U3qHHX0nDxlNzm/HdZUtPWwi5YbG46gfbf3GCrz4mOTqmuxOL TiXhzBhqRlBROVY091ZqTEmd+KoAn4ENRaYJr5PsMn+NDEx8Yy5LRuFHqdiRew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617998047; a=rsa-sha256; cv=none; b=EpbQC+yylRDEuBdM+wKw8bDVaXsOY1WoUpvZOrdjMrvqO4J4W64ZfldWPfSQkmWmkqRfxL iv+Y6F3GeNeTC30uWm03XUcN1PGxYD7krXlPe/mvQRk5v1qEbDUrNRVf/Jb2LmYAbL2kln glYGmavqlyP0Z65ty241aCHJ0n3HYnZijdGI96XCYhkQISBdSjuryU7wqqwlJXBjjthKqr 5Uh1ldIHgDeGJFVZ3SnyXwm/MeM8lsDs+X22/24d0Jn23tuLAEDjG/OAyz5gh8Rn3/fFBn QPhU7XxFyPgvYVYUA54u2H+xzBr9D4NuUbONUDmpUT5DI8FdPoD5Y3eM6yqslQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=QchSGcS9; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=QchSGcS9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 380F486FF X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: 67uWzzgraiUx Am Freitag, den 09.04.2021, 21:33 +0200 schrieb Maxime Devos: > On Fri, 2021-04-09 at 20:38 +0200, Leo Prikler wrote: > > From: Raghav Gururajan > > > > * gnu/packages/gstreamer.scm (gst-plugins-bad)[version]: Update to > > 1.18.4. > > [arguments](glib-or-gtk): New argument. > > [phases](pre-check): New phase. > > [propagated-inputs]: Add gstreamer. > > [native-inputs]: Add gettext-minimal, gsettings-desktop-schemas, > > perl and > > xorg-server-for-tests. Replace python with python-wrapper. > > > > Signed-off-by: Leo Prikler > > --- > > gnu/packages/gstreamer.scm | 32 +++++++++++++++++++++++++------- > > 1 file changed, 25 insertions(+), 7 deletions(-) > > > > diff --git a/gnu/packages/gstreamer.scm > > b/gnu/packages/gstreamer.scm > > index 38b4fdbe63..cc739bd904 100644 > > --- a/gnu/packages/gstreamer.scm > > +++ b/gnu/packages/gstreamer.scm > > @@ -718,17 +718,18 @@ model to base your own plug-in on, here it > > is.") > > (define-public gst-plugins-bad > > (package > > (name "gst-plugins-bad") > > - (version "1.18.2") > > + (version "1.18.4") > > (source (origin > > (method url-fetch) > > (uri (string-append " > > https://gstreamer.freedesktop.org/src/" > > name "/" name "-" version > > ".tar.xz")) > > (sha256 > > (base32 > > - "06ildd4rl6cynirv3p00d2ddf5is9svj4i7mkahldzhq24pq5 > > mca")))) > > + "0py8k4pbalm9mxkpjbjxis0gp7g74wg5g4yax5q8rccmany0d > > s3l")))) > > (build-system meson-build-system) > > (arguments > > - `(#:phases > > + `(#:glib-or-gtk? #t ; To wrap binaries and/or compile > > schemas > > + #:phases > > (modify-phases %standard-phases > > ,@%common-gstreamer-phases > > ,@(if (string-prefix? "arm" (or (%current-target-system) > > @@ -761,15 +762,32 @@ model to base your own plug-in on, here it > > is.") > > ((".*elements/curlhttpsrc\\.c.*") "") > > ;; > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1412 > > ((".*elements/dtls\\.c.*") "")) > > - #t)))))) > > + #t))) > > Phases do not need to return #t anymore. IIUC, the warning you > get when phases return something else has been removed on core- > updates. True, but since this a patch for staging, I think there remains a time window between this being merged and core-updates being merged, in which the warning would still be printed. Plus, even post core-updates merge, ending in #t is not an "error", it's simply no longer needed. > > + (add-before 'check 'pre-check > > + (lambda _ > > + ;; Tests require a running X server. > > + (system "Xvfb :1 +extension GLX &") > > + (setenv "DISPLAY" ":1") > > + ;; Tests write to $HOME. > > + (setenv "HOME" (getcwd)) > > + ;; Tests look for $XDG_RUNTIME_DIR. > > + (setenv "XDG_RUNTIME_DIR" (getcwd)) > > + ;; For missing '/etc/machine-id'. > > + (setenv "DBUS_FATAL_WARNINGS" "0") > > + #t))))) > > Likewise. Likewise for the other patches. I don't see any other > problems > at the moment (I didn't test though). One note w.r.t. testing: Gstreamer keeps a registry in XDG_CACHE_HOME, that will still refer to old paths and might potentially cause issues. That being said, I still haven't tested ^^" Regards, Leo