From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eHBsFD1zOGFVQgAAgWs5BA (envelope-from ) for ; Wed, 08 Sep 2021 10:24:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eL0PED1zOGGofAAAB5/wlQ (envelope-from ) for ; Wed, 08 Sep 2021 08:24:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 927C810CAA for ; Wed, 8 Sep 2021 10:24:28 +0200 (CEST) Received: from localhost ([::1]:48456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNssd-0002Og-El for larch@yhetil.org; Wed, 08 Sep 2021 04:24:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46696) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNssS-0002OT-Gi for guix-devel@gnu.org; Wed, 08 Sep 2021 04:24:16 -0400 Received: from out2.migadu.com ([2001:41d0:2:aacc::]:16531) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNssP-0002xf-E9 for guix-devel@gnu.org; Wed, 08 Sep 2021 04:24:16 -0400 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631089448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6RHZHVOTqEAG8kjEUMKMQX0G151JZlG77yqRW9sjsKU=; b=Kf+tlrqYOWLCxYKCygXdhjU1YS+PESfrG0/jtbrLhI1+jYoFbxaA33U8RmVD9PGPAVMbMw GKZcix8kAOqKI3MIM6M4GbdcnOAMvPkfXjO2o1+u8lwyUZ0SHCIBksICAiDjgZ3J2OaYAV CVIs4gosoFSOo3uFY9F1691VDKKGOCc= Date: Wed, 08 Sep 2021 08:24:06 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: iskarian@mgsn.dev Message-ID: Subject: Re: Rethinking propagated inputs? To: "Liliana Marie Prikler" , "Maxim Cournoyer" In-Reply-To: References: <8635qgi511.fsf@mgsn.dev> X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=iskarian@mgsn.dev; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631089469; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=6RHZHVOTqEAG8kjEUMKMQX0G151JZlG77yqRW9sjsKU=; b=of0lGWJIBhm0WTHpICpiXSNJccJoDk2F4PRYcC/NJOMM6HMnw0PkhrBY8wSap6KZopg3EE cbKHU0BoZRVaFpBYw0j8QkswUL5PgmBgleFasoKEgUhmM8BJrnyrSQlmKF7kZxCQ6Qwwkx DSLvF7KEy73V/oCfiCtmOcX9tTSInLgWhZKGmaKaoYffszVBU26OO8k8wYnAS3q7+vIizH MWLCy/z8w2lRRQ9XUZJsZGcjfxSk7+TzK7ReXZkMlwJAIx+omw0cyWeJR27yzKeaX+YdUX dXaRGZ4QfXbI/ufmt8Px7hyr8mqrXHGORuT4PX+BVWsERsnHy3ytkn+H1X74WA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631089469; a=rsa-sha256; cv=none; b=tP08z5Q9arNEfHuymUd5wXvvL+dFkc3cQYtxb67IaTARdHEuMrQ4qCc5wz8uiXO/DCEjIg BOb+A9r6yo4dyqcPAVtQA2O4SVzmroNtj8aKwgyyfsT2p6jtEAoETdwX6nkx7Qaq03cI2c pOw8JbNLcxkIrrOqdut4AUsteegveh6UxrkgTLnmxVjWQ0dIe+u6J1oEu5ywDPxXBox3GU DtvlSt1mkGWSknXpCu1BZfGBdnlC7zBfLR7x6o+kjWWk2/mKbJk8cENYNb7NPAzAd1lMO/ 8UnxCv3MMZUJHsUY1NQ0Wc4jP0Y92POKzUTDzByyiHM3um60xvlX8eyUqcOO3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=mgsn.dev header.s=key1 header.b=Kf+tlrqY; dmarc=pass (policy=none) header.from=mgsn.dev; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=mgsn.dev header.s=key1 header.b=Kf+tlrqY; dmarc=pass (policy=none) header.from=mgsn.dev; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 927C810CAA X-Spam-Score: -0.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: D8PdZQ/Uuu32 Hi,=0A=0ASeptember 8, 2021 12:18 AM, "Liliana Marie Prikler" wrote:=0A=0A> Hi,=0A> =0A> Am Dienstag, den 07.09.2021, 1= 2:01 -0700 schrieb Sarah Morgensen:=0A> =0A>> [...]=0A>> =0A>> However, I= MO it doesn't make sense to automatically install these in=0A>> a profile= when installing that package. If you're installing a=0A>> source-only pa= ckage, you likely don't want all the transitive=0A>> dependencies automat= ically installed--what if you're just inspecting=0A>> the source, or want= to try building it with different=0A>> dependencies? If you want all the= build dependencies as well, you=0A>> would just do=0A>> =0A>> guix envir= onment go-foo --ad-hoc go-foo=0A>> =0A>> like you would do for other Guix= packages.=0A> =0A> I think if you wanted to build go-foo locally, you sh= ould go with just=0A> `guix environment go-foo' anyway. For the source co= de, you might be=0A> interested in `guix build --source'.=0A=0Aguix build= --source doesn't capture any modifications made in the dependency packag= e, such as=0Arewriting paths or other patching.=0A=0AYou're right, though= , in that (for now) it's a rare use-case, and probably doesn't warrant th= e=0Aadded complexity and the extra field. It just feels... messy as it is= now.=0A=0A>> In the context of this discussion, I can think of three typ= es of=0A>> solution:=0A>> =0A>> 1. Add a modifier like #:profile? (defaul= ting to #f) to=0A>> propagated-inputs entries=0A>> (propagated-inputs=0A>= > `(("foo" #:profile? #t)))=0A> =0A> This is basically a weaker linked-in= puts, because linked-inputs could=0A> be sanitized while these propagated= inputs could not.=0A=0AGood point. I included it because there seemed to= be pushback on adding a field.=0A=0A>> 2. Rename "propagated-inputs" to = e.g. "profile-propagated-inputs",=0A>> and then introduce a new "propagat= ed-inputs", which only propagates=0A>> into the inputs of dependents, and= not into built profiles.=0A> =0A> Again same as introducing a new field,= but also changing semantics for=0A> everything in the tree. I think havi= ng "propagated-inputs" mean what=0A> it means is fine. If we do find that= we're lacking a field with=0A> certain semantics, we should add that or = change existing fields in=0A> backwards-compatible ways.=0A=0AI agree; I = should have stated this differently ("Add a new field"). The name is just= bikeshedding.=0A=0A>> 3. Introduce a way to prevent an input from propag= ating anything into=0A>> the current package/profile=0A>> (inputs=0A>> `(= ("foo" #:propagate? #f)))=0A>> and then provide CLI options (transformati= ons) to control this.=0A> =0A> Your example should have propagated-inputs= . I'm not sure what benefit=0A> there is to this solution that isn't give= n by adding a field, except=0A> that it can't be sanitized. Now that I th= ink about it, this seems to=0A> be a different syntax to 1.=0A=0AAh, I fo= rgot to state that in this example, "foo" is the package with a propagate= d-inputs field,=0Aand this is a dependent package (or a profile) which do= es not want "foo"'s propagated-inputs to be=0Apropagated to it.=0A=0AThis= way a packager has an "escape hatch" if something unwanted got propagate= d. Thinking about it=0Asome more, though, in such a case it's more likely= to want to disallow a specific package than a=0Awhole set of propagated = inputs. If such a feature would actually be useful (questionable), it's= =0Aprobably better implemented differently than this (disallowed-inputs, = perhaps, to mirror=0Adisallowed-references)?=0A=0AI hope I made some more= sense this time!=0A=0A--=0ASarah