all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: vivien@planete-kraus.eu, 71565@debbugs.gnu.org
Subject: [bug#71565] [PATCH] gnu: ibus-minimal: Graft to 1.5.29.
Date: Mon, 24 Jun 2024 05:44:55 +0200	[thread overview]
Message-ID: <befa2ca7b83ec1a115a717ad627ffd525266a746.camel@gmail.com> (raw)
In-Reply-To: <87r0cn84vy.fsf@gmail.com>

Hi Maxim,

Am Sonntag, dem 23.06.2024 um 22:13 -0400 schrieb Maxim Cournoyer:
> > […] I might have been cargo-culting the -public part from other
> > definitions.  Are grafts typically not exported?
> 
> Not thinking about CI shenanigans, I think it's more logical that
> they be private, since we want the users to use the grafted package,
> not the graft itself (although in the end the result should be the
> same).

You mean that users end up accidentally discovering and using the wrong
ibus through CLI?  I don't think that's an issue for ibus-minimal,
though, since it's hidden anyway, and I do trust users who write the
files to be sensible here.

On that note, I think I remember a graft which had to be public to also
fix issues in certain dependent packages.  (I might have committed that
one myself and IIRC, it was meson).  Feel free to drop the -public part
from the ibus graft though; I had pushed it without resolving this
conversation.

Cheers





  reply	other threads:[~2024-06-24  3:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-15  7:18 [bug#71565] [PATCH] gnu: ibus-minimal: Graft to 1.5.29 Liliana Marie Prikler
2024-06-17 19:55 ` Maxim Cournoyer
2024-06-17 20:05   ` Liliana Marie Prikler
2024-06-24  2:13     ` Maxim Cournoyer
2024-06-24  3:44       ` Liliana Marie Prikler [this message]
2024-06-24  4:50         ` bug#71565: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=befa2ca7b83ec1a115a717ad627ffd525266a746.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=71565@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.