From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:42008)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKNLe-00069C-88
 for guix-patches@gnu.org; Fri, 03 Apr 2020 10:31:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKNLb-00017W-2s
 for guix-patches@gnu.org; Fri, 03 Apr 2020 10:31:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:59680)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jKNLa-00015E-Hv
 for guix-patches@gnu.org; Fri, 03 Apr 2020 10:31:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKNLa-00065f-BC
 for guix-patches@gnu.org; Fri, 03 Apr 2020 10:31:02 -0400
Subject: [bug#40264] Linphone: 11-add-mediastreamer-v2
Resent-Message-ID: <handler.40264.B40264.158592421623232@debbugs.gnu.org>
Mime-Version: 1.0
Date: Fri, 03 Apr 2020 14:30:09 +0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: "Raghav Gururajan" <raghavgururajan@disroot.org>
Message-ID: <bd99706f2abe3a1b4217235ee954385e@disroot.org>
In-Reply-To: <20200403133827.52d529cb@scratchpost.org>
References: <20200403133827.52d529cb@scratchpost.org>
 <a3c3755c86e0d25ca3c4672b8865a9ed@disroot.org>
 <981ea9c838575bacfe934a652ceeca62@disroot.org>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 40264@debbugs.gnu.org

Hi Danny!=0A=0A>> + (list=0A>> =0A>> + ;; For fixing definitions.=0A> =0A=
> Yes, but why? What would happen if we didn't do it?=0A=0AOtherwise, we =
get `-Werror` flag related compilation errors.=0A=0A>> + (origin=0A>> + (=
method url-fetch)=0A>> + (uri=0A>> + (string-append "https://gitlab.linph=
one.org/BC/public/mediastreamer2/commit"=0A>> + "de3a24b795d7a78e78eab6b9=
74e7ec5abf2259ac.diff"))=0A>> + (file-name "mediastreamer-msfactory.patch=
")=0A> =0A> I'm not sure what the outcome of the latest discussion on car=
rying patches was.=0A> Should we carry patches in Guix now or fetch them =
from external source?=0A=0AI think it's good as long as we use hash to ve=
rify. :-)=0A=0A>> + "-DENABLE_GSM=3DNO" ; Need recompilation with -fPIC=
=0A> =0A> Uhhhhhhhhh if that's a library, it should have been compiled wi=
th "-fPIC", no?=0A> =0A> Which library would need recompilation with "-fP=
IC"?=0A=0AI am not sure about this one. Since it is a feature, I was plan=
ning on to deal this later and disable gsm for now. I hope it is okay.=0A=
=0ARegards,=0ARG.