From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SD04BnPwMmIhqwAAgWs5BA (envelope-from ) for ; Thu, 17 Mar 2022 09:25:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aM6nA3PwMmJ8FgAA9RJhRA (envelope-from ) for ; Thu, 17 Mar 2022 09:25:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB1E132852 for ; Thu, 17 Mar 2022 09:25:22 +0100 (CET) Received: from localhost ([::1]:58696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUlRh-0005w8-MH for larch@yhetil.org; Thu, 17 Mar 2022 04:25:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUlRO-0005r7-3D for guix-patches@gnu.org; Thu, 17 Mar 2022 04:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59092) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUlRN-0005Zv-PV for guix-patches@gnu.org; Thu, 17 Mar 2022 04:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nUlRN-00021e-II for guix-patches@gnu.org; Thu, 17 Mar 2022 04:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#45692] [PATCH 0/3] Better Support for ZFS on Guix Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Mar 2022 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: raid5atemyhomework Cc: Maxime Devos , "45692@debbugs.gnu.org" <45692@debbugs.gnu.org> Received: via spool by 45692-submit@debbugs.gnu.org id=B45692.16475054517722 (code B ref 45692); Thu, 17 Mar 2022 08:25:01 +0000 Received: (at 45692) by debbugs.gnu.org; 17 Mar 2022 08:24:11 +0000 Received: from localhost ([127.0.0.1]:52989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUlQZ-00020U-Hu for submit@debbugs.gnu.org; Thu, 17 Mar 2022 04:24:11 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:6961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nUlQX-00020K-E1 for 45692@debbugs.gnu.org; Thu, 17 Mar 2022 04:24:10 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4KK0Y16h27z1LZWn; Thu, 17 Mar 2022 09:24:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4KK0Y16h27z1LZWn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1647505446; bh=WTfh59o2NqmnbEvpP7GzkNLBYIoRLq/RTX95El030K4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=EeTRT6Ce1sh2aWjuxGaa4YWk3iGTizt4wOQG4Tvy/eqCSaou0R73omE6yhzPEwazC H3YBWyL6EyTKDpv3OtrWVrVVAY/1QOIc8tPbfsDo7XlvmaRGpPGGXaKTKWLvOaVjdS sY6bhI2FvSZ4aSzA+Mgyb/t66/NenoDMoIqy3Nyc= Message-ID: From: Liliana Marie Prikler Date: Thu, 17 Mar 2022 09:24:05 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647505522; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WTfh59o2NqmnbEvpP7GzkNLBYIoRLq/RTX95El030K4=; b=J/XmeJlVARdD/tYIjywiA88exHe0i5kYm18uyNljXkUVbkzqcTyWSW9t1+9K1NyXd0CasJ kvpIBLix+bqVmexuhlvWZqvZ5wIqFE9DQpV3fUNKYEupQ4g5o4krsv+WRP/Fa3qeLJ5J/Q cZend+ItiSVOK8CffFRp4PZXXRKHxhZ2hp3pGD5b3tIE9Z7nFeg0qpTv+12ff3HAadiGdA EDs/wCDXZkXg2ZY3b9Y5L8+0a1JrwkwJ57z+BAhfPj42OTRJCzT7Ug8Ly6FL5KJNj3slX+ xQKUzVu8wkK9xsKDcrj217tYtYMJ7j7MsOP0qpVQA2Xx2635/+dCUr+aljM4ow== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647505522; a=rsa-sha256; cv=none; b=KLc2fi3EvJ+7uvq8h1SOuj60xF12dOpM2nQwo2t5K3dh5IxNn+LxoN86V7OEepYc0mqhOx D2VDmLGrUiNwrkI09sDf0QB9/Bdil0ZOPAFhZAxfujVGU2K2N0+VJt9t40CvDlBS2vTb4/ zRLHT5rzVftbLW7XSz/A4+9Uy81kCiItSdZFd4zxIiJAEowhGvVnMYbH6n5Fx7mmVbtYtj tj0HE2wmPWA4GK4mIiGS9BsrEShj8Hoq+3GTcfr++/7VSJuJaaNDsXcB190Jc5s4ccsZfG GNlNAO2DDxAeWCkGMJtuFsL3moxRBTMTcIstKnl9DPDCbnea/UPfMhYh+kr66w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=EeTRT6Ce; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.74 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=EeTRT6Ce; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AB1E132852 X-Spam-Score: 5.74 X-Migadu-Scanner: scn1.migadu.com X-TUID: vMEcJi/p27do Hi raid5, Am Freitag, dem 18.02.2022 um 07:13 +0000 schrieb raid5atemyhomework: > Modified so it applies cleanly to origin/master. > > PLEASE JUST REVIEW AND MERGE, WHAT IS THE PROBLEM HERE ANYWAY? You've been begging for review for a while now, so let me inform you that the way you've been doing this is not particularly helpful to you or the reviewers. First of all, your follow-up messages do not include anyone who has so far reviewed the patch in the "To:" or "Cc:" field. This makes it less likely that they will actually see your message. Secondly, the tone in which you're asking is not nice to the reviewers. I can understand you're a little frustrated waiting for so long, but shouting "WHAT IS THE PROBLEM ANYWAY?" communicates that you're both unaware of and do not care about burdens (e.g. maintenance) that are created by your patch. This in turn prompts reviewers to look away; both out of spite and in order not to deal with this mess at all. I have no stake in ZFS and no intent to review this patch beyond this point, but here a few questions to ask: Why is it necessary to define a file system as a service? Why do we need to export a seemingly unrelated variable? Can this be tested? Is this sufficiently tested? Are there any points Maxime that were drowned out by a huge wall of licensing-related messages being passed back and forth that I will not attempt to sift through in order to respond to this message? If so, have those been sufficiently addressed? Another complicating factor for this bug in particular is that the mumi web interface and the raw messages are out of sync; I have no idea why that is the case, but trying to fetch a patch only to get one of your bump messages is not particularly encouraging. In any case, I've added Maxime to CC so they can have a closer look at it. Cheers