From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8EneBZ5wc2ZEwAAA62LTzQ:P1 (envelope-from ) for ; Wed, 19 Jun 2024 23:58:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id 8EneBZ5wc2ZEwAAA62LTzQ (envelope-from ) for ; Thu, 20 Jun 2024 01:58:22 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EXmPZYJu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718841501; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YJGY/z8aaIx5vr6Z6BdOkJAlo+Gq7DIO5iEPcuiZIOg=; b=OU11IARyr0x68ONspMnM/OUtU4pzmILkWdsp2ZThYLnGh3j8dKKx8iB5ldLISNvWnhRdWX SsXl1XZ5RsLw6MxXUhruNnCGh368YlFayk5IBI0sKeEx250DQLGE/TZQ7MUFQO09T8U299 mbSxrv5mXrr0AWwWCPlsoRK7H98xcSNS8EbGI4quLMJFzqS2CIIhD+2erQ7gegIdhsEdZ5 PIbPY/QnIYt+QAaJCfvas0GnhhTWoKW/itymYxZiv/rEQuTFi5KdoiZ0xteXa37uFj7NHy eKphvCuGB0Oni4nimTRZ7897rn51DZCQpuPhm4tL+bhrO5DMfLq9Hq7TYJ1M+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=EXmPZYJu; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718841501; a=rsa-sha256; cv=none; b=JNVZ5mceWoVR4uKx9QrtavgWKFaG0wIMJdT/l1jvbIm4HNrmUQ01WyPR+yqbFfzNqTxr3P e6gIhRdOAYKL9WZLW/+JiNQPcZy3Yhbi+YPI6WkmvXOAK9stxyTktz0dqIntt4IIMpXtNt MbCndZMCfelMrZDbdH5KmqimceUCLE+h0tgoU/quOOD1RuflxZgCb7xbrBGM5bjtGM0Acy 0DME4ir8yDUuw0TNRhwrVXXDgWjI+a9vrYF4oncY4J+Hdexly+1L7HkBK0jzWgHAYUvlZ7 VAjTrX5wnyVoQ8kRmUrhtsbCCfMxTGlMJ7bUXT+wFvHQJsLjJhbH7GhtPjWNfw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D38056779F for ; Thu, 20 Jun 2024 01:58:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sK4qR-0007iH-Fv; Wed, 19 Jun 2024 19:36:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK4qO-0007hN-UF for guix-patches@gnu.org; Wed, 19 Jun 2024 19:36:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK4qO-00022F-KC for guix-patches@gnu.org; Wed, 19 Jun 2024 19:36:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sK4qQ-00079D-BI; Wed, 19 Jun 2024 19:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71319] [PATCH v3 2/3] gnu: emacs-ddskk: Improve package style. Resent-From: gemmaro Original-Sender: "Debbugs-submit" Resent-CC: mail@nicolasgoaziou.fr, andrew@trop.in, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Wed, 19 Jun 2024 23:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71319@debbugs.gnu.org Cc: gemmaro , Nicolas Goaziou , Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler X-Debbugs-Original-Xcc: Nicolas Goaziou , Andrew Tropin , Katherine Cox-Buday , Liliana Marie Prikler Received: via spool by 71319-submit@debbugs.gnu.org id=B71319.171884013427414 (code B ref 71319); Wed, 19 Jun 2024 23:36:02 +0000 Received: (at 71319) by debbugs.gnu.org; 19 Jun 2024 23:35:34 +0000 Received: from localhost ([127.0.0.1]:35114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK4px-000783-Qs for submit@debbugs.gnu.org; Wed, 19 Jun 2024 19:35:34 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:59741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sK4pt-00077P-F3 for 71319@debbugs.gnu.org; Wed, 19 Jun 2024 19:35:30 -0400 Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7ec00e71a57so8648139f.3 for <71319@debbugs.gnu.org>; Wed, 19 Jun 2024 16:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718840060; x=1719444860; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YJGY/z8aaIx5vr6Z6BdOkJAlo+Gq7DIO5iEPcuiZIOg=; b=EXmPZYJubrKbguGIYp8B+2WQMB4vOevf8z9mlc1oOecU8w5otjZFvYmfpqIEoatfor W7ERJh82nEqq0sfIMzAEdDZSVs4Wlk0aUQKF7FRCKCT/GkHRFog5D3FQGqcg6t6+ZN8L i6BSMAv/7CHNOyTGmGvYOZAlGw+Mn2Zl/WG4GR1UYGa1JTY2jkHN4Mjn7nR/tPM6REb+ 9pk0rk78AFO7U9yRcrxIN9AgCPvki286RJUNf6f+96EoVJ3gvwzuFUJ5TDyAra/qZUcH lZ7bkEgDXvHXdgJQVfcq0Pzqx7bev4KWQrfkZ/KoRUa2GsdwtOGT/0K7oRfSzybj/a2M BsfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718840060; x=1719444860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJGY/z8aaIx5vr6Z6BdOkJAlo+Gq7DIO5iEPcuiZIOg=; b=oEYKQgc0fdTQiML9VDmGf7RPXN8/IwZnq+N85zlI8kwzfHP+xx/8rfW4ecOhf65Lo4 Hau4bk/8mMn2J2aqoeXo+OzXtQHBN95Mfq/OQbXK4TT1raImV/y2iUqon72IkgGOTFCs NTEDQnwc/yQhpUoNpwfzxBg9OreTs4vnw5d8izKCIecwHmGOdr2lGgQAIATHXe/2qZV+ bSuv2atLTZUkWYIf811tiVRygncyS9iSnBlzWVj0wacAI4TCAH6EtiUE4AV8ma0mvtAN +61HUtasi/aXYqWeQqKOJ367D81NCmR9TuI9ChkGS0LTtL1vMHWe8AOCwoBf9tPpKRif RcLw== X-Gm-Message-State: AOJu0YywS+s/y5SF7lRIhJer1OUPb5NaPp96J7LxW8Q9h0PKC7MvymP2 K9t8nm1Qu7dlcu7Yq1dfmyuvQax9WYzjQvj7NVfhcIezmQIPsIrFdjH8ZBpI X-Google-Smtp-Source: AGHT+IEozNIMgvPi5gdxHVYcTDIpYTXJcK3tjg0t5kjEEWXPI9dB0sYSRoFtDWH74A3J49FSqbayBA== X-Received: by 2002:a05:6e02:1b09:b0:374:a7d0:b0bc with SMTP id e9e14a558f8ab-3761d72b118mr46896655ab.23.1718840060312; Wed, 19 Jun 2024 16:34:20 -0700 (PDT) Received: from mac.gemmaro.name ([240f:74:d1f0:1:1883:f3d1:907f:a2e3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6fee3ba48c1sm10131908a12.81.2024.06.19.16.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 16:34:19 -0700 (PDT) From: gemmaro Date: Thu, 20 Jun 2024 08:32:40 +0900 Message-ID: X-Mailer: git-send-email 2.45.1 In-Reply-To: <378f901df9ae830b822653251f5e9db18cc18e0e.1718839586.git.gemmaro.dev@gmail.com> References: <378f901df9ae830b822653251f5e9db18cc18e0e.1718839586.git.gemmaro.dev@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: D38056779F X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -3.26 X-Spam-Score: -3.26 X-TUID: j+HPK4lKlDnt * gnu/packages/emacs-xyz.scm (emacs-ddskk)[arguments]: Use newer package style. Make use of gexps and #$output and removed trailing #t. Also, SKK-MK and doc files are not made writable, and the rm in nicola/Makefile is fixed. Change-Id: Ie6ed743ded35b55fa55bb61d02353456a0f2c79f --- gnu/packages/emacs-xyz.scm | 43 +++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 2eee8cfcb5..855d75e390 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -37033,28 +37033,27 @@ (define-public emacs-ddskk (base32 "0vfdbab3ncns8wwrna8h6y2w0grkphzr9s65sgxq98lpqmxbbr72")))) (build-system gnu-build-system) (arguments - `(#:modules ((guix build gnu-build-system) - (guix build utils) - (guix build emacs-utils)) - #:imported-modules (,@%gnu-build-system-modules - (guix build emacs-utils)) - #:test-target "test" - #:phases - (modify-phases %standard-phases - (replace 'configure - (lambda* (#:key outputs #:allow-other-keys) - (make-file-writable "SKK-MK") - (emacs-substitute-variables "SKK-MK" - ("PREFIX" (assoc-ref outputs "out")) - ("LISPDIR" '(expand-file-name "/share/emacs/site-lisp" PREFIX)) - ("SKK_PREFIX" "") - ("SKK_INFODIR" '(expand-file-name "info" PREFIX))) - (for-each make-file-writable (find-files "./doc")) - #t)) - (add-after 'unpack 'fix-test - (lambda _ - (substitute* "Makefile" - (("/bin/rm") (which "rm")))))))) + (list #:modules '((guix build gnu-build-system) + (guix build utils) + (guix build emacs-utils)) + #:imported-modules `(,@%gnu-build-system-modules + (guix build emacs-utils)) + #:test-target "test" + #:phases + #~(modify-phases %standard-phases + (replace 'configure + (lambda _ + (emacs-substitute-variables "SKK-MK" + ("PREFIX" #$output) + ("LISPDIR" '(expand-file-name "/share/emacs/site-lisp" PREFIX)) + ("SKK_PREFIX" "") + ("SKK_INFODIR" '(expand-file-name "info" PREFIX))))) + (add-after 'unpack 'fix-test + (lambda _ + (substitute* "Makefile" + (("/bin/rm") (which "rm"))) + (substitute* "nicola/Makefile" + (("/bin/rm") (which "rm")))))))) (native-inputs (list emacs-minimal ruby)) (home-page "https://github.com/skk-dev/ddskk") -- 2.45.1