From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yIy/MbQiLWLBRAAAgWs5BA (envelope-from ) for ; Sat, 12 Mar 2022 23:46:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OKU5L7QiLWLVHgAA9RJhRA (envelope-from ) for ; Sat, 12 Mar 2022 23:46:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A7C132D6C for ; Sat, 12 Mar 2022 23:46:12 +0100 (CET) Received: from localhost ([::1]:50888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTAV0-00086h-LA for larch@yhetil.org; Sat, 12 Mar 2022 17:46:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTAUs-00086P-LC for guix-patches@gnu.org; Sat, 12 Mar 2022 17:46:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTAUs-0003Wh-BG for guix-patches@gnu.org; Sat, 12 Mar 2022 17:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTAUs-0000Cp-9X for guix-patches@gnu.org; Sat, 12 Mar 2022 17:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54335] [PATCH 11/14] gnu: Add go-google-golang-org-protobuf. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Mar 2022 22:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54335 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dominic Martinez Cc: 54335@debbugs.gnu.org Received: via spool by 54335-submit@debbugs.gnu.org id=B54335.164712514532275 (code B ref 54335); Sat, 12 Mar 2022 22:46:02 +0000 Received: (at 54335) by debbugs.gnu.org; 12 Mar 2022 22:45:45 +0000 Received: from localhost ([127.0.0.1]:41107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTAUb-0008OA-CT for submit@debbugs.gnu.org; Sat, 12 Mar 2022 17:45:45 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:58934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTAUZ-0008Ki-4C for 54335@debbugs.gnu.org; Sat, 12 Mar 2022 17:45:43 -0500 Received: from [172.20.10.5] ([188.189.206.172]) by laurent.telenet-ops.be with bizsmtp id 5alg2700F3jiMiL01alhSN; Sat, 12 Mar 2022 23:45:41 +0100 Message-ID: From: Maxime Devos Date: Sat, 12 Mar 2022 23:45:36 +0100 In-Reply-To: <87sfrorzqz.fsf@dominicm.dev> References: <20220311031849.12681-1-dom@dominicm.dev> <20220311034741.14377-1-dom@dominicm.dev> <20220311034741.14377-2-dom@dominicm.dev> <26abc2bc0774006b53836e475fdbdd60e0088c63.camel@telenet.be> <87sfrorzqz.fsf@dominicm.dev> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-rIXUBWx83cODqmi7L81Q" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647125141; bh=j61sJuFNchTfd4apd3wzrhaGw4rlhzDLocHOVm5R5IU=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=dHoZUYMA9sLDBfClUyBywMW5YuRoqwGqK36iMgJbVNtyq5sB4yoC46kMjFIlS1C29 oKL8gLRt6QPZuY++OP6jsvfQBobWT3ecC0qq6GFz5TmPE2cxTSk6NAyLQ6Mc4HnpUi 5/7zAzyrkowsd31zt3SHoKXoh/6dUqBaLXWcPjmEh1CwUhqs/g2QeBf8MV5bdQR1si AH9MYEVG7s14nn9JicThUugqpkAgpAMKdYZBAVh+GtbFt2FDZ0PMVPgYH8avzn5muQ FO9YjX08k36x+xPd+peeeS9A2idT5tgGCHWTON4Z1EqMh+Jq6FRyw916VADxvu7o+n qCxo/uZzrDIkA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647125172; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=j61sJuFNchTfd4apd3wzrhaGw4rlhzDLocHOVm5R5IU=; b=o2p388sd6ciXBF3yrBumYTBml1HbH/ZUkjW8up63yzRxYwGlAtvoU6rYZuaHoJtoZCRq0/ rMJVuHopOtmaTBTP5rHND976ttF+xP5WGLcYGP08Ma+sfPl6gsAm/ADxfIBf6Cw3a+BbE8 DQG/IHgQ7ZHtebHtf1VU8kpHvjqd69TTVvtn8+XkRmw8Y4u1TyvVgp0iKtTXkM3IFe+rjy 3gqK7lmfA57LknSTnuVp8nf2sySzAmyV7mNXEuwzTqQy6xUXK89P9CKFpjUl9R7RB/+AQz NJ9OYGb+jcRysaRHe9p2qNZsk2NcOAukmGmdQcxiRuyZfjwJpOjBJddUQDP1yA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647125172; a=rsa-sha256; cv=none; b=t7oKyhwpjugCT9KDzY4uQjC2g7BP/BlAEvgCRwGdvyzqVmBcB9168LHX0J0rDfDcDknQL4 oAEsU5ox90+Gja+2vQWbrnj0U8cpZt9pLersVV1FFuDpxvXYvLGzKOR3tdvUKP+QG9U53M 9Sm8CeJ8t7FRT3IwWW0qcIe0nxEkg+k+XAnbbdz5DKzTX/c9dcZzuM4uMqzKbpmD7+aD9W D7PwJtnJ/sfUXTIiSxSnG5vnMwuA8Gq7ekFAIdmEhDMfxbfGiflcTdJ3+mtKHU8DXzhuCN 5iN0Kz+ygRbv6tqRprUxFTvNHevOAscbSwXoeuEoLIREhTudsYNDFn0VnbZtIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=dHoZUYMA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=dHoZUYMA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6A7C132D6C X-Spam-Score: 3.72 X-Migadu-Scanner: scn1.migadu.com X-TUID: ov2s/PmiSL8I --=-rIXUBWx83cODqmi7L81Q Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dominic Martinez schreef op vr 11-03-2022 om 15:32 [-0500]: > As far as I can tell Go expects libraries to be source-only, so=20 > I'm not sure what you would do in a build phase. I followed the=20 > lead of the other Go library packages like go-golang-org-x-tools=20 > (grep golang.scm for "Source-only package"). FWIW, there exist Go libraries that keep the default build phase, e.g. go-github-com-hashicorp-go-version. Also, according to comments in guix/build/go-build-system.scm, it is intended to someday reuse the compiled build dependencies again (see ). Also, perhaps the 'build' phase is currently largely useless for Go libraries, I'd expect it to be a no-op in those cases, so I don't expect it to be necessary to delete the build phase. I expect that existing instances of (delete 'build) in golang.scm can be removed, but it's not something I've ever actually tried, so I'm not sure. Greetings, Maxime. --=-rIXUBWx83cODqmi7L81Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYi0ikBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jQQAQDcAc8ENYbTqI0RZG0oGvYBYNLy gYQ273IhZm+TSGvWnQD/XHLKue7cVOZbJmvD/nbhkhwVjnt+0Sur6i/kEn/g+wg= =hAC7 -----END PGP SIGNATURE----- --=-rIXUBWx83cODqmi7L81Q--