From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iFGiBmnVeWDKIQAAgWs5BA (envelope-from ) for ; Fri, 16 Apr 2021 20:20:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eBocAWnVeWBvMwAAB5/wlQ (envelope-from ) for ; Fri, 16 Apr 2021 18:20:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E5631E285 for ; Fri, 16 Apr 2021 20:20:24 +0200 (CEST) Received: from localhost ([::1]:37826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXT4p-00056f-H1 for larch@yhetil.org; Fri, 16 Apr 2021 14:20:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXSl9-0005It-Tp for guix-patches@gnu.org; Fri, 16 Apr 2021 14:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58298) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXSl8-00030t-Ot for guix-patches@gnu.org; Fri, 16 Apr 2021 14:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXSl8-0004C5-K8 for guix-patches@gnu.org; Fri, 16 Apr 2021 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad Improvements. Resent-From: "jgart" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Apr 2021 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47815 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , 47815@debbugs.gnu.org Cc: "Bonface Munyoki K." , Efraim Flashner , "Bonface M. K." Received: via spool by 47815-submit@debbugs.gnu.org id=B47815.161859599316071 (code B ref 47815); Fri, 16 Apr 2021 18:00:02 +0000 Received: (at 47815) by debbugs.gnu.org; 16 Apr 2021 17:59:53 +0000 Received: from localhost ([127.0.0.1]:41611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXSkz-0004B8-40 for submit@debbugs.gnu.org; Fri, 16 Apr 2021 13:59:53 -0400 Received: from mx1.dismail.de ([78.46.223.134]:20722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXSkx-0004Ar-8q for 47815@debbugs.gnu.org; Fri, 16 Apr 2021 13:59:52 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 84234421; Fri, 16 Apr 2021 19:59:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:from:message-id:subject:to:cc :in-reply-to:references; s=20190914; bh=VX9E1+5deTAgCBm2CJREG/Tj jul35kEEzNa+Ry7xv4c=; b=HgP7jMYqRPibsUOKMj4jgvF+1UyjnFZ0WeyEib/t D/LuPmAVS4cD/e9sNS0Wi51UTTmq+Cz8GZm9/FH6r5lpzc6Wc/KyAh6IYljsysim IW8fy5neaqoMUDYqWfXUQB+2n+r6f9VzzZjgg8wsUzCtp8xyjgKrS1z1xd/EY91F sYmHMr5FVh2Em4u8IF9Vv6XyhXqIBkvSfkaPLjQ8vK551YYVSrzQc1bx5AWbssDn ZkU/iKBssfWfR8hdHGocoBkKyEzOfOgNK2SyR9v8XuDcBWwPfpIVdcCRPsa1UH2h Ds6naGgJqIXlgqrgv9ya1MxZOXd+1+R7jVNiCN1dyQRtFw== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 9eb7da4b; Fri, 16 Apr 2021 19:59:43 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id e390ba60; Fri, 16 Apr 2021 19:59:42 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 8e274f71 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 16 Apr 2021 19:59:42 +0200 (CEST) MIME-Version: 1.0 Date: Fri, 16 Apr 2021 17:59:41 +0000 Content-Type: multipart/mixed; boundary="--=_RainLoop_535_151081507.1618595981" X-Mailer: RainLoop/1.14.0a Message-ID: In-Reply-To: <97a0c2631437f698041b40786a4442e0ff4e5432.camel@telenet.be> References: <97a0c2631437f698041b40786a4442e0ff4e5432.camel@telenet.be> <41ef3171abdaaafbfc405e131de5ab68@dismail.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618597224; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=VX9E1+5deTAgCBm2CJREG/Tjjul35kEEzNa+Ry7xv4c=; b=PviCUhLQnWSw8b7HoIleRLmK8fbf304NiY6RtgD6CbJ7ryxF5zIRQoQS60opqtoXB5biez YI8YA/qpvkJ/3FGBJtrntrkaHL48pSPTeb3VZ6N06C3f/Bi+9srHkM4DjfKYHj6mUnQWBw t1SU3UJlV7tNzDLM5zb3RzKE0qRbZWd4RgGenqBqKpFCvxG1AwMmoAKY89eHxyqaOr92NQ kIz4PYbrihoqMawVnDVirpYj7M/3P9FpQCojecTAgsOBzcc7/hMGcNe0qDiW2/+rYotbQc S/ukBkeLIc+AtXwrbbWjuyEJ90hdrYUT91bAp2tiZ4oTkBQse9QuzHkC0+rg7A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618597224; a=rsa-sha256; cv=none; b=HPR8JaGkE7kBq5H9aL7RykQQb1i7mW2RKKwZo/QZeL4mCXVHWRg1DIDGfnG8VsZL5hK231 cDeSi4pGzSZgvwyFYQrdpDBLKwtDNRnjzwUBKyv0HKjtCYIn/nHfjvYAuAsUVfPobOlkoI ECAxRx0pDnMgUVt9loBIa2SeaKbxMGHscegZCdNCCWpXFBbwEMD9uBJq6bY5jz/dxdO2t6 u7ZEv6Amdd38RrLRi1TQW+ociPXMTf5OXUfvTHcIx53PMbmGFiqCcPOKV0i7RPOfTe4/04 otmVtSEpNvTMsvfvPduVGZ5zJ4y5B+ykfZQpA+7Frl2bPHVKEEoNSd2pgiRWqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=HgP7jMYq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=HgP7jMYq; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6E5631E285 X-Spam-Score: -2.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: vbTZWVeVh46Z ----=_RainLoop_535_151081507.1618595981 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Maxime,=0A=0AThank you for the review! I attached a new patch set. =0A= =0AI reverted to Bonface's original idea of having lilypond only as a nat= ive input in the package definition.=0A=0AI prefer this solution in order= to solve the problem since it follows upstream's instructions of install= ing lilypond separately (https://abjad.github.io/first_steps/linux.html),= doesn't pollute a guix user's profile with lilypond as you mentioned, an= d seems a bit cleaner since I don't have to touch the python sources in o= rder to make them find the lilypond input.=0A=0AIf the user wants to prod= uce a pdf then they can just include lilypond in their profile.=0A=0AWhat= do you think?=0A=0Abest regards,=0A=0Ajgart=0A=0Aps=0A=0AThis caused me = to have to add lilypond as a native-input to abjad-ext-rmakers (47816), a= bjad-ext-nauert (47817), and abjad-ext-ipython (47818) since those where = building successfully before because they had abjad as a propagated input= and abjad had lilypond as a propagated input. The above mentioned packag= es require lilypond for the tests.=0A=0A=0A=0A=0AApril 16, 2021 6:12 AM, = "Maxime Devos" wrote:=0A=0A> On Fri, 2021-04-16 = at 04:57 +0000, jgart via Guix-patches via wrote:=0A> =0A>> Hi Guix,=0A>>= =0A>> Below are some improvements to the python-abjad package that was m= erged the other day.=0A>> =0A>> I changed the name to abjad, moved some i= nputs into their correct place,=0A> =0A> Please move 'lilypond' from prop= agated-inputs to 'inputs', if sanely possible!=0A> This avoids polluting = the profile with packages the user did not=0A> explicitely request. Of co= urse, abjad still somehow has to find=0A> lilypond, so you might need to = replace "lilypond" with=0A> =0A> (string-append (assoc-ref inputs "lilypo= nd") "/bin/lilypond")=0A> =0A> somewhere in python-abjad's source code. Y= ou can use substitute*=0A> for that.=0A> =0A> Greetings,=0A> Maxime. ----=_RainLoop_535_151081507.1618595981 Content-Type: application/octet-stream; name="0001-gnu-Rename-python-abjad-to-abjad.patch" Content-Disposition: attachment; filename="0001-gnu-Rename-python-abjad-to-abjad.patch" Content-Transfer-Encoding: base64 RnJvbSAwMTllNmMzYTk0MjA3ODIwNGI3MmFlYzJmNzU1MDRjYmFjMDU5MDczIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZ2FydCA8amdhcnRAZGlzbWFpbC5kZT4KRGF0ZTog RnJpLCAxNiBBcHIgMjAyMSAwMDoxNjoxOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMS82XSBn bnU6IFJlbmFtZSAicHl0aG9uLWFiamFkIiB0byAiYWJqYWQiLgoKICAgICogZ251L3BhY2th Z2VzL211c2ljLnNjbSAocHl0aG9uLWFiamFkKTogUmVuYW1lIHRvIGFiamFkLgotLS0KIGdu dS9wYWNrYWdlcy9tdXNpYy5zY20gfCA0ICsrLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL211 c2ljLnNjbSBiL2dudS9wYWNrYWdlcy9tdXNpYy5zY20KaW5kZXggMjY1YjhmZGNjZi4uZTEz ODU0MWYxMyAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL211c2ljLnNjbQorKysgYi9nbnUv cGFja2FnZXMvbXVzaWMuc2NtCkBAIC0xNTAyLDkgKzE1MDIsOSBAQCBHdWlsZS4iKQogICAg IDs7IG1vcmUgdGhhbiBhbiBob3VyIG9mIHNpbGVuY2UsIHNvIGRvdWJsZSB0aGUgbWF4IHNp bGVudCB0aW1lLgogICAgIChwcm9wZXJ0aWVzIGAoKG1heC1zaWxlbnQtdGltZSAuIDcyMDAp KSkpKQogCi0oZGVmaW5lLXB1YmxpYyBweXRob24tYWJqYWQKKyhkZWZpbmUtcHVibGljIGFi amFkCiAgIChwYWNrYWdlCi0gICAgKG5hbWUgInB5dGhvbi1hYmphZCIpCisgICAgKG5hbWUg ImFiamFkIikKICAgICAodmVyc2lvbiAiMy4zIikKICAgICAoc291cmNlCiAgICAgIChvcmln aW4KLS0gCjIuMjkuMwoK ----=_RainLoop_535_151081507.1618595981 Content-Type: application/octet-stream; name="0002-gnu-abjad-Move-python-ply-to-propagated-inputs.patch" Content-Disposition: attachment; filename="0002-gnu-abjad-Move-python-ply-to-propagated-inputs.patch" Content-Transfer-Encoding: base64 RnJvbSA1N2YxZTA1MGFmZDdhYjA1Y2Q5M2ZiYmUzNGI3OWY1NWJlNzhkYTQzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZ2FydCA8amdhcnRAZGlzbWFpbC5kZT4KRGF0ZTog RnJpLCAxNiBBcHIgMjAyMSAwMDoyMzowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMi82XSBn bnU6IGFiamFkOiBNb3ZlIHB5dGhvbi1wbHkgdG8gcHJvcGFnYXRlZC1pbnB1dHMuCgogICAg KiBnbnUvcGFja2FnZXMvbXVzaWMuc2NtIChhYmphZCk6IHB5dGhvbi1wbHkgaXMgdXNlZCBi eQogICAgYWJqYWQncyBsaWx5cG9uZCBwYXJzZXJzLgotLS0KIGdudS9wYWNrYWdlcy9tdXNp Yy5zY20gfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvbXVzaWMuc2NtIGIvZ251L3BhY2th Z2VzL211c2ljLnNjbQppbmRleCBlMTM4NTQxZjEzLi4yOTkxYmY4ZmExIDEwMDY0NAotLS0g YS9nbnUvcGFja2FnZXMvbXVzaWMuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9tdXNpYy5zY20K QEAgLTE1MzgsNyArMTUzOCw2IEBAIEd1aWxlLiIpCiAgICAgICAgKCJweXRob24taW5pY29u ZmlnIiAscHl0aG9uLWluaWNvbmZpZykKICAgICAgICAoInB5dGhvbi1pc29ydCIgLHB5dGhv bi1pc29ydCkKICAgICAgICAoInB5dGhvbi1teXB5IiAscHl0aG9uLW15cHkpCi0gICAgICAg KCJweXRob24tcGx5IiAscHl0aG9uLXBseSkKICAgICAgICAoInB5dGhvbi1weXRlc3QiICxw eXRob24tcHl0ZXN0LTYpCiAgICAgICAgKCJweXRob24tcHl0ZXN0LWNvdiIgLHB5dGhvbi1w eXRlc3QtY292KQogICAgICAgICgicHl0aG9uLXNwaGlueC1hdXRvZG9jLXR5cGVoaW50cyIg LHB5dGhvbi1zcGhpbngtYXV0b2RvYy10eXBlaGludHMpKSkKQEAgLTE1NDYsNiArMTU0NSw3 IEBAIEd1aWxlLiIpCiAgICAgIGAoKCJweXRob24tcXVpY2t0aW9ucyIgLHB5dGhvbi1xdWlj a3Rpb25zKQogICAgICAgICgicHl0aG9uLXJvbWFuIiAscHl0aG9uLXJvbWFuKQogICAgICAg ICgicHl0aG9uLXNpeCIgLHB5dGhvbi1zaXgpCisgICAgICAgKCJweXRob24tcGx5IiAscHl0 aG9uLXBseSkKICAgICAgICAoInB5dGhvbi11cWJhciIgLHB5dGhvbi11cWJhcikpKQogICAg IChob21lLXBhZ2UgImh0dHBzOi8vYWJqYWQuZ2l0aHViLmlvIikKICAgICAoc3lub3BzaXMg IlB5dGhvbiBBUEkgZm9yIGJ1aWxkaW5nIExpbHlQb25kIGZpbGVzIikKLS0gCjIuMjkuMwoK ----=_RainLoop_535_151081507.1618595981 Content-Type: application/octet-stream; name="0003-gnu-abjad-Improve-description.patch" Content-Disposition: attachment; filename="0003-gnu-abjad-Improve-description.patch" Content-Transfer-Encoding: base64 RnJvbSA3YTQ4MmI1MTU1MThjZDFhNWY1NTVlNDFjYTBhNDNmZWVhZGE2Y2M4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZ2FydCA8amdhcnRAZGlzbWFpbC5kZT4KRGF0ZTog RnJpLCAxNiBBcHIgMjAyMSAwMDozMTo1MCAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMy82XSBn bnU6IGFiamFkOiBJbXByb3ZlIGRlc2NyaXB0aW9uLgoKICAgICogZ251L3BhY2thZ2VzL211 c2ljLnNjbSAoYWJqYWQpW2Rlc2NyaXB0aW9uXTogSW1wcm92ZSBhYmphZCdzCiAgICBkZXNj cmlwdGlvbi4KLS0tCiBnbnUvcGFja2FnZXMvbXVzaWMuc2NtIHwgNyArKysrKystCiAxIGZp bGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvZ251L3BhY2thZ2VzL211c2ljLnNjbSBiL2dudS9wYWNrYWdlcy9tdXNpYy5zY20KaW5k ZXggMjk5MWJmOGZhMS4uOWQxMzc1ZDZiMyAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL211 c2ljLnNjbQorKysgYi9nbnUvcGFja2FnZXMvbXVzaWMuc2NtCkBAIC0xNTUwLDcgKzE1NTAs MTIgQEAgR3VpbGUuIikKICAgICAoaG9tZS1wYWdlICJodHRwczovL2FiamFkLmdpdGh1Yi5p byIpCiAgICAgKHN5bm9wc2lzICJQeXRob24gQVBJIGZvciBidWlsZGluZyBMaWx5UG9uZCBm aWxlcyIpCiAgICAgKGRlc2NyaXB0aW9uCi0gICAgICJUaGlzIHBhY2thZ2UgcHJvdmlkZXMg YSBQeXRob24gQVBJIGZvciBidWlsZGluZyBMaWx5UG9uZCBmaWxlcy4iKQorICAgICAiQWJq YWQgaGVscHMgY29tcG9zZXJzIGJ1aWxkIHVwIGNvbXBsZXggcGllY2VzIG9mIG11c2ljIG5v dGF0aW9uIGluIGl0ZXJhdGl2ZQorYW5kIGluY3JlbWVudGFsIHdheXMuICBVc2UgQWJqYWQg dG8gY3JlYXRlIGEgc3ltYm9saWMgcmVwcmVzZW50YXRpb24gb2YgYWxsIHRoZSBub3RlcywK K3Jlc3RzLCBjaG9yZHMsIHR1cGxldHMsIGJlYW1zIGFuZCBzbHVycyBpbiBhbnkgc2NvcmUu ICBCZWNhdXNlIEFiamFkIGV4dGVuZHMgdGhlIFB5dGhvbgorcHJvZ3JhbW1pbmcgbGFuZ3Vh Z2UsIHlvdSBjYW4gdXNlIEFiamFkIHRvIG1ha2Ugc3lzdGVtYXRpYyBjaGFuZ2VzIHRvIG11 c2ljIGFzIHlvdSB3b3JrLgorQmVjYXVzZSBBYmphZCB3cmFwcyB0aGUgTGlseVBvbmQgbXVz aWMgbm90YXRpb24gcGFja2FnZSwgeW91IGNhbiB1c2UgQWJqYWQgdG8gY29udHJvbCB0aGUK K3R5cG9ncmFwaGljIGRldGFpbCBvZiBzeW1ib2xzIG9uIHRoZSBwYWdlLiIpCiAgICAgKGxp Y2Vuc2UgbGljZW5zZTpleHBhdCkpKQogCiAoZGVmaW5lLXB1YmxpYyBub24tc2VxdWVuY2Vy Ci0tIAoyLjI5LjMKCg== ----=_RainLoop_535_151081507.1618595981--