From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czeJy-0000HC-Nj for guix-patches@gnu.org; Sun, 16 Apr 2017 03:10:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czeJu-0003Kx-RL for guix-patches@gnu.org; Sun, 16 Apr 2017 03:10:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:51486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1czeJu-0003Kp-Fx for guix-patches@gnu.org; Sun, 16 Apr 2017 03:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1czeJt-0007Q3-P3 for guix-patches@gnu.org; Sun, 16 Apr 2017 03:10:01 -0400 Subject: bug#26454: [PATCH 2/2] gnu: add emacs-exwm Resent-Message-ID: Message-Id: MIME-Version: 1.0 From: Arun Isaac Date: Sun, 16 Apr 2017 12:39:07 +0530 In-reply-to: <87k26ldys5.fsf@163.com> References: <20170411225803.2420-1-tumashu@163.com> <20170411225803.2420-2-tumashu@163.com> <87inm9sdcs.fsf@gmail.com> <60b3e50e.AEEAJadpHi4AAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY7oh5@mailjet.com> <67fed3f6.1a3b.15b64e00dfd.Coremail.tumashu@163.com> <87mvbj6w72.fsf@163.com> <4d35676d.AEUAI-hEBJAAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8M5G@mailjet.com> <87zifjm39e.fsf@163.com> <4f5081b4.AEAAJDrf7PAAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY8QX9@mailjet.com> <33802c56.135f.15b6f79595f.Coremail.tumashu@163.com> <87bmrxua4o.fsf@163.com> <87k26ldys5.fsf@163.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26454@debbugs.gnu.org Feng Shu writes: > Arun Isaac writes: > >> You should be able to do this just using #:make-flags. See >> https://www.gnu.org/software/make/manual/html_node/Overriding.html > > emacs-build-system seem to have no #:make-flags, I just use > "make var1=3Dvar1 all" instead. Ah, yes. I forgot! > the rest have been fixed, thanks! > > the below is new patch: I'm not able to apply your patch. Could you send the patches made against the latest master? Thanks! > + (arguments > + `(#:emacs ,emacs > + #:phases > + ;; Generate .el files from the XML description of the XCB binding= s. > + ;; This will be adjusted when xelb developer comment in issue pag= e: > + ;; https://github.com/ch11ng/xelb/issues/16 > + (modify-phases %standard-phases > + (add-after 'unpack 'regenerate-el-files > + (lambda* (#:key inputs #:allow-other-keys) > + (zero? (system* "make" > + (string-append "PROTO_PATH=3D" > + (assoc-ref inputs "xcb-proto= ") > + "/share/xcb") > + (string-append "EMACS_BIN=3D" > + (assoc-ref inputs "emacs") > + "/bin/emacs -Q") > + "all"))))))) "all" is the default target, isn't it? In the interest of brevity, you can drop it. > + (native-inputs `(("xcb-proto" ,xcb-proto))) > + (home-page "https://github.com/ch11ng/xelb") > + (synopsis "X protocol Emacs Lisp Binding") > + (description "@code{emacs-xelb} is a pure Emacs Lisp implementation > +of the X11 protocol based on the XML description files from the XCB > +project. It features an object-oriented API and permits a certain degree > +of concurrency. It should enable you to implement low-level X11 applicat= ions.") There should be two spaces after the full stop '.' at the end of a sentence. Do run through 'guix lint'. It will warn you about this. > +(define-public emacs-exwm > + (package > + (name "emacs-exwm") > + (version "0.13-3.7a5bb11") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ch11ng/exwm") > + (commit "7a5bb1156d07848e465f55fd31f8ec755b52aa01"))= ) > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "0cbaq2ls8pivz4h8hwgn9ldvg16pwlisdf047civvilqiqczw31w"))= )) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-xelb" ,emacs-xelb))) > + (inputs > + `(("xhost" ,xhost) > + ("dbus" ,dbus))) > + ;; The following functions and variables needed by emacs-exwm are > + ;; not included in emacs-minimal: > + ;; scroll-bar-mode, fringe-mode > + ;; x-display-pixel-width x-display-pixel-height > + (arguments > + `(#:emacs ,emacs > + #:phases > + ;; Generate .el files from the XML description of the XCB binding= s. > + ;; This will be adjusted when xelb developer comment in issue pag= e: > + ;; https://github.com/ch11ng/xelb/issues/16 This comment is only for emacs-xelb, and shouldn't be here, right? Everything else LGTM. Please send one last patch set. There may be a few more minor corrections. I'll make them and push. I'm eager to try out exwm. I didn't know about it before your patch. Thank you! :-) =