all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christina O'Donnell <cdo@mutix.org>
To: 40316@debbugs.gnu.org
Cc: Christina O'Donnell <cdo@mutix.org>,
	zhengjunjie@iscas.ac.cn, vagrant@reproducible-builds.org,
	steve@futurile.net
Subject: bug#40316: [PATCH v2 6/6] gnu: nss: Disable FIPS in lowhashtest.
Date: Thu,  2 May 2024 12:00:50 +0100	[thread overview]
Message-ID: <bab329436b84740e67927d6ba48aae5d3bc23667.1714647502.git.cdo@mutix.org> (raw)
In-Reply-To: <5ac99f62f8c43d2df3f64cd77ccbe0540dd82269.1714647502.git.cdo@mutix.org>

* gnu/packages/nss.scm (nss): Disable FIPS in lowhashtests.
This is required as FIPS is inherently non-deterministic, making the build no
longer reproducible.

Change-Id: I2b294530b017285d0949a1082abaaf3a8fe1f6b5
---
 gnu/packages/nss.scm                          |  3 +-
 .../nss-disable-fips-in-lowhashtest.patch     | 28 +++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/nss-disable-fips-in-lowhashtest.patch

diff --git a/gnu/packages/nss.scm b/gnu/packages/nss.scm
index 08e4cb06ee..02081c32e1 100644
--- a/gnu/packages/nss.scm
+++ b/gnu/packages/nss.scm
@@ -125,7 +125,8 @@ (define-public nss
               (patches (search-patches "nss-3.56-pkgconfig.patch"
                                        "nss-getcwd-nonnull.patch"
                                        "nss-increase-test-timeout.patch"
-                                       "nss-disable-shlibsign.patch"))
+                                       "nss-disable-shlibsign.patch"
+                                       "nss-disable-fips-in-lowhashtest.patch"))
               (modules '((guix build utils)))
               (snippet
                '(begin
diff --git a/gnu/packages/patches/nss-disable-fips-in-lowhashtest.patch b/gnu/packages/patches/nss-disable-fips-in-lowhashtest.patch
new file mode 100644
index 0000000000..c8fc1e7e7a
--- /dev/null
+++ b/gnu/packages/patches/nss-disable-fips-in-lowhashtest.patch
@@ -0,0 +1,28 @@
+From f32bd353c5b741d6da5811fd40681dda80799bfb Mon Sep 17 00:00:00 2001
+Message-ID: <f32bd353c5b741d6da5811fd40681dda80799bfb.1714591857.git.cdo@mutix.org>
+From: Christina O'Donnell <cdo@mutix.org>
+Date: Wed, 1 May 2024 20:30:15 +0100
+Subject: [PATCH] nss: Disable FIPS in lowhashtest.
+
+---
+ nss/tests/lowhash/lowhash.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/nss/tests/lowhash/lowhash.sh b/nss/tests/lowhash/lowhash.sh
+index 2984b9b..9dcc89b 100755
+--- a/nss/tests/lowhash/lowhash.sh
++++ b/nss/tests/lowhash/lowhash.sh
+@@ -63,7 +63,7 @@ lowhash_test()
+   else
+     TESTS="MD5 SHA1 SHA224 SHA256 SHA384 SHA512"
+     OLD_MODE=`echo ${NSS_FIPS}`
+-    for fips_mode in 0 1; do
++    for fips_mode in 0; do
+       echo "lowhashtest with fips mode=${fips_mode}"
+       export NSS_FIPS=${fips_mode}
+       for TEST in ${TESTS}
+
+base-commit: 85b7cf166687cbfaf3e3764ed1ea9bb3b9404ef0
+-- 
+2.41.0
+
-- 
2.41.0





  parent reply	other threads:[~2024-05-02 11:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29 11:16 bug#40316: core-updates nss not reproducible Danny Milosavljevic
2020-03-30  6:09 ` Gábor Boskovits
2020-03-30 11:55 ` Marius Bakke
2020-03-31  9:28   ` Björn Höfling
2021-05-18  1:04 ` Bone Baboon via Bug reports for GNU Guix
2024-03-07 22:16   ` Vagrant Cascadian
2024-04-23 12:42 ` bug#40316: Update needed of NSS Steve George
2024-04-26 21:33 ` [PATCH 0/6] WIP: nss: Update to 3.99 Christina O'Donnell
2024-04-26 21:33   ` bug#40316: [PATCH 1/6] gnu: nss: Fix cross-compilation Christina O'Donnell
2024-04-26 21:33   ` bug#40316: [PATCH 2/6] gnu: nspr: " Christina O'Donnell
2024-04-26 21:33   ` [PATCH 3/6] gnu: nss: Make reproducible Christina O'Donnell
2024-04-26 22:58     ` bug#40316: " Vagrant Cascadian
2024-05-02 12:51       ` Christina O'Donnell
2024-04-26 21:34   ` [PATCH 4/6] gnu: nss: Update to 3.99 Christina O'Donnell
2024-04-26 21:34   ` [PATCH 5/6] gnu: nss-certs: " Christina O'Donnell
2024-04-26 21:34   ` [PATCH 6/6] WIP: nss: Attempting to resolve FIPS regression Christina O'Donnell
2024-05-02  8:15   ` bug#40316: nss not reproducible Ludovic Courtès
2024-05-02 15:20     ` Christina O'Donnell
2024-05-06 10:12       ` Ludovic Courtès
2024-05-06 11:37         ` Christina O'Donnell
2024-05-14  9:15           ` Ludovic Courtès
2024-05-05  8:00     ` Tobias Alexandra Platen
2024-05-02 11:00 ` bug#40316: [PATCH v2 0/6] Attempt to make nss reproducible Christina O'Donnell
2024-05-02 11:00   ` bug#40316: [PATCH v2 1/6] gnu: nss: Fix cross-compilation Christina O'Donnell
2024-05-02 11:00     ` bug#40316: [PATCH v2 2/6] gnu: nspr: " Christina O'Donnell
2024-05-02 11:00     ` bug#40316: [PATCH v2 3/6] gnu: nss: Update to 3.99 Christina O'Donnell
2024-05-02 11:00     ` bug#40316: [PATCH v2 4/6] gnu: nss-certs: " Christina O'Donnell
2024-05-02 11:00     ` bug#40316: [PATCH v2 5/6] gnu: nss: Attempt to disable FIPS Christina O'Donnell
2024-05-02 11:00     ` Christina O'Donnell [this message]
2024-05-02 12:42   ` bug#40316: [PATCH v2 0/6] Attempt to make nss reproducible Christina O'Donnell
2024-05-02 15:15 ` bug#40316: [PATCH v4 0/5] gnu: nss: Make reproducible Christina O'Donnell
2024-05-02 15:15   ` bug#40316: [PATCH v4 1/5] gnu: nss: Fix cross-compilation Christina O'Donnell
2024-05-02 15:15   ` bug#40316: [PATCH v4 2/5] gnu: nspr: " Christina O'Donnell
2024-05-02 15:15   ` bug#40316: [PATCH v4 3/5] gnu: nss: Update to 3.99 Christina O'Donnell
2024-05-02 15:15   ` bug#40316: [PATCH v4 4/5] gnu: nss-certs: " Christina O'Donnell
2024-05-02 15:15   ` bug#40316: [PATCH v4 5/5] gnu: nss: Make reproducible Christina O'Donnell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bab329436b84740e67927d6ba48aae5d3bc23667.1714647502.git.cdo@mutix.org \
    --to=cdo@mutix.org \
    --cc=40316@debbugs.gnu.org \
    --cc=steve@futurile.net \
    --cc=vagrant@reproducible-builds.org \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.