bug#63649: python-zope-exceptions: Build failure (in test_multiline_exception test) with Python 3.10

bug#63649: python-zope-exceptions: Build failure (in test_multiline_exception test) with Python 3.10

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 2104 bytes --]

Hi!  Building `python-zope-exceptions` 4.4 fails in the version of Guix shown below:

```
$ LANG=C guix describe
Generation 56   May 02 2023 11:25:26    (current)
  guix 3f8c489
    repository URL: https://git.savannah.gnu.org/git/guix.git
    branch: master
    commit: 3f8c4899a9a67bb509a603bd21dcfcfab88c0e8e
```

It looks like a Python 3.10 issue fixed in a newer upstream version.  This is
the final part of the build log:

```
starting phase `check'
Running zope.testrunner.layer.UnitTests tests:
  Set up zope.testrunner.layer.UnitTests in 0.000 seconds.


Failure in test test_multiline_exception (zope.exceptions.tests.test_exceptionformatter.Test_format_exception)
Traceback (most recent call last):
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/unittest/case.py", line 591, in run
    self._callTestMethod(testMethod)
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/unittest/case.py", line 549, in _callTestMethod
    method()
  File "/gnu/store/yflssryyj355226m2nq5m4971s88cmpz-python-zope-exceptions-bootstrap-4.4/lib/python3.10/site-packages/zope/exceptions/tests/test_exceptionformatter.py", line 670, in test_multiline_exception
    self.assertTrue(lines[1].endswith('    ^'))
  File "/gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/unittest/case.py", line 687, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true
```

Looking at the failing line, it looks like the commit below fixed it for
Python 3.10 compatibility:
<https://github.com/zopefoundation/zope.exceptions/commit/cb2d21400c95b73909b1145674c08fed31b8759a>

Probably version >= 4.5 of the package (which claims "Add official support for
Python 3.9 and 3.10." does work (I've been unable to figure out the proper
`--with-XXXX` incantation to assert that).

Thanks!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#63649: [PATCH] gnu: python-zope-exceptions: Update to 4.6, Python 3.10 compatible.

[Ivan Vilata i Balaguer]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

Versions 4.5 and 4.6 seem to be backwards-compatible with 4.5, and they add
official support for Python 3.9, 3.10 and 3.11.

Fixes <https://issues.guix.gnu.org/63649>.

* gnu/packages/python-web.scm (python-zope-exceptions): Update to 4.6.
---
 gnu/packages/python-web.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b6ad489626..32c0de3f57 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -59,6 +59,7 @@
 ;;; Copyright © 2022 Michael Rohleder <mike@rohleder.de>
 ;;; Copyright © 2022 Baptiste Strazzulla <bstrazzull@hotmail.fr>
 ;;; Copyright © 2023 John Kehayias <john.kehayias@protonmail.com>
+;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan@selidor.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2493,14 +2494,14 @@ (define-public python-zope-interface
 (define-public python-zope-exceptions
   (package
     (name "python-zope-exceptions")
-    (version "4.4")
+    (version "4.6")
     (source
      (origin
        (method url-fetch)
        (uri (pypi-uri "zope.exceptions" version))
        (sha256
         (base32
-         "1nkgfwawswmyc6i0b8g3ymvja4mb507m8yhid8s4rbxq3dmqhwhd"))))
+         "1kc3hql2i35ys5alkj9csiaz2s9bx0rff585vnrrgvavqsj297b1"))))
     (build-system python-build-system)
     (arguments
      '(#:phases

base-commit: dff1689bb37e5303868584d3f1d7a33cbcb7f51e
-- 
2.39.2


-- 
Ivan Vilata i Balaguer -- https://elvil.net/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#63649: python-zope-exceptions: Build failure (in test_multiline_exception test) with Python 3.10

[jgart via Bug reports for GNU Guix]

Hi Ivan,

Applied. Thanks!

all best,

jgart