From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 0HB4Mg6002FFdgEAgWs5BA (envelope-from ) for ; Tue, 04 Jan 2022 03:42:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yA/RLg6002HUjgAAauVa8A (envelope-from ) for ; Tue, 04 Jan 2022 03:42:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47C9DDFCD for ; Tue, 4 Jan 2022 03:42:22 +0100 (CET) Received: from localhost ([::1]:45290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4ZmG-0005Xn-4c for larch@yhetil.org; Mon, 03 Jan 2022 21:42:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4Zly-0005Uu-2k for guix-patches@gnu.org; Mon, 03 Jan 2022 21:42:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4Zlx-0008KK-NZ for guix-patches@gnu.org; Mon, 03 Jan 2022 21:42:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4Zlx-0000Gs-K8 for guix-patches@gnu.org; Mon, 03 Jan 2022 21:42:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51765] Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Jan 2022 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher , 51765@debbugs.gnu.org Received: via spool by 51765-submit@debbugs.gnu.org id=B51765.16412641131029 (code B ref 51765); Tue, 04 Jan 2022 02:42:01 +0000 Received: (at 51765) by debbugs.gnu.org; 4 Jan 2022 02:41:53 +0000 Received: from localhost ([127.0.0.1]:36657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4Zlp-0000GV-5k for submit@debbugs.gnu.org; Mon, 03 Jan 2022 21:41:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]:34549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4Zlk-0000GD-6T for 51765@debbugs.gnu.org; Mon, 03 Jan 2022 21:41:51 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id D144A240103 for <51765@debbugs.gnu.org>; Tue, 4 Jan 2022 03:41:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1641264101; bh=a62e8f7Nx9y4agsJGCL1uESbRwo54yFJM9yMHEqGoio=; h=Subject:From:To:Date:From; b=fBNIK6SrTs9DImDvumDUwubjwpp3KSp8DZmTAGJTW61XhoPqxQCrt2RVNYmbRuGKj 3nENHQttVHwe+0NFZpeGCF5VZBTfz6vcwJCR2tk2s5QAjHrDNUVbii3U8PvqFE99Sm FP930u8DnNvg5lhHp5N/1bWc+IpSK85WlzTQRMThxEp/yZjW1IVoFx+C+OJj4P34SV b6x+hJJynmx2Jzmzg+LdNVTY4fX5Y2z2howqjFgu4B4+uuTz7rVcUXoalrQ4wmj+DB nbPjReOfNDZwktNhaMPHM5lXvOSVMEX1blPqHaxMoNgYvQ2AOSOoaDE6InWRAx/Dzi mB+BWp/Pls8UQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JScM71nv2z9rxD; Tue, 4 Jan 2022 03:41:38 +0100 (CET) Message-ID: From: Vinicius Monego Date: Tue, 04 Jan 2022 02:41:29 +0000 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641264142; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=aNKVLuc5v7rBPteOpDYD2ZGag+s2EDKHB/sd+HQcl5o=; b=JQZSsByimzzttaN/04G7N8txsW2p8QhS6KIS+mBBKfblTJ6PGX0eeNe8xcVX9c+ZQdtP82 ImzQhWJqRgrZkgmAT7P2e1woMsIodYS03nFxqyflu2wpd35jzCsbOGZ1ijbZ9v7JrYvJBi NOfpYhCXNEHWJ1k9kdaeEcJm+B0AX0cquvMOagysepsYqLhSyK+nfpDg883pdq7k2s+ENp RzD5C/4Q8vwnX0dM2W7Jf1Vhq+mhaQVEPSMVu9I8+r6Xp5fYO0Ddukjt38BUl12bCb27v+ RbmMVuB9kyealELBza7bkKWNZNUwCQXZ6LSjx0Tr00RnvmroxpwFBXrTSJZoog== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641264142; a=rsa-sha256; cv=none; b=uT48Rb6Dm3+IQ2VHEWLPxzGnhODmCVYqGd+37fy/WKmH6cFjxPZu2bEWnqUU72x8aFxZlW N/bKU0IyrCAt0h3YQKnRlbnph5xQSuesrh4nHAgnqE0CBKziWEhWK2QbyLow6HFTaAA3+I nG4ddihDsRPXKE5poIzlxCPK1WOfKdvIfiKsT9jhiIBrn6yF6skmn5cNT4wvF8IlnT81AY GcJAHLlVoNhmuVU8/mmlf0bUUiJjFUwMwWy+BIU8BIMwFRso7nZQFHL8yxFc8lCZ/ky2h0 sbmjXkDnKLcT9Aoh1MVi6mEgULENf02iGdjF3iteNRc+ygiXN/6/BanhsF352A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=fBNIK6Sr; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=fBNIK6Sr; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 47C9DDFCD X-Spam-Score: -2.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: yuYHk/Um52wb Hi Sharlatan, I am commenting on the second patch and will comment on the others in this same message. > + (arguments > + (list > + ;; FIXME: (Sharlatan-20211229T160902+0000): tests run via tox > + #:tests? #f)) The procedure is more or less the same for all Astropy related packages. They use tox as an abstraction for pytest. You can run tests by overriding the check phase: > (arguments > `(#:phases > (modify-phases %standard-phases > (replace 'check > (lambda* (#:key inputs outputs tests? #:allow-other-keys) > (when tests? > (add-installed-pythonpath inputs outputs) > (invoke "python" "-m" "pytest"))))))) I also had to add a few more native inputs: > (native-inputs > (list python-jsonschema > python-numpy > python-pytest > python-pyyaml > python-semantic-version > python-setuptools-scm)) It should work all the same for the remaining packages in the series. There's no need to add a comment about the copyright holder: > + ;; Copyright (C) 2021 Association of Universities for Research > in Astronomy (AURA) > + ;; > https://github.com/asdf-format/asdf-transform-schemas/blob/master/LICENSE Some of the other patches like 3 and 4 do not follow description standards like missing full sentences and full stop. You can run `guix lint` in the packages to catch some linting errors. In patch 6, gexp is being used without ungexp. In that case it shouldn't be used. `(arguments (list ...))` should be `(arguments `())` when gexp isn't being used, same for the other patches too. gwcs license is bsd-3 according to copyright headers and the LICENSE file in the license/ directory. Inputs in patches 5 and 6 may also have to be propagated if they are libraries.