From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cKZWBp9oN2J8zgAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 18:47:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GC3LA59oN2KDLQEA9RJhRA (envelope-from ) for ; Sun, 20 Mar 2022 18:47:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A84383D866 for ; Sun, 20 Mar 2022 18:47:10 +0100 (CET) Received: from localhost ([::1]:36330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVze0-0003oM-ST for larch@yhetil.org; Sun, 20 Mar 2022 13:47:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVzOR-0003vk-1p for guix-patches@gnu.org; Sun, 20 Mar 2022 13:31:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVzOQ-0003TQ-Ky for guix-patches@gnu.org; Sun, 20 Mar 2022 13:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVzOQ-0008LC-GV for guix-patches@gnu.org; Sun, 20 Mar 2022 13:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54482] [PATCH] gnu: Add simavr Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54482 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Artyom V. Poptsov" , 54482@debbugs.gnu.org Received: via spool by 54482-submit@debbugs.gnu.org id=B54482.164779743532027 (code B ref 54482); Sun, 20 Mar 2022 17:31:02 +0000 Received: (at 54482) by debbugs.gnu.org; 20 Mar 2022 17:30:35 +0000 Received: from localhost ([127.0.0.1]:35105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVzNz-0008KV-7m for submit@debbugs.gnu.org; Sun, 20 Mar 2022 13:30:35 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:39256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVzNw-0008KJ-Vu for 54482@debbugs.gnu.org; Sun, 20 Mar 2022 13:30:34 -0400 Received: from [192.168.100.254] ([213.119.180.246]) by michel.telenet-ops.be with bizsmtp id 8hWW2700K5KN8Qt06hWW18; Sun, 20 Mar 2022 18:30:31 +0100 Message-ID: From: Maxime Devos Date: Sun, 20 Mar 2022 18:30:22 +0100 In-Reply-To: <878rt4shrc.fsf@gmail.com> References: <878rt4shrc.fsf@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-JxAaoPPeOuG/0AGO784p" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647797431; bh=GwWPJ/dab9VS0Kwa8RzPnTrJHVrm0XzEu2xb1AtQEYA=; h=Subject:From:To:Date:In-Reply-To:References; b=JZpzyOs5TF/3dryXpTAZMzcj9CRjCsizKmky6XE9ywQOGWYRR9yHBbY1FlhXGX1NS cU96sbJb/IPi6OVExY6FtTRWPFxebebwjsP1CRiR3Ry+ghzVz2jE1v1epRrT8g5sFN SaSwaKzckINsJe7+Ceb/GHOo4j3cVOnlHbFTHvfGTPELgaskGrmp2jl0ni08Pw+Ca6 3a1SMWVSMJj55DcMzyHXu8RmqHzJjOZW5EkU3J3XD7EzR+rRjsgS79Gpq3+PJMu8Ls ngGZiqD4JeNzpKCj1FAAjqVz+fmSnAxEjTmfJ9INxXO5qW1VB7RUp32cTA25XE0ZG9 G/yw4xs685VLw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647798430; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=GwWPJ/dab9VS0Kwa8RzPnTrJHVrm0XzEu2xb1AtQEYA=; b=jhIoj+nSp4F+UgNnlRDIrXVJSp13YtMdIw/gomZ1SwEpv+Qa3jlyMhOCO3P5b2wDi4dcRQ mAORdDs0xabdUu2HslR+M9gHPbtRTxyP7xjxB8FKlhR2r3P0Ij5QCuy2XvmQRt8CgDskpr iM4BPgLmCKzeeN9kgTu20sxzKO9QR97GvQnGk4A3F7/LKZDFfnHPcrMhU7p2ynvLKVs5PK dpp9hst1Z1aXFJNXSGpBpIie4SHv5mx94MP260zVbg6STUslQ+n7hWLP76Bsc5Zojb+gd0 oJpAIheYtMuxD7elhGJkCldEFxCMIXrJgJX+ejj4v/5gVycn942hmqbHRHzBrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647798430; a=rsa-sha256; cv=none; b=bGQYfljQuITLVFKVKkOCII8sk/RmpQp0z1EtBHriAu6/NibS1ctOY30Z/B4gq1Q73AWcvO fKkZ7pl6FJ7NNTgQ/gdGVvU10NV4WdKhzdUDCL3odip5vSq2aeyxafLMkKqPhgBntNiZp9 PlB2u4Au/CiP00f35xnR5rcEMbBWORtwvzoJVI52fjZdJmN6S4gtamlsnMclpcZ3eFyVJo 5+qqeb5ncSC4aByMW8CKbgCovXnzGVJCFjj7JFqwjB7M2jFIKy+NkoRIRpRDZRIjDlDdrH cx5KBb2J0aRKzuGkmFgLSGT1RURP36olVbQUUvZKEKOWO7M/1N45QI+CqXOwcQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=JZpzyOs5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=JZpzyOs5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A84383D866 X-Spam-Score: 3.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: vF+HQbLFGQau --=-JxAaoPPeOuG/0AGO784p Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Artyom V. Poptsov schreef op zo 20-03-2022 om 19:36 [+0300]: > +=C2=A0 #:use-module (gnu packages autotools) > +=C2=A0 #:use-module (gnu packages base) > +=C2=A0 #:use-module (gnu packages bash) > +=C2=A0 #:use-module (gnu packages avr) Why is (gnu packages avr) importing (gnu packages avr)? > +=C2=A0 #:use-module (gnu packages elf) > +=C2=A0 #:use-module (gnu packages gl) > +=C2=A0 #:use-module (gnu packages pkg-config) > +=C2=A0 #:use-module (gnu packages ncurses) > +=C2=A0 #:use-module (gnu packages version-control) > +=C2=A0 #:use-module (gnu packages ruby)) I think most users of avr-libc and avr-toolchain don't need simavr, so WDYT of defining simavr in a separate module to avoid loading the (gnu packages ruby) module (which has a large closure, including much of haskell, java) unless actually necessary? Benefits are lower memory usage and less startup time. Long-term, separating modules (*) a bit more would help with avoiding circular imports (and maybe eventually, making sure imports aren't circular at compile-time), makings some ideas for making "guix pull" faster more feasible and effective. I don't think any conclusion was reached upon that though ... (*) Though in this case, there doesn't appear to be any circularity, yet. Greetings, Maxime. --=-JxAaoPPeOuG/0AGO784p Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjdkrhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sP/AP9MWKReBMtg6qj3EIyUwiDVnbrw KNaTeLYwQprEsT5BbgEAy6luIlCCD0Dj4iCVBRr/y9vjuwKi9fDh+V2gz2Jdago= =Z2L5 -----END PGP SIGNATURE----- --=-JxAaoPPeOuG/0AGO784p--