all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Add new package: aspell-dict-pt
@ 2017-08-07  0:27 Daniel Pimentel
  2017-08-07  1:21 ` Tobias Geerinckx-Rice
  2017-08-18  1:00 ` Daniel Pimentel
  0 siblings, 2 replies; 5+ messages in thread
From: Daniel Pimentel @ 2017-08-07  0:27 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

Guixs,

Add new package aspell-dict-pt: gnu/packages/aspell.scm

Happy hacking,


-- 
Daniel Pimentel (d4n1)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-package.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-package.patch, Size: 1298 bytes --]

From 1e164f7a5b456f5a2f5bd9b215340e207560e29a Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Sun, 6 Aug 2017 21:24:45 -0300
Subject: [PATCH] gnu: Add package * gnu/packages/aspell.scm: Add new package.

---
 gnu/packages/aspell.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 509d428f6..0bf4e4a8e 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Christopher Andersson <christopher@8bits.nu>
 ;;; Copyright © 2016 Theodoros Foradis <theodoros.for@openmailbox.org>
+;;; Copyright © 2017 Daniel Pimentel <d4n1@d4n1.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -209,3 +210,11 @@ dictionaries, including personal ones.")
                      #:sha256
                      (base32
                       "1y09lx9zf2rnp55r16b2vgj953l3538z1vaqgflg9mdvm555bz3p")))
+
+(define-public aspell-dict-pt
+  (aspell-dictionary "pt" "Portuguese"
+                     #:version "20070510-0"
+                     #:prefix "aspell6-"
+                     #:sha256
+                     (base32
+                      "1mnr994cwlag6shy8865ky99lymysiln07mbldcncahg90dagdxq")))
-- 
2.13.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Add new package: aspell-dict-pt
  2017-08-07  0:27 Add new package: aspell-dict-pt Daniel Pimentel
@ 2017-08-07  1:21 ` Tobias Geerinckx-Rice
  2017-08-10 13:36   ` Daniel Pimentel
  2017-08-18  1:00 ` Daniel Pimentel
  1 sibling, 1 reply; 5+ messages in thread
From: Tobias Geerinckx-Rice @ 2017-08-07  1:21 UTC (permalink / raw)
  To: d4n1, guix-devel

Daniel,

Daniel Pimentel wrote on 07/08/17 at 02:27:
> Add new package aspell-dict-pt: gnu/packages/aspell.scm
Thanks! I went ahead and fixed up the commit message to match our
conventions (see your previous commit to aspell.scm as pushed by Ludo').

Only one small question: the package uses simply ‘pt’ as the language
code, while <ftp://ftp.gnu.org/gnu/aspell/dict/0index.html> uses
‘pt_PT’. Should we follow that example? Or is it needlessly redundant?

I know nothing of the linguistics or politics involved...

Kind regards,

T G-R

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Add new package: aspell-dict-pt
  2017-08-07  1:21 ` Tobias Geerinckx-Rice
@ 2017-08-10 13:36   ` Daniel Pimentel
  2017-08-10 16:29     ` Tobias Geerinckx-Rice
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Pimentel @ 2017-08-10 13:36 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: guix-devel

I think better 'pt_PT' but maybe it's redundant.
Can I change to pt_PT?

Thanks,

---
Daniel Pimentel (d4n1)

On 2017-08-06 22:21, Tobias Geerinckx-Rice wrote:
> Daniel,
> 
> Daniel Pimentel wrote on 07/08/17 at 02:27:
>> Add new package aspell-dict-pt: gnu/packages/aspell.scm
> Thanks! I went ahead and fixed up the commit message to match our
> conventions (see your previous commit to aspell.scm as pushed by 
> Ludo').
> 
> Only one small question: the package uses simply ‘pt’ as the language
> code, while <ftp://ftp.gnu.org/gnu/aspell/dict/0index.html> uses
> ‘pt_PT’. Should we follow that example? Or is it needlessly redundant?
> 
> I know nothing of the linguistics or politics involved...
> 
> Kind regards,
> 
> T G-R

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Add new package: aspell-dict-pt
  2017-08-10 13:36   ` Daniel Pimentel
@ 2017-08-10 16:29     ` Tobias Geerinckx-Rice
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Geerinckx-Rice @ 2017-08-10 16:29 UTC (permalink / raw)
  To: d4n1; +Cc: guix-devel

Daniel,

I just noticed we're on guix-devel. Next time, please send patches
directly to guix-patches@gnu.org, where they're slightly less likely to
get lost.

Daniel Pimentel wrote on 10/08/17 at 15:36:
> I think better 'pt_PT' but maybe it's redundant.
> Can I change to pt_PT?

My preference too! Do note that it would become ‘aspell-dict-pt-pt’
under Guix's package naming conventions[0].

I'll push it with these changes, if that's all right by you.

Thanks!

T G-R

[0]: Section 6.7.2 of the Guix manual: “[names] correspond to the
lowercase conversion of the project name chosen upstream, with
underscores replaced with hyphens.”

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Add new package: aspell-dict-pt
  2017-08-07  0:27 Add new package: aspell-dict-pt Daniel Pimentel
  2017-08-07  1:21 ` Tobias Geerinckx-Rice
@ 2017-08-18  1:00 ` Daniel Pimentel
  1 sibling, 0 replies; 5+ messages in thread
From: Daniel Pimentel @ 2017-08-18  1:00 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

Guixs,

follow the new package aspell-dict-pt-pt refactored.

Thanks,

---
Daniel Pimentel (d4n1)

On 2017-08-06 21:27, Daniel Pimentel wrote:
> Guixs,
> 
> Add new package aspell-dict-pt: gnu/packages/aspell.scm
> 
> Happy hacking,

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-add-aspell-dict-pt-pt.patch --]
[-- Type: text/x-diff; name=0001-gnu-add-aspell-dict-pt-pt.patch, Size: 1327 bytes --]

From 1f5fe6658d203346419f868e1401dbdf9f4b1c23 Mon Sep 17 00:00:00 2001
From: Daniel Pimentel <d4n1@d4n1.org>
Date: Thu, 17 Aug 2017 21:59:21 -0300
Subject: [PATCH] gnu: add aspell-dict-pt-pt * gnu/packages/aspell.scm: add new
 package

---
 gnu/packages/aspell.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/aspell.scm b/gnu/packages/aspell.scm
index 3469c7a3e..9a0a284c1 100644
--- a/gnu/packages/aspell.scm
+++ b/gnu/packages/aspell.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016 Christopher Andersson <christopher@8bits.nu>
 ;;; Copyright © 2016 Theodoros Foradis <theodoros.for@openmailbox.org>
 ;;; Copyright © 2016, 2017 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2017 Daniel Pimentel <d4n1@d4n1.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -210,3 +211,11 @@ dictionaries, including personal ones.")
                      #:sha256
                      (base32
                       "1y09lx9zf2rnp55r16b2vgj953l3538z1vaqgflg9mdvm555bz3p")))
+
+(define-public aspell-dict-pt-pt
+  (aspell-dictionary "pt-pt" "Portuguese Portugal"
+                     #:version "20070510-0"
+                     #:prefix "aspell6-"
+                     #:sha256
+                     (base32
+                      "1mnr994cwlag6shy8865ky99lymysiln07mbldcncahg90dagdxq")))
-- 
2.13.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-08-18  1:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-07  0:27 Add new package: aspell-dict-pt Daniel Pimentel
2017-08-07  1:21 ` Tobias Geerinckx-Rice
2017-08-10 13:36   ` Daniel Pimentel
2017-08-10 16:29     ` Tobias Geerinckx-Rice
2017-08-18  1:00 ` Daniel Pimentel

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.